linux-next: build failure after merge of the final tree (regulator tree related)

linux-next: build failure after merge of the final tree (regulator tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

Hi ,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/misc/max8997-muic.c: In function 'max8997_muic_irq_work':
drivers/misc/max8997-muic.c:313:34: error: 'struct max8997_platform_data' has no member named 'irq_base'
drivers/misc/max8997-muic.c: In function 'max8997_muic_probe':
drivers/misc/max8997-muic.c:434:35: error: 'struct max8997_platform_data' has no member named 'irq_base'
drivers/misc/max8997-muic.c: In function 'max8997_muic_remove':
drivers/misc/max8997-muic.c:474:17: error: 'struct max8997_platform_data' has no member named 'irq_base'

Caused by commit 98d8618af377 ("mfd: add irq domain support for max8997
interrupts").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (regulator tree related)

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

On Tue, Apr 17, 2012 at 02:27:48PM +1000, Stephen Rothwell wrote:

> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:

> drivers/misc/max8997-muic.c: In function 'max8997_muic_irq_work':
> drivers/misc/max8997-muic.c:313:34: error: 'struct max8997_platform_data' has no member named 'irq_base'
> drivers/misc/max8997-muic.c: In function 'max8997_muic_probe':
> drivers/misc/max8997-muic.c:434:35: error: 'struct max8997_platform_data' has no member named 'irq_base'
> drivers/misc/max8997-muic.c: In function 'max8997_muic_remove':
> drivers/misc/max8997-muic.c:474:17: error: 'struct max8997_platform_data' has no member named 'irq_base'

> Caused by commit 98d8618af377 ("mfd: add irq domain support for max8997
> interrupts").

> I have reverted that commit for today.

I've just reverted it, Thomas please submit a fixed version along with
the regulator patch.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (regulator tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/regulator/twl-regulator.c: In function 'twlreg_probe':
drivers/regulator/twl-regulator.c:1229:3: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]

Caused by commit 537fbe92d723 ("regulator: twl: make twl_info tables
const") from the regulator tree.

I have added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 16 Aug 2012 15:11:22 +1000
Subject: [PATCH] regulator: using kfree() requires including slab.h

Fixes this build error:

drivers/regulator/twl-regulator.c: In function 'twlreg_probe':
drivers/regulator/twl-regulator.c:1229:3: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]

Also added string.h for kmemdup().

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/regulator/twl-regulator.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index a836522..564acae 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -10,6 +10,8 @@
  */
 
 #include <linux/module.h>
+#include <linux/string.h>
+#include <linux/slab.h>
 #include <linux/init.h>
 #include <linux/err.h>
 #include <linux/platform_device.h>
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (regulator tree related)

[Arnd Bergmann]

On Thursday 16 August 2012, Stephen Rothwell wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 16 Aug 2012 15:11:22 +1000
> Subject: [PATCH] regulator: using kfree() requires including slab.h
> 
> Fixes this build error:
> 
> drivers/regulator/twl-regulator.c: In function 'twlreg_probe':
> drivers/regulator/twl-regulator.c:1229:3: error: implicit declaration of
> function 'kfree' [-Werror=implicit-function-declaration]
> 
> Also added string.h for kmemdup().
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Acked-by: Arnd Bergmann <arnd@arndb.de>

Thanks Stephen and sorry for bothering everyone with this. I had
actually found the same problem and fixed it locally but forgot
to send out the fixed version.

	Arnd

Re: linux-next: build failure after merge of the final tree (regulator tree related)

[Mark Brown]

On Thu, Aug 16, 2012 at 03:16:05PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:

Applied, thanks.  I can't help but thinking that slab.h should just be
automatically included, it's so widely used and frequently included
implicitly that I bet it causes more time to be burned on this sort of
error than has ever been saved by not referencing it.

linux-next: build failure after merge of the final tree (regulator tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/regulator/da9052-regulator.c: In function 'da9052_regulator_probe':
drivers/regulator/da9052-regulator.c:442:3: error: implicit declaration of function 'of_find_node_by_name' [-Werror=implicit-function-declaration]
drivers/regulator/da9052-regulator.c:442:10: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/regulator/da9052-regulator.c:446:3: error: implicit declaration of function 'of_get_next_child' [-Werror=implicit-function-declaration]
drivers/regulator/da9052-regulator.c:446:11: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/regulator/da9052-regulator.c:447:11: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/regulator/da9052-regulator.c:448:4: error: implicit declaration of function 'of_node_cmp' [-Werror=implicit-function-declaration]
drivers/regulator/da9052-regulator.c:448:23: error: dereferencing pointer to incomplete type
cc1: some warnings being treated as errors

Caused by commit 88c84c14cca4 ("regulator: da9052: add device tree support").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (regulator tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/mfd/twl-core.c: In function 'add_children':
drivers/mfd/twl-core.c:752:10: error: 'struct regulator_consumer_supply' has no member named 'dev'
drivers/mfd/twl-core.c:753:10: error: 'struct regulator_consumer_supply' has no member named 'dev'
drivers/mfd/twl-core.c:754:10: error: 'struct regulator_consumer_supply' has no member named 'dev'
drivers/mfd/twl-core.c:800:10: error: 'struct regulator_consumer_supply' has no member named 'dev'

Caused by commit 737f360d5bef ("regulator: Remove support for supplies
specified by struct device").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (regulator tree related)

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

On Fri, Feb 03, 2012 at 04:15:22PM +1100, Stephen Rothwell wrote:

> drivers/mfd/twl-core.c: In function 'add_children':
> drivers/mfd/twl-core.c:752:10: error: 'struct regulator_consumer_supply' has no member named 'dev'
> drivers/mfd/twl-core.c:753:10: error: 'struct regulator_consumer_supply' has no member named 'dev'
> drivers/mfd/twl-core.c:754:10: error: 'struct regulator_consumer_supply' has no member named 'dev'
> drivers/mfd/twl-core.c:800:10: error: 'struct regulator_consumer_supply' has no member named 'dev'

> Caused by commit 737f360d5bef ("regulator: Remove support for supplies
> specified by struct device").

For stuff like this where it's clear that there's an issue with the
side where the failure is noticed it's helpful to also let the people
working on the driver side know - it can make things work better with
timezones.  Unfortunately the TWL driver is both very interesting and
not really getting TLC so it's not a great example here but still.  I've
CCed a bunch of random people who show up in the commit log plus Samuel.

I'll fix up this up and carry a patch via the regulator tree.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]