From: Greg KH <gregkh@linuxfoundation.org>
To: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: cooloney@gmail.com, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks
Date: Wed, 13 Feb 2013 07:54:05 -0800 [thread overview]
Message-ID: <20130213155405.GA2869@kroah.com> (raw)
In-Reply-To: <1360771110-9490-1-git-send-email-christian.gmeiner@gmail.com>
On Wed, Feb 13, 2013 at 04:58:30PM +0100, Christian Gmeiner wrote:
> During the development of this driver an in-house register
> documentation was used. The last weeks some integration tests
> were done and this problem was found. It turned out that
> the released register documentation is wrong.
>
> The fix is very simple: shift all masks by one.
>
> Our customers can control LEDs from userspace via Java,
> C++ or what every. They have running/working applications where
> they want to control led_3 but led_2 get's used.
> I got a bug report in our in-house bug tracker so it would be
> great to fix this upstream.
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
> drivers/leds/leds-ot200.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2013-02-13 15:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 15:58 [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks Christian Gmeiner
2013-02-13 15:54 ` Greg KH [this message]
2013-02-15 22:47 ` Bryan Wu
2013-02-23 9:20 ` Christian Gmeiner
2013-03-04 7:40 ` Christian Gmeiner
2013-03-05 18:46 ` Bryan Wu
2013-03-08 7:26 ` Christian Gmeiner
2013-05-12 10:11 ` Christian Gmeiner
2013-05-14 7:06 ` Christian Gmeiner
2013-05-14 17:12 ` Bryan Wu
2013-05-14 17:16 ` Andrew Morton
2013-05-14 17:36 ` Bryan Wu
2013-05-15 6:38 ` Christian Gmeiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213155405.GA2869@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=christian.gmeiner@gmail.com \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).