From: Christian Gmeiner <christian.gmeiner@gmail.com>
To: Bryan Wu <cooloney@gmail.com>
Cc: akpm <akpm@linux-foundation.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks
Date: Fri, 8 Mar 2013 08:26:56 +0100 [thread overview]
Message-ID: <CAH9NwWeMMYzvE0VVMCYmF9oXA-wBiW-BnwoK1q7mjUkE4JF9uw@mail.gmail.com> (raw)
In-Reply-To: <CAK5ve-JmVes+OA3MRyoZEo_Fz8_RHpdqmcTxNwwrUAnADpqvyw@mail.gmail.com>
2013/3/5 Bryan Wu <cooloney@gmail.com>:
> On Sun, Mar 3, 2013 at 11:40 PM, Christian Gmeiner
> <christian.gmeiner@gmail.com> wrote:
>> ping
>> --
>> Christian Gmeiner, MSc
>>
>>
>> 2013/2/23 Christian Gmeiner <christian.gmeiner@gmail.com>:
>>> 2013/2/15 Bryan Wu <cooloney@gmail.com>:
>>>> On Wed, Feb 13, 2013 at 7:58 AM, Christian Gmeiner
>>>> <christian.gmeiner@gmail.com> wrote:
>>>>> During the development of this driver an in-house register
>>>>> documentation was used. The last weeks some integration tests
>>>>> were done and this problem was found. It turned out that
>>>>> the released register documentation is wrong.
>>>>>
>>>>> The fix is very simple: shift all masks by one.
>>>>>
>>>>> Our customers can control LEDs from userspace via Java,
>>>>> C++ or what every. They have running/working applications where
>>>>> they want to control led_3 but led_2 get's used.
>>>>> I got a bug report in our in-house bug tracker so it would be
>>>>> great to fix this upstream.
>>>>>
>>>>> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>>>>
>>>> Thanks, Christian.
>>>>
>>>> And Andrew, are you going to take care of this patch? Or I will merge this.
>>>>
>>>
>>> Whats the current state of the patch? Hope we can get it into 3.9 :)
>>>
>
> I think this patch is already in linux-next via Andrew's tree (commit
> 023206171f235f93f26c314f76f5405a3077aaba). So it will be merged into
> 3.10 I guess, but not 3.9.
>
> Or I can send out this patch to Linus as a fix and ask Andrew to drop
> this from his tree.
>
I am fine with the current situation and 3.10 is fine too.
thanks
--
Christian Gmeiner, MSc
next prev parent reply other threads:[~2013-03-08 7:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 15:58 [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks Christian Gmeiner
2013-02-13 15:54 ` Greg KH
2013-02-15 22:47 ` Bryan Wu
2013-02-23 9:20 ` Christian Gmeiner
2013-03-04 7:40 ` Christian Gmeiner
2013-03-05 18:46 ` Bryan Wu
2013-03-08 7:26 ` Christian Gmeiner [this message]
2013-05-12 10:11 ` Christian Gmeiner
2013-05-14 7:06 ` Christian Gmeiner
2013-05-14 17:12 ` Bryan Wu
2013-05-14 17:16 ` Andrew Morton
2013-05-14 17:36 ` Bryan Wu
2013-05-15 6:38 ` Christian Gmeiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH9NwWeMMYzvE0VVMCYmF9oXA-wBiW-BnwoK1q7mjUkE4JF9uw@mail.gmail.com \
--to=christian.gmeiner@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).