linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
	sfr@canb.auug.org.au
Subject: Re: [PATCH] zcache/debug: compiler failure on PPC64.
Date: Thu, 7 Mar 2013 09:31:58 +0800	[thread overview]
Message-ID: <20130307013158.GC2910@kroah.com> (raw)
In-Reply-To: <1362615216-12293-1-git-send-email-konrad.wilk@oracle.com>

On Wed, Mar 06, 2013 at 07:13:36PM -0500, Konrad Rzeszutek Wilk wrote:
> On PPC64 we get this:
> In file included from drivers/staging/zcache/debug.c:2:
> drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> drivers/staging/zcache/debug.h:16: error: implicit declaration of function 'BUG_ON'
> 
> This simple patch adds the appropiate header file to finish
> the compile.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  drivers/staging/zcache/debug.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h
> index eef67db..0d9c6b4 100644
> --- a/drivers/staging/zcache/debug.h
> +++ b/drivers/staging/zcache/debug.h
> @@ -1,5 +1,6 @@
>  #ifdef CONFIG_ZCACHE_DEBUG
>  
> +#include <linux/bug.h>
>  /* we try to keep these statistics SMP-consistent */

Put the #include files at the top of the file.

Also, you didn't really test this on linux-next as you can't select this
option at the moment, I think you also want to fix that at the same
time, unless you really don't want anyone to ever select this option :)

Try it again?

thanks,

greg k-h

      reply	other threads:[~2013-03-07  1:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07  0:13 [PATCH] zcache/debug: compiler failure on PPC64 Konrad Rzeszutek Wilk
2013-03-07  1:31 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130307013158.GC2910@kroah.com \
    --to=greg@kroah.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).