* [PATCH] zcache/debug: compiler failure on PPC64.
@ 2013-03-07 0:13 Konrad Rzeszutek Wilk
2013-03-07 1:31 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-03-07 0:13 UTC (permalink / raw)
To: linux-kernel, linux-next, sfr, greg; +Cc: Konrad Rzeszutek Wilk
On PPC64 we get this:
In file included from drivers/staging/zcache/debug.c:2:
drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
drivers/staging/zcache/debug.h:16: error: implicit declaration of function 'BUG_ON'
This simple patch adds the appropiate header file to finish
the compile.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
drivers/staging/zcache/debug.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h
index eef67db..0d9c6b4 100644
--- a/drivers/staging/zcache/debug.h
+++ b/drivers/staging/zcache/debug.h
@@ -1,5 +1,6 @@
#ifdef CONFIG_ZCACHE_DEBUG
+#include <linux/bug.h>
/* we try to keep these statistics SMP-consistent */
static ssize_t zcache_obj_count;
static atomic_t zcache_obj_atomic = ATOMIC_INIT(0);
--
1.8.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] zcache/debug: compiler failure on PPC64.
2013-03-07 0:13 [PATCH] zcache/debug: compiler failure on PPC64 Konrad Rzeszutek Wilk
@ 2013-03-07 1:31 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-03-07 1:31 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: linux-kernel, linux-next, sfr
On Wed, Mar 06, 2013 at 07:13:36PM -0500, Konrad Rzeszutek Wilk wrote:
> On PPC64 we get this:
> In file included from drivers/staging/zcache/debug.c:2:
> drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> drivers/staging/zcache/debug.h:16: error: implicit declaration of function 'BUG_ON'
>
> This simple patch adds the appropiate header file to finish
> the compile.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> drivers/staging/zcache/debug.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h
> index eef67db..0d9c6b4 100644
> --- a/drivers/staging/zcache/debug.h
> +++ b/drivers/staging/zcache/debug.h
> @@ -1,5 +1,6 @@
> #ifdef CONFIG_ZCACHE_DEBUG
>
> +#include <linux/bug.h>
> /* we try to keep these statistics SMP-consistent */
Put the #include files at the top of the file.
Also, you didn't really test this on linux-next as you can't select this
option at the moment, I think you also want to fix that at the same
time, unless you really don't want anyone to ever select this option :)
Try it again?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-07 1:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-07 0:13 [PATCH] zcache/debug: compiler failure on PPC64 Konrad Rzeszutek Wilk
2013-03-07 1:31 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).