* add_taint() change left s390 alone
@ 2013-03-20 8:38 Heiko Carstens
2013-03-20 9:08 ` Stephen Rothwell
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Carstens @ 2013-03-20 8:38 UTC (permalink / raw)
To: Rusty Russell, Stephen Rothwell; +Cc: linux-next
Hi Rusty,
your commit "taint: add explicit flag to show whether lock dep is still OK."
missed to change the s390 invocation of add_taint():
CC arch/s390/kernel/dumpstack.o
arch/s390/kernel/dumpstack.c: In function ‘die’:
arch/s390/kernel/dumpstack.c:228:2: error: too few arguments to function ‘add_taint’
Could be that this is a merge issue since dumpstack.c is a new file which
contains stuff that was formerly in arch/s390/kernel/traps.c
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: add_taint() change left s390 alone
2013-03-20 8:38 add_taint() change left s390 alone Heiko Carstens
@ 2013-03-20 9:08 ` Stephen Rothwell
2013-03-20 9:19 ` Heiko Carstens
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2013-03-20 9:08 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Rusty Russell, linux-next
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
Hi Heilo,
On Wed, 20 Mar 2013 09:38:44 +0100 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
>
> your commit "taint: add explicit flag to show whether lock dep is still OK."
> missed to change the s390 invocation of add_taint():
>
> CC arch/s390/kernel/dumpstack.o
> arch/s390/kernel/dumpstack.c: In function ‘die’:
> arch/s390/kernel/dumpstack.c:228:2: error: too few arguments to function ‘add_taint’
>
> Could be that this is a merge issue since dumpstack.c is a new file which
> contains stuff that was formerly in arch/s390/kernel/traps.c
The commit (9ff3d92a818e "s390/dumpstack: fix call chain walking" in
today's version of the s390 tree) that adds dumpstack.c has add_taint()
with 2 arguments removed from traps.c and add_taint() with one argument
added to dumpstack.c ... and add_taint() already has 2 arguments in that
tree ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: add_taint() change left s390 alone
2013-03-20 9:08 ` Stephen Rothwell
@ 2013-03-20 9:19 ` Heiko Carstens
0 siblings, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2013-03-20 9:19 UTC (permalink / raw)
To: Stephen Rothwell, Martin Schwidefsky; +Cc: Rusty Russell, linux-next
On Wed, Mar 20, 2013 at 08:08:19PM +1100, Stephen Rothwell wrote:
> Hi Heilo,
>
> On Wed, 20 Mar 2013 09:38:44 +0100 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> >
> > your commit "taint: add explicit flag to show whether lock dep is still OK."
> > missed to change the s390 invocation of add_taint():
> >
> > CC arch/s390/kernel/dumpstack.o
> > arch/s390/kernel/dumpstack.c: In function ‘die’:
> > arch/s390/kernel/dumpstack.c:228:2: error: too few arguments to function ‘add_taint’
> >
> > Could be that this is a merge issue since dumpstack.c is a new file which
> > contains stuff that was formerly in arch/s390/kernel/traps.c
>
> The commit (9ff3d92a818e "s390/dumpstack: fix call chain walking" in
> today's version of the s390 tree) that adds dumpstack.c has add_taint()
> with 2 arguments removed from traps.c and add_taint() with one argument
> added to dumpstack.c ... and add_taint() already has 2 arguments in that
> tree ...
Ouch! Looks like our work flow still sucks.
Sorry for the noise and blaming others, we'll fix it up!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-20 9:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-20 8:38 add_taint() change left s390 alone Heiko Carstens
2013-03-20 9:08 ` Stephen Rothwell
2013-03-20 9:19 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).