linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kent Overstreet <koverstreet@google.com>
To: David Rientjes <rientjes@google.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-next@vger.kernel.org
Subject: Re: [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h>
Date: Mon, 8 Apr 2013 14:00:20 -0700	[thread overview]
Message-ID: <20130408210020.GI15749@google.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1304071415220.3441@chino.kir.corp.google.com>

On Sun, Apr 07, 2013 at 02:15:49PM -0700, David Rientjes wrote:
> On Wed, 27 Mar 2013, Kent Overstreet wrote:
> 
> > Nope - looks like __WARN() doesn't exist if CONFIG_BUG=n, whoops.
> > 
> > Adding this to the queue:
> > 
> > commit 796c213186b850b3e6e8d5fd5799b0fd74721ea3
> > Author: Kent Overstreet <koverstreet@google.com>
> > Date:   Wed Mar 27 12:47:45 2013 -0700
> > 
> >     bcache: Use WARN_ONCE() instead of __WARN()
> >     
> >     Signed-off-by: Kent Overstreet <koverstreet@google.com>
> > 
> > diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
> > index d4f2164..cb4578a 100644
> > --- a/drivers/md/bcache/bset.c
> > +++ b/drivers/md/bcache/bset.c
> > @@ -883,7 +883,7 @@ struct bkey *bch_btree_iter_next(struct btree_iter *iter)
> >  		iter->data->k = bkey_next(iter->data->k);
> >  
> >  		if (iter->data->k > iter->data->end) {
> > -			__WARN();
> > +			WARN_ONCE(1, "bset was corrupt!\n");
> >  			iter->data->k = iter->data->end;
> >  		}
> >  
> 
> This problem still persists in linux-next as of today, how is this fix 
> being pushed?

Sorry for the delay, I've been moving all last week - I just sent Jens a
pull request with the latest bcache fixes, though.

      reply	other threads:[~2013-04-08 21:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 17:56 [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h> Geert Uytterhoeven
2013-03-27 17:56 ` [PATCH -next 2/3] bcache: Add missing ULL suffix for 64-bit constants Geert Uytterhoeven
2013-03-27 17:56 ` [PATCH -next 3/3] bcache: Use %zu to format size_t Geert Uytterhoeven
     [not found] ` <1364406990-20541-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2013-03-27 18:21   ` [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h> Kent Overstreet
     [not found]     ` <20130327182150.GB25906-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2013-03-27 18:27       ` Randy Dunlap
2013-03-27 19:50         ` Kent Overstreet
2013-04-07 21:15           ` David Rientjes
2013-04-08 21:00             ` Kent Overstreet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130408210020.GI15749@google.com \
    --to=koverstreet@google.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).