linux-next: build warning after merge of the final tree (net-next tree related)

linux-next: build warning after merge of the final tree (net-next tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sparc32 defconfig)
produced this warning:

drivers/net/ethernet/sun/sunbmac.c: In function 'bigmac_set_multicast':
drivers/net/ethernet/sun/sunbmac.c:998:6: warning: unused variable 'i' [-Wunused-variable]

Introduced by commit bfd428daaf61 ("net: ethernet: sun: initialize
variables directly") from the net-next tree.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the final tree (net-next tree related)

[Emilio López]

Hi Stephen,

El 22/05/13 02:55, Stephen Rothwell escribió:
> Hi all,
> 
> After merging the final tree, today's linux-next build (sparc32 defconfig)
> produced this warning:
> 
> drivers/net/ethernet/sun/sunbmac.c: In function 'bigmac_set_multicast':
> drivers/net/ethernet/sun/sunbmac.c:998:6: warning: unused variable 'i' [-Wunused-variable]
> 
> Introduced by commit bfd428daaf61 ("net: ethernet: sun: initialize
> variables directly") from the net-next tree.
> 

Thank you for notifying.

After a second look at the code, I see the apple and korina patch
counterparts also leave an extra i variable now; the dm9000 patch should
be unaffected as it still uses i for other things.

@David, what would you like me to do? I can send another set of patches
fixing this, resend the full original series but fixed, or resend just
the affected patches.

Emilio

Re: linux-next: build warning after merge of the final tree (net-next tree related)

[David Miller]

From: Emilio López <emilio@elopez.com.ar>
Date: Wed, 22 May 2013 10:24:28 -0300

> @David, what would you like me to do? I can send another set of patches
> fixing this, resend the full original series but fixed, or resend just
> the affected patches.

Your patch series is in my tree and will not be reverted, we never do
that.  Therefore you must send me patches which fix up these problems.

Re: linux-next: build warning after merge of the final tree (net-next tree related)

[Simon Horman]

On Thu, May 30, 2013 at 04:17:57PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (i386 defconfig)
> produced this warning:
> 
> net/netfilter/nf_nat_helper.c: In function 'mangle_contents':
> net/netfilter/nf_nat_helper.c:108:9: warning: passing argument 3 of 'memmove' makes integer from pointer without a cast [enabled by default]
> arch/x86/include/asm/string_32.h:200:7: note: expected 'size_t' but argument is of type 'sk_buff_data_t'
> 
> Presumably introduced by commit 1a37e412a022 ("net: Use 16bits for
> *_headers fields of struct skbuff").

Thanks Stephen.

I believe that you are correct. I'll prepare and post a patch ASAP.

linux-next: build warning after merge of the final tree (net-next tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

Hi all,

After merging the final tree, today's linux-next build (i386 defconfig)
produced this warning:

net/netfilter/nf_nat_helper.c: In function 'mangle_contents':
net/netfilter/nf_nat_helper.c:108:9: warning: passing argument 3 of 'memmove' makes integer from pointer without a cast [enabled by default]
arch/x86/include/asm/string_32.h:200:7: note: expected 'size_t' but argument is of type 'sk_buff_data_t'

Presumably introduced by commit 1a37e412a022 ("net: Use 16bits for
*_headers fields of struct skbuff").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]