* linux-next: build failure after merge of the final tree (device-mapper tree related)
@ 2013-10-28 14:33 Stephen Rothwell
2013-10-28 14:57 ` Mike Snitzer
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2013-10-28 14:33 UTC (permalink / raw)
To: Alasdair G Kergon, Mike Snitzer
Cc: linux-next, linux-kernel, Heinz Mauelshagen
[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/md/dm-cache-policy-hints.c: In function 'alloc_hash':
drivers/md/dm-cache-policy-hints.c:94:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
hash->table = vzalloc(sizeof(*hash->table) * hash->nr_buckets);
^
drivers/md/dm-cache-policy-hints.c:94:14: warning: assignment makes pointer from integer without a cast [enabled by default]
hash->table = vzalloc(sizeof(*hash->table) * hash->nr_buckets);
^
drivers/md/dm-cache-policy-hints.c: In function 'free_hash':
drivers/md/dm-cache-policy-hints.c:101:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
vfree(hash->table);
^
drivers/md/dm-cache-policy-hints.c: In function 'alloc_bitset':
drivers/md/dm-cache-policy-hints.c:184:2: warning: return makes pointer from integer without a cast [enabled by default]
return vzalloc(sizeof(unsigned long) * bit_set_nr_words(nr_cblocks));
^
Caused by commit ce567d11e819 ("dm cache: add hints policy") from the
device-mapper tree.
I have just left this broken for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build failure after merge of the final tree (device-mapper tree related)
2013-10-28 14:33 linux-next: build failure after merge of the final tree (device-mapper tree related) Stephen Rothwell
@ 2013-10-28 14:57 ` Mike Snitzer
0 siblings, 0 replies; 7+ messages in thread
From: Mike Snitzer @ 2013-10-28 14:57 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Alasdair G Kergon, linux-next, linux-kernel, Heinz Mauelshagen
On Mon, Oct 28 2013 at 10:33am -0400,
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/md/dm-cache-policy-hints.c: In function 'alloc_hash':
> drivers/md/dm-cache-policy-hints.c:94:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
> hash->table = vzalloc(sizeof(*hash->table) * hash->nr_buckets);
> ^
> drivers/md/dm-cache-policy-hints.c:94:14: warning: assignment makes pointer from integer without a cast [enabled by default]
> hash->table = vzalloc(sizeof(*hash->table) * hash->nr_buckets);
> ^
> drivers/md/dm-cache-policy-hints.c: In function 'free_hash':
> drivers/md/dm-cache-policy-hints.c:101:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(hash->table);
> ^
> drivers/md/dm-cache-policy-hints.c: In function 'alloc_bitset':
> drivers/md/dm-cache-policy-hints.c:184:2: warning: return makes pointer from integer without a cast [enabled by default]
> return vzalloc(sizeof(unsigned long) * bit_set_nr_words(nr_cblocks));
> ^
>
> Caused by commit ce567d11e819 ("dm cache: add hints policy") from the
> device-mapper tree.
>
> I have just left this broken for today.
I just pushed an update to linux-dm.git's 'for-next' branch which adds
3 missing #includes to drivers/md/dm-cache-policy-hints.c
Thanks,
Mike
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: build failure after merge of the final tree (device-mapper tree related)
@ 2013-02-28 2:19 Stephen Rothwell
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2013-02-28 2:19 UTC (permalink / raw)
To: Alasdair G Kergon
Cc: linux-next, linux-kernel, Joe Thornber, Heinz Mauelshagen
[-- Attachment #1: Type: text/plain, Size: 4070 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/md/dm-cache-policy-cleaner.c: In function 'alloc_hash':
drivers/md/dm-cache-policy-cleaner.c:87:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
drivers/md/dm-cache-policy-cleaner.c:87:14: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/md/dm-cache-policy-cleaner.c: In function 'free_hash':
drivers/md/dm-cache-policy-cleaner.c:94:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
drivers/md/dm-cache-policy-cleaner.c: In function 'alloc_cache_blocks_with_hash':
drivers/md/dm-cache-policy-cleaner.c:101:13: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[3]: *** [drivers/md/dm-cache-policy-cleaner.o] Error 1
drivers/md/dm-cache-policy-mq.c: In function 'alloc_bitset':
drivers/md/dm-cache-policy-mq.c:32:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
drivers/md/dm-cache-policy-mq.c:32:2: warning: return makes pointer from integer without a cast [enabled by default]
drivers/md/dm-cache-policy-mq.c: In function 'free_bitset':
drivers/md/dm-cache-policy-mq.c:37:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [drivers/md/dm-cache-policy-mq.o] Error 1
drivers/md/dm-cache-target.c: In function 'alloc_bitset':
drivers/md/dm-cache-target.c:46:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
drivers/md/dm-cache-target.c:46:2: warning: return makes pointer from integer without a cast [enabled by default]
drivers/md/dm-cache-target.c: In function 'free_bitset':
drivers/md/dm-cache-target.c:57:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
Caused by commits d5d224ab22e4 ("Add a target that allows a fast device
such as an SSD to be used as a"), b5dc50616996 ("A cache policy that uses
a multiqueue ordered by recent hit") and 9c44464a0aed ("A simple cache
policy that writes back all data to the origin") from the device-mapper
tree.
I added the following fix patch for today:
From 0fe0a64ba2a600a10725318998c19e0b3820e6d7 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 28 Feb 2013 13:11:49 +1100
Subject: [PATCH] md: use of vmalloc et al needs vmalloc.h
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/md/dm-cache-policy-cleaner.c | 1 +
drivers/md/dm-cache-policy-mq.c | 1 +
drivers/md/dm-cache-target.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/md/dm-cache-policy-cleaner.c b/drivers/md/dm-cache-policy-cleaner.c
index 43c270a..f43896f 100644
--- a/drivers/md/dm-cache-policy-cleaner.c
+++ b/drivers/md/dm-cache-policy-cleaner.c
@@ -12,6 +12,7 @@
#include <linux/hash.h>
#include <linux/module.h>
#include <linux/slab.h>
+#include <linux/vmalloc.h>
/*----------------------------------------------------------------*/
diff --git a/drivers/md/dm-cache-policy-mq.c b/drivers/md/dm-cache-policy-mq.c
index 63ec258..d62d0c1 100644
--- a/drivers/md/dm-cache-policy-mq.c
+++ b/drivers/md/dm-cache-policy-mq.c
@@ -11,6 +11,7 @@
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/slab.h>
+#include <linux/vmalloc.h>
#define DM_MSG_PREFIX "cache-policy-mq"
#define MQ_VERSION "1.0.0"
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index 630f769..1215050 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -14,6 +14,7 @@
#include <linux/mempool.h>
#include <linux/module.h>
#include <linux/slab.h>
+#include <linux/vmalloc.h>
#define DM_MSG_PREFIX "cache"
--
1.8.1
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: linux-next: build failure after merge of the final tree (device-mapper tree related)
2012-06-27 3:02 Stephen Rothwell
@ 2012-06-27 10:11 ` Alasdair G Kergon
0 siblings, 0 replies; 7+ messages in thread
From: Alasdair G Kergon @ 2012-06-27 10:11 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Alasdair G Kergon, linux-next, linux-kernel, Mike Snitzer
On Wed, Jun 27, 2012 at 01:02:21PM +1000, Stephen Rothwell wrote:
> Caused by commit 30ebb0baeef5 ("If CONFIG_DM_DEBUG_SPACE_MAPS is enabled
> and memory is fragmented and a") from the device-mapper tree. Presumably
> a missing include of vmalloc.h.
Hopefully fixed for tomorrow now, thanks.
Alasdair
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: build failure after merge of the final tree (device-mapper tree related)
@ 2012-06-27 3:02 Stephen Rothwell
2012-06-27 10:11 ` Alasdair G Kergon
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2012-06-27 3:02 UTC (permalink / raw)
To: Alasdair G Kergon; +Cc: linux-next, linux-kernel, Mike Snitzer
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/md/persistent-data/dm-space-map-checker.c: In function 'ca_create':
drivers/md/persistent-data/dm-space-map-checker.c:96:3: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
drivers/md/persistent-data/dm-space-map-checker.c:96:14: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/md/persistent-data/dm-space-map-checker.c: In function 'ca_destroy':
drivers/md/persistent-data/dm-space-map-checker.c:106:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
drivers/md/persistent-data/dm-space-map-checker.c: In function 'ca_extend':
drivers/md/persistent-data/dm-space-map-checker.c:139:21: warning: initialization makes pointer from integer without a cast [enabled by default]
Caused by commit 30ebb0baeef5 ("If CONFIG_DM_DEBUG_SPACE_MAPS is enabled
and memory is fragmented and a") from the device-mapper tree. Presumably
a missing include of vmalloc.h.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build failure after merge of the final tree (device-mapper tree related)
2011-07-25 5:58 Stephen Rothwell
@ 2011-07-25 10:57 ` Alasdair G Kergon
0 siblings, 0 replies; 7+ messages in thread
From: Alasdair G Kergon @ 2011-07-25 10:57 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Alasdair G Kergon, linux-next, linux-kernel, Joe Thornber, Mike Snitzer
On Mon, Jul 25, 2011 at 03:58:54PM +1000, Stephen Rothwell wrote:
> Casued by commit 3222df7eca25 ("The persistent-data library offers a
> re-usable framework for the storage").
> I am not quite sure how you should fix this (maybe just include
> linux/bitops.h?) so I have left this build error for today.
Indeed - there were a couple of
#include <asm-generic/bitops/le.h>
hidden in there!
Fixed, thanks.
Alasdair
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: build failure after merge of the final tree (device-mapper tree related)
@ 2011-07-25 5:58 Stephen Rothwell
2011-07-25 10:57 ` Alasdair G Kergon
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2011-07-25 5:58 UTC (permalink / raw)
To: Alasdair G Kergon; +Cc: linux-next, linux-kernel, Joe Thornber, Mike Snitzer
[-- Attachment #1: Type: text/plain, Size: 3210 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
In file included from drivers/md/persistent-data/dm-space-map-disk.c:14:0:
include/asm-generic/bitops/le.h:52:19: error: conflicting types for 'test_bit_le'
arch/powerpc/include/asm/bitops.h:284:23: note: previous definition of 'test_bit_le' was here
include/asm-generic/bitops/le.h:57:20: error: redefinition of '__set_bit_le'
arch/powerpc/include/asm/bitops.h:291:20: note: previous definition of '__set_bit_le' was here
include/asm-generic/bitops/le.h:62:20: error: redefinition of '__clear_bit_le'
arch/powerpc/include/asm/bitops.h:296:20: note: previous definition of '__clear_bit_le' was here
include/asm-generic/bitops/le.h:67:19: error: redefinition of 'test_and_set_bit_le'
arch/powerpc/include/asm/bitops.h:301:19: note: previous definition of 'test_and_set_bit_le' was here
include/asm-generic/bitops/le.h:72:19: error: redefinition of 'test_and_clear_bit_le'
arch/powerpc/include/asm/bitops.h:306:19: note: previous definition of 'test_and_clear_bit_le' was here
include/asm-generic/bitops/le.h:77:19: error: redefinition of '__test_and_set_bit_le'
arch/powerpc/include/asm/bitops.h:311:19: note: previous definition of '__test_and_set_bit_le' was here
include/asm-generic/bitops/le.h:82:19: error: redefinition of '__test_and_clear_bit_le'
arch/powerpc/include/asm/bitops.h:316:19: note: previous definition of '__test_and_clear_bit_le' was here
In file included from drivers/md/persistent-data/dm-space-map-metadata.c:13:0:
include/asm-generic/bitops/le.h:52:19: error: conflicting types for 'test_bit_le'
arch/powerpc/include/asm/bitops.h:284:23: note: previous definition of 'test_bit_le' was here
include/asm-generic/bitops/le.h:57:20: error: redefinition of '__set_bit_le'
arch/powerpc/include/asm/bitops.h:291:20: note: previous definition of '__set_bit_le' was here
include/asm-generic/bitops/le.h:62:20: error: redefinition of '__clear_bit_le'
arch/powerpc/include/asm/bitops.h:296:20: note: previous definition of '__clear_bit_le' was here
include/asm-generic/bitops/le.h:67:19: error: redefinition of 'test_and_set_bit_le'
arch/powerpc/include/asm/bitops.h:301:19: note: previous definition of 'test_and_set_bit_le' was here
include/asm-generic/bitops/le.h:72:19: error: redefinition of 'test_and_clear_bit_le'
arch/powerpc/include/asm/bitops.h:306:19: note: previous definition of 'test_and_clear_bit_le' was here
include/asm-generic/bitops/le.h:77:19: error: redefinition of '__test_and_set_bit_le'
arch/powerpc/include/asm/bitops.h:311:19: note: previous definition of '__test_and_set_bit_le' was here
include/asm-generic/bitops/le.h:82:19: error: redefinition of '__test_and_clear_bit_le'
arch/powerpc/include/asm/bitops.h:316:19: note: previous definition of '__test_and_clear_bit_le' was here
Casued by commit 3222df7eca25 ("The persistent-data library offers a
re-usable framework for the storage").
I am not quite sure how you should fix this (maybe just include
linux/bitops.h?) so I have left this build error for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-10-28 14:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-28 14:33 linux-next: build failure after merge of the final tree (device-mapper tree related) Stephen Rothwell
2013-10-28 14:57 ` Mike Snitzer
-- strict thread matches above, loose matches on Subject: below --
2013-02-28 2:19 Stephen Rothwell
2012-06-27 3:02 Stephen Rothwell
2012-06-27 10:11 ` Alasdair G Kergon
2011-07-25 5:58 Stephen Rothwell
2011-07-25 10:57 ` Alasdair G Kergon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).