* Re: [PATCH] clk: Properly initialize reference count
[not found] <1383220962-26836-1-git-send-email-treding@nvidia.com>
@ 2013-10-31 19:09 ` Stephen Warren
2013-11-01 9:23 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Warren @ 2013-10-31 19:09 UTC (permalink / raw)
To: Thierry Reding, Mike Turquette
Cc: linux-arm-kernel, Sylwester Nawrocki, linux-next
On 10/31/2013 06:02 AM, Thierry Reding wrote:
> Commit a336ed7 (clk: Implement clk_unregister()) initializes the kref in
> clk_set_parent(), which is obviously the wrong place. Further research
> shows that the original patches initialized it correctly, so it probably
> ended up in clk_set_parent() by mistake during manual application of the
> patch.
Tested-by: Stephen Warren <swarren@nvidia.com>
BTW, it'd be nice to Cc fixes like this to linux-next@vger.kernel.org; I
/might/ have avoided doing a bisect if I'd seen this patch first!
I see the benefit of that "linux-next plus today's accumulated
bug-fixes" tree that I think you proposed:-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: Properly initialize reference count
2013-10-31 19:09 ` [PATCH] clk: Properly initialize reference count Stephen Warren
@ 2013-11-01 9:23 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2013-11-01 9:23 UTC (permalink / raw)
To: Stephen Warren
Cc: Mike Turquette, linux-arm-kernel, Sylwester Nawrocki, linux-next
[-- Attachment #1: Type: text/plain, Size: 1877 bytes --]
On Thu, Oct 31, 2013 at 01:09:11PM -0600, Stephen Warren wrote:
> On 10/31/2013 06:02 AM, Thierry Reding wrote:
> > Commit a336ed7 (clk: Implement clk_unregister()) initializes the kref in
> > clk_set_parent(), which is obviously the wrong place. Further research
> > shows that the original patches initialized it correctly, so it probably
> > ended up in clk_set_parent() by mistake during manual application of the
> > patch.
>
> Tested-by: Stephen Warren <swarren@nvidia.com>
>
> BTW, it'd be nice to Cc fixes like this to linux-next@vger.kernel.org;
Yes, perhaps that would've been a good idea.
> I /might/ have avoided doing a bisect if I'd seen this patch first!
I get that bisect is a really nice tool. But I don't understand why
people seem to rely on it to track down *everything* nowadays. In this
particular case there was a fairly obvious warning that pretty clearly
pointed at something wrong with the reference counting and some simple
code inspection revealed the issue at hand. No need to rebuild and boot
the kernel dozens of times to find this out.
But perhaps other people have much faster machines and bisection is
actually faster...
> I see the benefit of that "linux-next plus today's accumulated
> bug-fixes" tree that I think you proposed:-)
Yeah, this is precisely the situation where this would be good to have.
Both of these issues together took about 45-60 minutes to track down and
fix. I suppose it took Olof and you a similar amount of time. Yet if the
fixes were already collected in some standard location it would free you
up to do something more productive instead of wasting your time on
duplicate work.
I'll ask Stephen (Rothwell) if he'd be willing to set up shared access
to linux-next so that I can push collected fixes. Alternatively I could
do that in a separate repository.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-01 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1383220962-26836-1-git-send-email-treding@nvidia.com>
2013-10-31 19:09 ` [PATCH] clk: Properly initialize reference count Stephen Warren
2013-11-01 9:23 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).