* linux-next: build failure after merge of the final tree (cgroup tree related)
@ 2014-02-12 5:25 Stephen Rothwell
2014-02-12 6:39 ` Tejun Heo
2014-02-12 21:15 ` Tejun Heo
0 siblings, 2 replies; 12+ messages in thread
From: Stephen Rothwell @ 2014-02-12 5:25 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-next, linux-kernel, David S. Miller, Sam Ravnborg
[-- Attachment #1: Type: text/plain, Size: 1654 bytes --]
Hi all,
After merging the final tree, today's linux-next build (sparc defconfig)
failed like this:
arch/sparc/kernel/sun4m_irq.c: In function 'sun4m_build_device_irq':
arch/sparc/kernel/sun4m_irq.c:266:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
arch/sparc/kernel/sun4m_irq.c:266:15: error: assignment makes pointer from integer without a cast [-Werror]
Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
(see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
missing slab.h includes")). I wonder how mane more builds are broken by
this :-(
Indeed, reverting that commit fixes the build.
I have added the following build fix for today (please check the
overnight builds for more breakage):
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 12 Feb 2014 16:01:10 +1100
Subject: [PATCH] sun4M: add include of slab.h for kzalloc
This was being included implicitly via cgroup.h's inclusion of xattr.h
(which has now been removed).
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/sparc/kernel/sun4m_irq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sparc/kernel/sun4m_irq.c b/arch/sparc/kernel/sun4m_irq.c
index c5ade9d27a1d..8bb3b3fddea7 100644
--- a/arch/sparc/kernel/sun4m_irq.c
+++ b/arch/sparc/kernel/sun4m_irq.c
@@ -9,6 +9,8 @@
* Copyright (C) 1996 Dave Redman (djhr@tadpole.co.uk)
*/
+#include <linux/slab.h>
+
#include <asm/timer.h>
#include <asm/traps.h>
#include <asm/pgalloc.h>
--
1.9.rc1
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: linux-next: build failure after merge of the final tree (cgroup tree related)
2014-02-12 5:25 linux-next: build failure after merge of the final tree (cgroup tree related) Stephen Rothwell
@ 2014-02-12 6:39 ` Tejun Heo
2014-02-12 10:47 ` Stephen Rothwell
2014-02-12 21:15 ` Tejun Heo
1 sibling, 1 reply; 12+ messages in thread
From: Tejun Heo @ 2014-02-12 6:39 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, David S. Miller, Sam Ravnborg
Hello,
On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> missing slab.h includes")). I wonder how mane more builds are broken by
> this :-(
Dang, I was feeling pretty safe as kbuild bot was reporting build
successes. We better fix them at any rate. David / Sam, can you
please pick this one up?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build failure after merge of the final tree (cgroup tree related)
2014-02-12 6:39 ` Tejun Heo
@ 2014-02-12 10:47 ` Stephen Rothwell
2014-02-12 14:27 ` Tejun Heo
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2014-02-12 10:47 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-next, linux-kernel, David S. Miller, Sam Ravnborg
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
Hi, Tejun,
On Wed, 12 Feb 2014 01:39:33 -0500 Tejun Heo <tj@kernel.org> wrote:
>
> On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> > Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> > (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> > missing slab.h includes")). I wonder how mane more builds are broken by
> > this :-(
>
> Dang, I was feeling pretty safe as kbuild bot was reporting build
> successes. We better fix them at any rate. David / Sam, can you
> please pick this one up?
It really needs to go into the tree with the cgroup commit so it doesn't
break there.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build failure after merge of the final tree (cgroup tree related)
2014-02-12 10:47 ` Stephen Rothwell
@ 2014-02-12 14:27 ` Tejun Heo
2014-02-12 20:36 ` Sam Ravnborg
0 siblings, 1 reply; 12+ messages in thread
From: Tejun Heo @ 2014-02-12 14:27 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, David S. Miller, Sam Ravnborg
On Wed, Feb 12, 2014 at 09:47:43PM +1100, Stephen Rothwell wrote:
> Hi, Tejun,
>
> On Wed, 12 Feb 2014 01:39:33 -0500 Tejun Heo <tj@kernel.org> wrote:
> >
> > On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> > > Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> > > (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> > > missing slab.h includes")). I wonder how mane more builds are broken by
> > > this :-(
> >
> > Dang, I was feeling pretty safe as kbuild bot was reporting build
> > successes. We better fix them at any rate. David / Sam, can you
> > please pick this one up?
>
> It really needs to go into the tree with the cgroup commit so it doesn't
> break there.
Hmmm... I see. I'll route the patch once Dave or Sam acks it.
Thanks!
--
tejun
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build failure after merge of the final tree (cgroup tree related)
2014-02-12 14:27 ` Tejun Heo
@ 2014-02-12 20:36 ` Sam Ravnborg
0 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2014-02-12 20:36 UTC (permalink / raw)
To: Tejun Heo; +Cc: Stephen Rothwell, linux-next, linux-kernel, David S. Miller
Hi Tejun.
On Wed, Feb 12, 2014 at 09:27:00AM -0500, Tejun Heo wrote:
> On Wed, Feb 12, 2014 at 09:47:43PM +1100, Stephen Rothwell wrote:
> > Hi, Tejun,
> >
> > On Wed, 12 Feb 2014 01:39:33 -0500 Tejun Heo <tj@kernel.org> wrote:
> > >
> > > On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> > > > Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> > > > (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> > > > missing slab.h includes")). I wonder how mane more builds are broken by
> > > > this :-(
> > >
> > > Dang, I was feeling pretty safe as kbuild bot was reporting build
> > > successes. We better fix them at any rate. David / Sam, can you
> > > please pick this one up?
> >
> > It really needs to go into the tree with the cgroup commit so it doesn't
> > break there.
>
> Hmmm... I see. I'll route the patch once Dave or Sam acks it.
My sparc setup is broken for many reasons - so I have not been able to try it out.
But the patch is obvious enough that I do not hesitate to do:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build failure after merge of the final tree (cgroup tree related)
2014-02-12 5:25 linux-next: build failure after merge of the final tree (cgroup tree related) Stephen Rothwell
2014-02-12 6:39 ` Tejun Heo
@ 2014-02-12 21:15 ` Tejun Heo
1 sibling, 0 replies; 12+ messages in thread
From: Tejun Heo @ 2014-02-12 21:15 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, David S. Miller, Sam Ravnborg
On Wed, Feb 12, 2014 at 04:25:00PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (sparc defconfig)
> failed like this:
>
> arch/sparc/kernel/sun4m_irq.c: In function 'sun4m_build_device_irq':
> arch/sparc/kernel/sun4m_irq.c:266:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
> arch/sparc/kernel/sun4m_irq.c:266:15: error: assignment makes pointer from integer without a cast [-Werror]
>
> Presumably caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs")
> (see the comment in commit 1ff6bbfd13ca ("arm, pm, vmpressure: add
> missing slab.h includes")). I wonder how mane more builds are broken by
> this :-(
>
> Indeed, reverting that commit fixes the build.
>
> I have added the following build fix for today (please check the
> overnight builds for more breakage):
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 12 Feb 2014 16:01:10 +1100
> Subject: [PATCH] sun4M: add include of slab.h for kzalloc
>
> This was being included implicitly via cgroup.h's inclusion of xattr.h
> (which has now been removed).
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Applied to cgroup/for-3.15.
Thanks!
--
tejun
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build failure after merge of the final tree (cgroup tree related)
2013-03-20 22:09 ` Stephen Rothwell
@ 2013-03-20 22:11 ` Tejun Heo
0 siblings, 0 replies; 12+ messages in thread
From: Tejun Heo @ 2013-03-20 22:11 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Li Zefan, linux-next, linux-kernel
On Wed, Mar 20, 2013 at 3:09 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> There has been no change to the cgroup tree
> (git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git#for-next).
> Forgot to push?
Yeah, I'm on a roll today. My apologies. Just pushed out.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build failure after merge of the final tree (cgroup tree related)
2013-03-20 14:51 ` Tejun Heo
@ 2013-03-20 22:09 ` Stephen Rothwell
2013-03-20 22:11 ` Tejun Heo
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2013-03-20 22:09 UTC (permalink / raw)
To: Tejun Heo; +Cc: Li Zefan, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
Hi Tejun,
On Wed, 20 Mar 2013 07:51:35 -0700 Tejun Heo <tj@kernel.org> wrote:
>
> On Wed, Mar 20, 2013 at 03:43:28PM +1100, Stephen Rothwell wrote:
> > It has returned today. Please be more careful.
> >
> > In file included from include/linux/memcontrol.h:22:0,
> > from include/linux/swap.h:8,
> > from include/linux/suspend.h:4,
> > from arch/powerpc/kernel/asm-offsets.c:24:
> > include/linux/cgroup.h:742:13: warning: 'struct cgroupstats' declared inside parameter list [enabled by default]
> > include/linux/cgroup.h:742:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> >
> > I have reverted commit c2c9ad164fa3 ("cgroup: remove unneeded includes
> > from cgroup.h") for today.
>
> Oops, my bad. I mistakenly reverted the original commit from
> for-next, not for-3.10 and got confused after applying more patches on
> top. Fixed up now.
There has been no change to the cgroup tree
(git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git#for-next).
Forgot to push?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build failure after merge of the final tree (cgroup tree related)
2013-03-20 4:43 ` Stephen Rothwell
@ 2013-03-20 14:51 ` Tejun Heo
2013-03-20 22:09 ` Stephen Rothwell
0 siblings, 1 reply; 12+ messages in thread
From: Tejun Heo @ 2013-03-20 14:51 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Li Zefan, linux-next, linux-kernel
On Wed, Mar 20, 2013 at 03:43:28PM +1100, Stephen Rothwell wrote:
> It has returned today. Please be more careful.
>
> In file included from include/linux/memcontrol.h:22:0,
> from include/linux/swap.h:8,
> from include/linux/suspend.h:4,
> from arch/powerpc/kernel/asm-offsets.c:24:
> include/linux/cgroup.h:742:13: warning: 'struct cgroupstats' declared inside parameter list [enabled by default]
> include/linux/cgroup.h:742:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>
> I have reverted commit c2c9ad164fa3 ("cgroup: remove unneeded includes
> from cgroup.h") for today.
Oops, my bad. I mistakenly reverted the original commit from
for-next, not for-3.10 and got confused after applying more patches on
top. Fixed up now.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build failure after merge of the final tree (cgroup tree related)
2013-03-13 6:33 ` Li Zefan
@ 2013-03-20 4:43 ` Stephen Rothwell
2013-03-20 14:51 ` Tejun Heo
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2013-03-20 4:43 UTC (permalink / raw)
To: Tejun Heo; +Cc: Li Zefan, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]
Hi all,
On Wed, 13 Mar 2013 14:33:15 +0800 Li Zefan <lizefan@huawei.com> wrote:
>
> On 2013/3/13 13:12, Stephen Rothwell wrote:
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allnoconfig) failed like this:
> >
> > In file included from include/linux/memcontrol.h:22:0,
> > from include/linux/swap.h:8,
> > from include/linux/suspend.h:4,
> > from arch/powerpc/kernel/asm-offsets.c:24:
> > include/linux/cgroup.h:748:13: warning: 'struct cgroupstats' declared inside parameter list [enabled by default]
> > include/linux/cgroup.h:748:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> > cc1: all warnings being treated as errors
> >
> > and many more similar.
> >
> > Caused by commit c2c9ad164fa3 ("cgroup: remove unneeded includes from
> > cgroup.h").
> >
>
> Tejun has dropped this patch.
It has returned today. Please be more careful.
In file included from include/linux/memcontrol.h:22:0,
from include/linux/swap.h:8,
from include/linux/suspend.h:4,
from arch/powerpc/kernel/asm-offsets.c:24:
include/linux/cgroup.h:742:13: warning: 'struct cgroupstats' declared inside parameter list [enabled by default]
include/linux/cgroup.h:742:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
I have reverted commit c2c9ad164fa3 ("cgroup: remove unneeded includes
from cgroup.h") for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build failure after merge of the final tree (cgroup tree related)
2013-03-13 5:12 Stephen Rothwell
@ 2013-03-13 6:33 ` Li Zefan
2013-03-20 4:43 ` Stephen Rothwell
0 siblings, 1 reply; 12+ messages in thread
From: Li Zefan @ 2013-03-13 6:33 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Tejun Heo, linux-next, linux-kernel
On 2013/3/13 13:12, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
>
> In file included from include/linux/memcontrol.h:22:0,
> from include/linux/swap.h:8,
> from include/linux/suspend.h:4,
> from arch/powerpc/kernel/asm-offsets.c:24:
> include/linux/cgroup.h:748:13: warning: 'struct cgroupstats' declared inside parameter list [enabled by default]
> include/linux/cgroup.h:748:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> cc1: all warnings being treated as errors
>
> and many more similar.
>
> Caused by commit c2c9ad164fa3 ("cgroup: remove unneeded includes from
> cgroup.h").
>
Tejun has dropped this patch.
^ permalink raw reply [flat|nested] 12+ messages in thread
* linux-next: build failure after merge of the final tree (cgroup tree related)
@ 2013-03-13 5:12 Stephen Rothwell
2013-03-13 6:33 ` Li Zefan
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2013-03-13 5:12 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-next, linux-kernel, Li Zefan
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:
In file included from include/linux/memcontrol.h:22:0,
from include/linux/swap.h:8,
from include/linux/suspend.h:4,
from arch/powerpc/kernel/asm-offsets.c:24:
include/linux/cgroup.h:748:13: warning: 'struct cgroupstats' declared inside parameter list [enabled by default]
include/linux/cgroup.h:748:13: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
cc1: all warnings being treated as errors
and many more similar.
Caused by commit c2c9ad164fa3 ("cgroup: remove unneeded includes from
cgroup.h").
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-02-12 21:15 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-12 5:25 linux-next: build failure after merge of the final tree (cgroup tree related) Stephen Rothwell
2014-02-12 6:39 ` Tejun Heo
2014-02-12 10:47 ` Stephen Rothwell
2014-02-12 14:27 ` Tejun Heo
2014-02-12 20:36 ` Sam Ravnborg
2014-02-12 21:15 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2013-03-13 5:12 Stephen Rothwell
2013-03-13 6:33 ` Li Zefan
2013-03-20 4:43 ` Stephen Rothwell
2013-03-20 14:51 ` Tejun Heo
2013-03-20 22:09 ` Stephen Rothwell
2013-03-20 22:11 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).