* [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c
@ 2014-02-13 15:59 Paul Gortmaker
2014-02-13 20:42 ` Tejun Heo
2014-02-13 21:18 ` Tejun Heo
0 siblings, 2 replies; 4+ messages in thread
From: Paul Gortmaker @ 2014-02-13 15:59 UTC (permalink / raw)
To: sparclinux
Cc: David S. Miller, linux-kernel, linux-next, Paul Gortmaker,
Stephen Rothwell, Tejun Heo
To fix:
arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':
arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]
arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
According to Stephen, these types of failures are caused by
commit 2bd59d48ebfb ("cgroup: convert to kernfs") which was
being included implicitly via cgroup.h's inclusion of xattr.h
(which has now been removed).
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
arch/sparc/kernel/leon_pci_grpci2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sparc/kernel/leon_pci_grpci2.c b/arch/sparc/kernel/leon_pci_grpci2.c
index 5f0402aab7fb..24d6a4446349 100644
--- a/arch/sparc/kernel/leon_pci_grpci2.c
+++ b/arch/sparc/kernel/leon_pci_grpci2.c
@@ -8,6 +8,7 @@
#include <linux/of_device.h>
#include <linux/kernel.h>
#include <linux/pci.h>
+#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/export.h>
#include <asm/io.h>
--
1.8.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c
2014-02-13 15:59 [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c Paul Gortmaker
@ 2014-02-13 20:42 ` Tejun Heo
2014-02-13 21:01 ` David Miller
2014-02-13 21:18 ` Tejun Heo
1 sibling, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2014-02-13 20:42 UTC (permalink / raw)
To: Paul Gortmaker
Cc: sparclinux, David S. Miller, linux-kernel, linux-next, Stephen Rothwell
On Thu, Feb 13, 2014 at 10:59:18AM -0500, Paul Gortmaker wrote:
> To fix:
>
> arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':
> arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
> arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]
> arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
> cc1: all warnings being treated as errors
> make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
>
> According to Stephen, these types of failures are caused by
> commit 2bd59d48ebfb ("cgroup: convert to kernfs") which was
> being included implicitly via cgroup.h's inclusion of xattr.h
> (which has now been removed).
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Darn, another one. David, can you please ack this one? I'll push it
through cgroup/for-3.15 so that -next doesn't break.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c
2014-02-13 20:42 ` Tejun Heo
@ 2014-02-13 21:01 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2014-02-13 21:01 UTC (permalink / raw)
To: tj; +Cc: paul.gortmaker, sparclinux, linux-kernel, linux-next, sfr
From: Tejun Heo <tj@kernel.org>
Date: Thu, 13 Feb 2014 15:42:17 -0500
> On Thu, Feb 13, 2014 at 10:59:18AM -0500, Paul Gortmaker wrote:
>> To fix:
>>
>> arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':
>> arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
>> arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]
>> arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
>> cc1: all warnings being treated as errors
>> make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
>>
>> According to Stephen, these types of failures are caused by
>> commit 2bd59d48ebfb ("cgroup: convert to kernfs") which was
>> being included implicitly via cgroup.h's inclusion of xattr.h
>> (which has now been removed).
>>
>> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
>> Cc: Tejun Heo <tj@kernel.org>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Darn, another one. David, can you please ack this one? I'll push it
> through cgroup/for-3.15 so that -next doesn't break.
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c
2014-02-13 15:59 [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c Paul Gortmaker
2014-02-13 20:42 ` Tejun Heo
@ 2014-02-13 21:18 ` Tejun Heo
1 sibling, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2014-02-13 21:18 UTC (permalink / raw)
To: Paul Gortmaker
Cc: sparclinux, David S. Miller, linux-kernel, linux-next, Stephen Rothwell
On Thu, Feb 13, 2014 at 10:59:18AM -0500, Paul Gortmaker wrote:
> To fix:
>
> arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':
> arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
> arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]
> arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
> cc1: all warnings being treated as errors
> make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
>
> According to Stephen, these types of failures are caused by
> commit 2bd59d48ebfb ("cgroup: convert to kernfs") which was
> being included implicitly via cgroup.h's inclusion of xattr.h
> (which has now been removed).
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied to cgroup/for-3.15.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-13 21:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-13 15:59 [PATCH] sparc: fix implicit include of slab.h in leon_pci_grpci2.c Paul Gortmaker
2014-02-13 20:42 ` Tejun Heo
2014-02-13 21:01 ` David Miller
2014-02-13 21:18 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).