linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
Date: Wed, 26 Feb 2014 02:02:34 -0800	[thread overview]
Message-ID: <20140226100234.GA23064@thin> (raw)
In-Reply-To: <20140226191627.9adf3c8e1548e2016c16557c@canb.auug.org.au>

On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc64
> allnoconfig) failed like this:
> 
> arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
> (.text+0x11260): undefined reference to `.irq_work_queue'
> 
> Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
> ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> from the apm-current tree.

Pre-existing, just now triggerable with just "make allnoconfig" rather
than manually turning off other options (like PRINTK) that select
IRQ_WORK.  (One of the goals of that commit: get those options more
widely used and build-tested.)

The following (untested) patch *should* fix this:
----- 8< -----
>From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
From: Josh Triplett <josh@joshtriplett.org>
Date: Wed, 26 Feb 2014 01:58:02 -0800
Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK

arch/powerpc/kernel/mce.c, compiled in for PPC_BOOK3S_64, calls
functions only built when IRQ_WORK, so select it.  Fixes the following
build error:

arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
 arch/powerpc/platforms/Kconfig.cputype | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
index 434fda3..d9e2b19 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -73,6 +73,7 @@ config PPC_BOOK3S_64
 	select SYS_SUPPORTS_HUGETLBFS
 	select HAVE_ARCH_TRANSPARENT_HUGEPAGE if PPC_64K_PAGES
 	select ARCH_SUPPORTS_NUMA_BALANCING
+	select IRQ_WORK
 
 config PPC_BOOK3E_64
 	bool "Embedded processors"
-- 
1.9.0

  reply	other threads:[~2014-02-26 10:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26  8:16 linux-next: build failure after merge of the final tree (akpm-current tree related) Stephen Rothwell
2014-02-26 10:02 ` Josh Triplett [this message]
2014-02-26 23:00   ` Stephen Rothwell
2014-02-26 23:17     ` Andrew Morton
2014-02-26 23:19     ` Josh Triplett
2014-02-26 23:42       ` Stephen Rothwell
2014-02-27  2:13         ` [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver Josh Triplett
2014-02-27  2:43           ` Stephen Rothwell
2014-02-27  7:07           ` Heiko Carstens
2014-02-28  1:27         ` [PATCH] cris: Make ETRAX_ARCH_V10 select TTY for use in debugport Josh Triplett
2014-02-28  2:30           ` Stephen Rothwell
2014-02-27  2:21     ` linux-next: build failure after merge of the final tree (akpm-current tree related) Josh Triplett
2014-02-27  2:40       ` Stephen Rothwell
2014-02-28  1:29         ` Josh Triplett
  -- strict thread matches above, loose matches on Subject: below --
2013-12-17  5:43 Stephen Rothwell
2013-08-16  7:16 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140226100234.GA23064@thin \
    --to=josh@joshtriplett.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).