[PATCH] staging: comedi: declare das6402_boards as static

[PATCH] staging: comedi: declare das6402_boards as static

[Michele Curti]

Hi,
das6402_boards array seems to be used in das6402.c only, so declare it 
as static.

This patch applies to linux-next next-20140410.

Regards,
Michele

Signed-off-by: Michele Curti <michele.curti@gmail.com>
---
 drivers/staging/comedi/drivers/das6402.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/das6402.c b/drivers/staging/comedi/drivers/das6402.c
index e0cfb6c..d18eea6 100644
--- a/drivers/staging/comedi/drivers/das6402.c
+++ b/drivers/staging/comedi/drivers/das6402.c
@@ -125,7 +125,7 @@ struct das6402_boardinfo {
 	unsigned int maxdata;
 };
 
-struct das6402_boardinfo das6402_boards[] = {
+static struct das6402_boardinfo das6402_boards[] = {
 	{
 		.name		= "das6402-12",
 		.maxdata	= 0x0fff,
-- 
1.9.1

Re: [PATCH] staging: comedi: declare das6402_boards as static

[Dan Carpenter]

On Thu, Apr 10, 2014 at 03:54:47PM +0200, Michele Curti wrote:
> Hi,
> das6402_boards array seems to be used in das6402.c only, so declare it 
> as static.
> 
> This patch applies to linux-next next-20140410.
> 
> Regards,
> Michele
> 

The patch is fine, but you have too much fluff in the changelog.  We
just apply patches automatically by saving the raw email as text
(including headers and everything) the we do a
`cat raw_email.txt | git am`.

Your changelog is all "Hello, how are you?  blah blah blah.  Best
wishes, etc.".  It should just say:

das6402_boards array is used in das6402.c only, so declare it as static.

Signed-off-by ...

You can put the "This patch applies to linux-next next-20140410" under
the --- cut off line so that we're aware but it doesn't get saved in the
log.  For staging it doesn't really matter, because either the patch
applies to linux-next or we'll ask you to redo it.

Please send a v2 with a terser changelog.

regards,
dan carpenter

[PATCH v2] staging: comedi: declare das6402_boards as static

[Michele Curti]

das6402_boards array is used in das6402.c only, so declare it as static.

Signed-off-by: Michele Curti <michele.curti@gmail.com>
---
 drivers/staging/comedi/drivers/das6402.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/das6402.c b/drivers/staging/comedi/drivers/das6402.c
index e0cfb6c..d18eea6 100644
--- a/drivers/staging/comedi/drivers/das6402.c
+++ b/drivers/staging/comedi/drivers/das6402.c
@@ -125,7 +125,7 @@ struct das6402_boardinfo {
 	unsigned int maxdata;
 };
 
-struct das6402_boardinfo das6402_boards[] = {
+static struct das6402_boardinfo das6402_boards[] = {
 	{
 		.name		= "das6402-12",
 		.maxdata	= 0x0fff,
-- 
1.9.1

Re: [PATCH v2] staging: comedi: declare das6402_boards as static

[Dan Carpenter]

On Thu, Apr 10, 2014 at 04:38:00PM +0200, Michele Curti wrote:
> 
> das6402_boards array is used in das6402.c only, so declare it as static.
> 
> Signed-off-by: Michele Curti <michele.curti@gmail.com>

Looks good.

regards,
dan carpenter

Re: [PATCH v2] staging: comedi: declare das6402_boards as static

[Ian Abbott]

On 2014-04-10 15:38, Michele Curti wrote:
>
> das6402_boards array is used in das6402.c only, so declare it as static.
>
> Signed-off-by: Michele Curti <michele.curti@gmail.com>

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-