[PATCH -next] net: fix test_bpf build to depend on NET

[PATCH -next] net: fix test_bpf build to depend on NET

[Randy Dunlap]

From: Randy Dunlap <rdunlap@infradead.org>

Fix build when CONFIG_NET is not enabled.
Fixes these build errors:

WARNING: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
WARNING: "kfree_skb" [lib/test_bpf.ko] undefined!
WARNING: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
WARNING: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
WARNING: "__alloc_skb" [lib/test_bpf.ko] undefined!

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 lib/Kconfig.debug |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20140513.orig/lib/Kconfig.debug
+++ linux-next-20140513/lib/Kconfig.debug
@@ -1639,7 +1639,7 @@ config TEST_USER_COPY
 config TEST_BPF
 	tristate "Test BPF filter functionality"
 	default n
-	depends on m
+	depends on m && NET
 	help
 	  This builds the "test_bpf" module that runs various test vectors
 	  against the BPF interpreter or BPF JIT compiler depending on the

Re: [PATCH -next] net: fix test_bpf build to depend on NET

[Alexei Starovoitov]

On Tue, May 13, 2014 at 9:58 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build when CONFIG_NET is not enabled.
> Fixes these build errors:
>
> WARNING: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
> WARNING: "kfree_skb" [lib/test_bpf.ko] undefined!
> WARNING: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
> WARNING: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
> WARNING: "__alloc_skb" [lib/test_bpf.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

ohh. yes. sorry about that.

Acked-by: Alexei Starovoitov <ast@plumgrid.com>

> ---
>  lib/Kconfig.debug |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20140513.orig/lib/Kconfig.debug
> +++ linux-next-20140513/lib/Kconfig.debug
> @@ -1639,7 +1639,7 @@ config TEST_USER_COPY
>  config TEST_BPF
>         tristate "Test BPF filter functionality"
>         default n
> -       depends on m
> +       depends on m && NET
>         help
>           This builds the "test_bpf" module that runs various test vectors
>           against the BPF interpreter or BPF JIT compiler depending on the
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] net: fix test_bpf build to depend on NET

[David Miller]

From: Randy Dunlap <rdunlap@infradead.org>
Date: Tue, 13 May 2014 09:58:44 -0700

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build when CONFIG_NET is not enabled.
> Fixes these build errors:
> 
> WARNING: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
> WARNING: "kfree_skb" [lib/test_bpf.ko] undefined!
> WARNING: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
> WARNING: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
> WARNING: "__alloc_skb" [lib/test_bpf.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Applied, thanks Randy.