* [Consult] About only one Signed-of-by for the patches
@ 2014-05-27 1:23 Chen Gang
2014-05-27 1:34 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Chen Gang @ 2014-05-27 1:23 UTC (permalink / raw)
To: Guan Xuetao, sfr, linux-next
Hello Maintainers:
I find some of patches are only Signed-of-by me, are they OK?
e.g:
commit d7de15786d1a10fa18b80fd44026d442e7a84bd2
Author: Chen Gang <gang.chen.5i5j@gmail.com>
Date: Tue Apr 15 09:21:30 2014 +0800
arch:unicore32:mm: add devmem_is_allowed() to support STRICT_DEVMEM
unicore32 supports STRICT_DEVMEM, so it needs devmem_is_allowed(), like
some of other architectures have done (e.g. arm, powerpc, x86 ...).
The related error with allmodconfig:
CC drivers/char/mem.o
drivers/char/mem.c: In function â<U+0080><U+0098>range_is_allowedâ<U+0080><U+0099>:
drivers/char/mem.c:69: error: implicit declaration of function â<U+0080><U+0098>devmem_is_allowedâ<U+0080><U+0099>
make[2]: *** [drivers/char/mem.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Consult] About only one Signed-of-by for the patches
2014-05-27 1:23 [Consult] About only one Signed-of-by for the patches Chen Gang
@ 2014-05-27 1:34 ` Stephen Rothwell
2014-05-27 1:50 ` Chen Gang
2014-05-27 5:07 ` 回复： " Xuetao Guan
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2014-05-27 1:34 UTC (permalink / raw)
To: Chen Gang; +Cc: Guan Xuetao, linux-next
[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]
Hi Chen,
On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <gang.chen.5i5j@gmail.com> wrote:
>
> I find some of patches are only Signed-of-by me, are they OK?
Actually, this one is not OK. Anyone who handles a patch needs to add a
Signed-off-by. In the case below, that patch was commited to the tree
by Guan Xuetao <gxt@mprc.pku.edu.cn>, so there needs to be a
Signed-off-by from them as well.
The same is true for all the commits in the unicore32 tree ...
> commit d7de15786d1a10fa18b80fd44026d442e7a84bd2
> Author: Chen Gang <gang.chen.5i5j@gmail.com>
> Date: Tue Apr 15 09:21:30 2014 +0800
>
> arch:unicore32:mm: add devmem_is_allowed() to support STRICT_DEVMEM
>
> unicore32 supports STRICT_DEVMEM, so it needs devmem_is_allowed(), like
> some of other architectures have done (e.g. arm, powerpc, x86 ...).
>
> The related error with allmodconfig:
>
> CC drivers/char/mem.o
> drivers/char/mem.c: In function â<U+0080><U+0098>range_is_allowedâ<U+0080><U+0099>:
> drivers/char/mem.c:69: error: implicit declaration of function â<U+0080><U+0098>devmem_is_allowedâ<U+0080><U+0099>
> make[2]: *** [drivers/char/mem.o] Error 1
> make[1]: *** [drivers/char] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Consult] About only one Signed-of-by for the patches
2014-05-27 1:34 ` Stephen Rothwell
@ 2014-05-27 1:50 ` Chen Gang
2014-05-27 5:07 ` 回复： " Xuetao Guan
1 sibling, 0 replies; 6+ messages in thread
From: Chen Gang @ 2014-05-27 1:50 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Guan Xuetao, linux-next
On 05/27/2014 09:34 AM, Stephen Rothwell wrote:
> Hi Chen,
>
> On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <gang.chen.5i5j@gmail.com> wrote:
>>
>> I find some of patches are only Signed-of-by me, are they OK?
>
> Actually, this one is not OK. Anyone who handles a patch needs to add a
> Signed-off-by. In the case below, that patch was commited to the tree
> by Guan Xuetao <gxt@mprc.pku.edu.cn>, so there needs to be a
> Signed-off-by from them as well.
>
> The same is true for all the commits in the unicore32 tree ...
>
OK, thanks.
Hello Guan Xuetao:
Please help process them, when you have time.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 6+ messages in thread
* 回复： Re: [Consult] About only one Signed-of-by for the patches
2014-05-27 1:34 ` Stephen Rothwell
2014-05-27 1:50 ` Chen Gang
@ 2014-05-27 5:07 ` Xuetao Guan
2014-05-27 22:43 ` Stephen Rothwell
1 sibling, 1 reply; 6+ messages in thread
From: Xuetao Guan @ 2014-05-27 5:07 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Chen Gang, Guan Xuetao, linux-next
----- Stephen Rothwell <sfr@canb.auug.org.au> 写道：
> Hi Chen,
>
> On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> >
> > I find some of patches are only Signed-of-by me, are they OK?
>
> Actually, this one is not OK. Anyone who handles a patch needs to add a
> Signed-off-by. In the case below, that patch was commited to the tree
> by Guan Xuetao <gxt@mprc.pku.edu.cn>, so there needs to be a
> Signed-off-by from them as well.
>
> The same is true for all the commits in the unicore32 tree ...
Ok, I see.
Then, do I need to reply each mail with my sob? Or only replace acked-by by sob for all commits in my tree?
Xuetao
>
> > commit d7de15786d1a10fa18b80fd44026d442e7a84bd2
> > Author: Chen Gang <gang.chen.5i5j@gmail.com>
> > Date: Tue Apr 15 09:21:30 2014 +0800
> >
> > arch:unicore32:mm: add devmem_is_allowed() to support STRICT_DEVMEM
> >
> > unicore32 supports STRICT_DEVMEM, so it needs devmem_is_allowed(), like
> > some of other architectures have done (e.g. arm, powerpc, x86 ...).
> >
> > The related error with allmodconfig:
> >
> > CC drivers/char/mem.o
> > drivers/char/mem.c: In function â<U+0080><U+0098>range_is_allowedâ<U+0080><U+0099>:
> > drivers/char/mem.c:69: error: implicit declaration of function â<U+0080><U+0098>devmem_is_allowedâ<U+0080><U+0099>
> > make[2]: *** [drivers/char/mem.o] Error 1
> > make[1]: *** [drivers/char] Error 2
> > make: *** [drivers] Error 2
> >
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> > Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 回复： Re: [Consult] About only one Signed-of-by for the patches
2014-05-27 5:07 ` 回复： " Xuetao Guan
@ 2014-05-27 22:43 ` Stephen Rothwell
2014-05-28 0:00 ` 回复： " Xuetao Guan
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2014-05-27 22:43 UTC (permalink / raw)
To: Xuetao Guan; +Cc: Chen Gang, Guan Xuetao, linux-next
[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]
Hi,
On Tue, 27 May 2014 13:07:30 +0800 (CST) Xuetao Guan <gxt@pku.edu.cn> wrote:
>
>
> ----- Stephen Rothwell <sfr@canb.auug.org.au> 写道：
> > Hi Chen,
> >
> > On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> > >
> > > I find some of patches are only Signed-of-by me, are they OK?
> >
> > Actually, this one is not OK. Anyone who handles a patch needs to add a
> > Signed-off-by. In the case below, that patch was commited to the tree
> > by Guan Xuetao <gxt@mprc.pku.edu.cn>, so there needs to be a
> > Signed-off-by from them as well.
> >
> > The same is true for all the commits in the unicore32 tree ...
>
> Ok, I see.
>
> Then, do I need to reply each mail with my sob? Or only replace acked-by by sob for all commits in my tree?
You do not need to reply to each email, but any patch that you send on
to Linus (or someone else) needs to have your Signed-off-by. Please
read the "Developer's Certificate of Origin" in section 12 of
Documentation/SubmittingPatches.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* 回复： Re: 回复： Re: [Consult] About only one Signed-of-by for the patches
2014-05-27 22:43 ` Stephen Rothwell
@ 2014-05-28 0:00 ` Xuetao Guan
0 siblings, 0 replies; 6+ messages in thread
From: Xuetao Guan @ 2014-05-28 0:00 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Chen Gang, Guan Xuetao, linux-next
----- Stephen Rothwell <sfr@canb.auug.org.au> 写道：
> Hi,
>
> On Tue, 27 May 2014 13:07:30 +0800 (CST) Xuetao Guan <gxt@pku.edu.cn> wrote:
> >
> >
> > ----- Stephen Rothwell <sfr@canb.auug.org.au> 写道：
> > > Hi Chen,
> > >
> > > On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> > > >
> > > > I find some of patches are only Signed-of-by me, are they OK?
> > >
> > > Actually, this one is not OK. Anyone who handles a patch needs to add a
> > > Signed-off-by. In the case below, that patch was commited to the tree
> > > by Guan Xuetao <gxt@mprc.pku.edu.cn>, so there needs to be a
> > > Signed-off-by from them as well.
> > >
> > > The same is true for all the commits in the unicore32 tree ...
> >
> > Ok, I see.
> >
> > Then, do I need to reply each mail with my sob? Or only replace acked-by by sob for all commits in my tree?
>
> You do not need to reply to each email, but any patch that you send on
> to Linus (or someone else) needs to have your Signed-off-by. Please
> read the "Developer's Certificate of Origin" in section 12 of
> Documentation/SubmittingPatches.
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
I see. What I misunderstood is that acked-by had similar functions.
Thanks.
Xuetao
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-28 0:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-27 1:23 [Consult] About only one Signed-of-by for the patches Chen Gang
2014-05-27 1:34 ` Stephen Rothwell
2014-05-27 1:50 ` Chen Gang
2014-05-27 5:07 ` 回复： " Xuetao Guan
2014-05-27 22:43 ` Stephen Rothwell
2014-05-28 0:00 ` 回复： " Xuetao Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).