* [PATCH] net: bnx2x: fix build error with ptp
@ 2014-08-25 20:11 Randy Dunlap
2014-08-25 20:14 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2014-08-25 20:11 UTC (permalink / raw)
To: linux-next, netdev, David Miller; +Cc: Jim Davis, LKML, Ariel Elior
From: Randy Dunlap <rdunlap@infradead.org>
bnx2x uses ptp functions, so it should select the provider of
those functions (PTP_1588_CLOCK). Fixes these build errors:
drivers/built-in.o: In function `__bnx2x_remove':
/home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13409:
undefined reference to `ptp_clock_unregister'
drivers/built-in.o: In function `bnx2x_register_phc':
/home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13202:
undefined reference to `ptp_clock_register'
drivers/built-in.o: In function `bnx2x_get_ts_info':
/home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3498:
undefined reference to `ptp_clock_index'
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/net/ethernet/broadcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
Index: linux-next-20140825/drivers/net/ethernet/broadcom/Kconfig
===================================================================
--- linux-next-20140825.orig/drivers/net/ethernet/broadcom/Kconfig
+++ linux-next-20140825/drivers/net/ethernet/broadcom/Kconfig
@@ -122,6 +122,7 @@ config TIGON3
config BNX2X
tristate "Broadcom NetXtremeII 10Gb support"
depends on PCI
+ select PTP_1588_CLOCK
select FW_LOADER
select ZLIB_INFLATE
select LIBCRC32C
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: bnx2x: fix build error with ptp
2014-08-25 20:11 [PATCH] net: bnx2x: fix build error with ptp Randy Dunlap
@ 2014-08-25 20:14 ` Randy Dunlap
2014-08-26 0:37 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2014-08-25 20:14 UTC (permalink / raw)
To: linux-next, netdev, David Miller; +Cc: Jim Davis, LKML, Ariel Elior
Note: This patch fixes a build error in linux-next (not in mainline).
On 08/25/14 13:11, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> bnx2x uses ptp functions, so it should select the provider of
> those functions (PTP_1588_CLOCK). Fixes these build errors:
>
> drivers/built-in.o: In function `__bnx2x_remove':
> /home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13409:
> undefined reference to `ptp_clock_unregister'
> drivers/built-in.o: In function `bnx2x_register_phc':
> /home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13202:
> undefined reference to `ptp_clock_register'
> drivers/built-in.o: In function `bnx2x_get_ts_info':
> /home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3498:
> undefined reference to `ptp_clock_index'
>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/net/ethernet/broadcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-next-20140825/drivers/net/ethernet/broadcom/Kconfig
> ===================================================================
> --- linux-next-20140825.orig/drivers/net/ethernet/broadcom/Kconfig
> +++ linux-next-20140825/drivers/net/ethernet/broadcom/Kconfig
> @@ -122,6 +122,7 @@ config TIGON3
> config BNX2X
> tristate "Broadcom NetXtremeII 10Gb support"
> depends on PCI
> + select PTP_1588_CLOCK
> select FW_LOADER
> select ZLIB_INFLATE
> select LIBCRC32C
> --
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: bnx2x: fix build error with ptp
2014-08-25 20:14 ` Randy Dunlap
@ 2014-08-26 0:37 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2014-08-26 0:37 UTC (permalink / raw)
To: rdunlap; +Cc: linux-next, netdev, jim.epost, linux-kernel, ariel.elior
From: Randy Dunlap <rdunlap@infradead.org>
Date: Mon, 25 Aug 2014 13:14:08 -0700
> Note: This patch fixes a build error in linux-next (not in mainline).
Applied to net-next, thanks Randy.
You can put "[PATCH net-next]" into your subject line to make this
explicit next time.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-26 0:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-25 20:11 [PATCH] net: bnx2x: fix build error with ptp Randy Dunlap
2014-08-25 20:14 ` Randy Dunlap
2014-08-26 0:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).