linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>
Subject: Re: linux-next: build failure after merge of the nfs tree
Date: Mon, 15 Sep 2014 19:07:50 +0200	[thread overview]
Message-ID: <20140915170749.GB23433@lst.de> (raw)
In-Reply-To: <20140915170453.0e8d4e85@canb.auug.org.au>

Thanks Stephen!

Trond, can you just pick up the patch?  Considered it:

Reviewed-by: Christoph Hellwig <hch@lst.de>

On Mon, Sep 15, 2014 at 05:04:53PM +1000, Stephen Rothwell wrote:
> Hi Trond,
> 
> After merging the nfs tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> fs/nfs/blocklayout/extent_tree.c: In function 'ext_tree_prepare_commit':
> fs/nfs/blocklayout/extent_tree.c:540:3: error: implicit declaration of function '__vmalloc' [-Werror=implicit-function-declaration]
>    start_p = __vmalloc(buffer_size, GFP_NOFS, PAGE_KERNEL);
>    ^
> fs/nfs/blocklayout/extent_tree.c:540:11: warning: assignment makes pointer from integer without a cast
>    start_p = __vmalloc(buffer_size, GFP_NOFS, PAGE_KERNEL);
>            ^
> 
> Caused by commit 34dc93c2fc04 ("pnfs/blocklayout: allocate separate
> pages for the layoutcommit payload").
> 
> I added the following fix patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 15 Sep 2014 17:01:32 +1000
> Subject: [PATCH] pnfs/blocklayout: include vmalloc.h for __vmalloc
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  fs/nfs/blocklayout/extent_tree.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/nfs/blocklayout/extent_tree.c b/fs/nfs/blocklayout/extent_tree.c
> index 93193616205a..31d0b5e53dfd 100644
> --- a/fs/nfs/blocklayout/extent_tree.c
> +++ b/fs/nfs/blocklayout/extent_tree.c
> @@ -2,6 +2,8 @@
>   * Copyright (c) 2014 Christoph Hellwig.
>   */
>  
> +#include <linux/vmalloc.h>
> +
>  #include "blocklayout.h"
>  
>  #define NFSDBG_FACILITY		NFSDBG_PNFS_LD
> -- 
> 2.1.0
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au


---end quoted text---

  reply	other threads:[~2014-09-15 17:07 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15  7:04 linux-next: build failure after merge of the nfs tree Stephen Rothwell
2014-09-15 17:07 ` Christoph Hellwig [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-04-04 22:53 Stephen Rothwell
2024-04-04 23:08 ` Kuniyuki Iwashima
2016-06-27  0:58 Stephen Rothwell
2016-06-27 15:44 ` Trond Myklebust
2016-06-14  0:48 Stephen Rothwell
2016-05-19  0:58 Stephen Rothwell
2016-05-19 12:06 ` Trond Myklebust
2016-05-19 17:30   ` Anna Schumaker
2016-01-08  0:14 Stephen Rothwell
2016-01-08  0:15 ` Trond Myklebust
2015-08-18  0:56 Stephen Rothwell
2015-08-19  0:05 ` Stephen Rothwell
2015-08-19  0:15   ` Drokin, Oleg
2015-08-23 23:16 ` Stephen Rothwell
2015-08-24 14:17   ` Trond Myklebust
2015-08-24 14:48     ` Oleg Drokin
2013-11-19  0:01 Stephen Rothwell
2012-10-02  0:39 Stephen Rothwell
2012-10-02  1:08 ` Myklebust, Trond
2012-05-16  2:49 Stephen Rothwell
2012-05-16 17:47 ` Myklebust, Trond
2012-03-05  0:45 Stephen Rothwell
2012-03-05  1:58 ` Myklebust, Trond
2012-01-23  0:39 Stephen Rothwell
2012-01-23 18:13 ` Trond Myklebust
2012-01-23 21:10   ` Stephen Rothwell
2011-05-27  2:08 Stephen Rothwell
2011-05-12  1:12 Stephen Rothwell
2011-05-12 15:11 ` Trond Myklebust
2011-03-11  0:22 Stephen Rothwell
2011-03-08  1:07 Stephen Rothwell
2011-03-08 18:58 ` Trond Myklebust
2010-10-21  0:38 Stephen Rothwell
2010-10-21 14:33 ` Trond Myklebust
2010-03-22  0:26 Stephen Rothwell
2010-03-22  9:49 ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140915170749.GB23433@lst.de \
    --to=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).