linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Anna Schumaker <Anna.Schumaker@netapp.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Linus <torvalds@linux-foundation.org>
Subject: linux-next: build failure after merge of the nfs tree
Date: Thu, 19 May 2016 10:58:47 +1000	[thread overview]
Message-ID: <20160519105847.2b05c81f@canb.auug.org.au> (raw)

Hi Trond,

After merging the nfs tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from include/linux/fs.h:19:0,
                 from fs/nfs/nfs42proc.c:4:
fs/nfs/nfs42proc.c: In function 'nfs42_proc_copy':
fs/nfs/nfs42proc.c:212:30: error: 'struct inode' has no member named 'i_mutex'
   mutex_lock(&file_inode(dst)->i_mutex);
                              ^
include/linux/mutex.h:146:44: note: in definition of macro 'mutex_lock'
 #define mutex_lock(lock) mutex_lock_nested(lock, 0)
                                            ^
fs/nfs/nfs42proc.c:215:32: error: 'struct inode' has no member named 'i_mutex'
   mutex_unlock(&file_inode(dst)->i_mutex);
                                ^   

Caused by commit

  2e72448b07dc ("NFS: Add COPY nfs operation")

interacting with commit

  9902af79c01a ("parallel lookups: actual switch to rwsem")

from Linus' tree.

I applied the following merge fix patch - you will need to send this to
Linus when you ask him to merge your tree.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 19 May 2016 10:50:26 +1000
Subject: [PATCH] nfs: fix for i_mutex to i_rwsem change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/nfs/nfs42proc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
index 20c44d1209dc..aa03ed09ba06 100644
--- a/fs/nfs/nfs42proc.c
+++ b/fs/nfs/nfs42proc.c
@@ -209,10 +209,10 @@ ssize_t nfs42_proc_copy(struct file *src, loff_t pos_src,
 	dst_exception.state = dst_lock->open_context->state;
 
 	do {
-		mutex_lock(&file_inode(dst)->i_mutex);
+		inode_lock(file_inode(dst));
 		err = _nfs42_proc_copy(src, pos_src, src_lock,
 				       dst, pos_dst, dst_lock, count);
-		mutex_unlock(&file_inode(dst)->i_mutex);
+		inode_unlock(file_inode(dst));
 
 		if (err == -ENOTSUPP) {
 			err = -EOPNOTSUPP;
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell

             reply	other threads:[~2016-05-19  0:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19  0:58 Stephen Rothwell [this message]
2016-05-19 12:06 ` linux-next: build failure after merge of the nfs tree Trond Myklebust
2016-05-19 17:30   ` Anna Schumaker
  -- strict thread matches above, loose matches on Subject: below --
2024-04-04 22:53 Stephen Rothwell
2024-04-04 23:08 ` Kuniyuki Iwashima
2016-06-27  0:58 Stephen Rothwell
2016-06-27 15:44 ` Trond Myklebust
2016-06-14  0:48 Stephen Rothwell
2016-01-08  0:14 Stephen Rothwell
2016-01-08  0:15 ` Trond Myklebust
2015-08-18  0:56 Stephen Rothwell
2015-08-19  0:05 ` Stephen Rothwell
2015-08-19  0:15   ` Drokin, Oleg
2015-08-23 23:16 ` Stephen Rothwell
2015-08-24 14:17   ` Trond Myklebust
2015-08-24 14:48     ` Oleg Drokin
2014-09-15  7:04 Stephen Rothwell
2014-09-15 17:07 ` Christoph Hellwig
2013-11-19  0:01 Stephen Rothwell
2012-10-02  0:39 Stephen Rothwell
2012-10-02  1:08 ` Myklebust, Trond
2012-05-16  2:49 Stephen Rothwell
2012-05-16 17:47 ` Myklebust, Trond
2012-03-05  0:45 Stephen Rothwell
2012-03-05  1:58 ` Myklebust, Trond
2012-01-23  0:39 Stephen Rothwell
2012-01-23 18:13 ` Trond Myklebust
2012-01-23 21:10   ` Stephen Rothwell
2011-05-27  2:08 Stephen Rothwell
2011-05-12  1:12 Stephen Rothwell
2011-05-12 15:11 ` Trond Myklebust
2011-03-11  0:22 Stephen Rothwell
2011-03-08  1:07 Stephen Rothwell
2011-03-08 18:58 ` Trond Myklebust
2010-10-21  0:38 Stephen Rothwell
2010-10-21 14:33 ` Trond Myklebust
2010-03-22  0:26 Stephen Rothwell
2010-03-22  9:49 ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160519105847.2b05c81f@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=Anna.Schumaker@netapp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=trond.myklebust@fys.uio.no \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).