linux-next: build warning after merge of the nfs tree

linux-next: build warning after merge of the nfs tree

[Stephen Rothwell]

Hi Trond,

After merging the nfs tree, today's linux-next build (powerpc allyesconfig
produced this warning:

./usr/include/linux/nfs.h:40: found __[us]{8,16,32,64} type without #include <linux/types.h>

Introduced by commit

  a340abcf4173 ("nfs42: add NFS_IOC_CLONE_RANGE ioctl")

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build warning after merge of the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3908 bytes --]

Hi all,

On Fri, 7 Aug 2020 10:36:40 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the nfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> In file included from include/trace/define_trace.h:102,
>                  from fs/nfs/nfs4trace.h:2316,
>                  from fs/nfs/nfs4trace.c:13:
> fs/nfs/./nfs4trace.h: In function 'trace_event_raw_event_nfs4_read_event':
> fs/nfs/./nfs4trace.h:1767:34: warning: unused variable 'lo' [-Wunused-variable]
>  1767 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/trace_events.h:707:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>   707 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1759:3: note: in expansion of macro 'TP_fast_assign'
>  1759 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> fs/nfs/./nfs4trace.h: In function 'trace_event_raw_event_nfs4_write_event':
> fs/nfs/./nfs4trace.h:1844:34: warning: unused variable 'lo' [-Wunused-variable]
>  1844 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/trace_events.h:707:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>   707 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1836:3: note: in expansion of macro 'TP_fast_assign'
>  1836 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> fs/nfs/./nfs4trace.h: In function 'trace_event_raw_event_nfs4_commit_event':
> fs/nfs/./nfs4trace.h:1917:34: warning: unused variable 'lo' [-Wunused-variable]
>  1917 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/trace_events.h:707:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>   707 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1911:3: note: in expansion of macro 'TP_fast_assign'
>  1911 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> In file included from include/trace/define_trace.h:103,
>                  from fs/nfs/nfs4trace.h:2316,
>                  from fs/nfs/nfs4trace.c:13:
> fs/nfs/./nfs4trace.h: In function 'perf_trace_nfs4_read_event':
> fs/nfs/./nfs4trace.h:1767:34: warning: unused variable 'lo' [-Wunused-variable]
>  1767 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>    66 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1759:3: note: in expansion of macro 'TP_fast_assign'
>  1759 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> fs/nfs/./nfs4trace.h: In function 'perf_trace_nfs4_write_event':
> fs/nfs/./nfs4trace.h:1844:34: warning: unused variable 'lo' [-Wunused-variable]
>  1844 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>    66 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1836:3: note: in expansion of macro 'TP_fast_assign'
>  1836 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> fs/nfs/./nfs4trace.h: In function 'perf_trace_nfs4_commit_event':
> fs/nfs/./nfs4trace.h:1917:34: warning: unused variable 'lo' [-Wunused-variable]
>  1917 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>    66 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1911:3: note: in expansion of macro 'TP_fast_assign'
>  1911 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   34daa637f2b2 ("NFS: Add layout segment info to pnfs read/write/commit tracepoints")

I am still getting this warning ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3638 bytes --]

Hi all,

After merging the nfs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

In file included from include/trace/define_trace.h:102,
                 from fs/nfs/nfs4trace.h:2316,
                 from fs/nfs/nfs4trace.c:13:
fs/nfs/./nfs4trace.h: In function 'trace_event_raw_event_nfs4_read_event':
fs/nfs/./nfs4trace.h:1767:34: warning: unused variable 'lo' [-Wunused-variable]
 1767 |    const struct pnfs_layout_hdr *lo = lseg ?
      |                                  ^~
include/trace/trace_events.h:707:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  707 |  { assign; }       \
      |    ^~~~~~
fs/nfs/./nfs4trace.h:1759:3: note: in expansion of macro 'TP_fast_assign'
 1759 |   TP_fast_assign(
      |   ^~~~~~~~~~~~~~
fs/nfs/./nfs4trace.h: In function 'trace_event_raw_event_nfs4_write_event':
fs/nfs/./nfs4trace.h:1844:34: warning: unused variable 'lo' [-Wunused-variable]
 1844 |    const struct pnfs_layout_hdr *lo = lseg ?
      |                                  ^~
include/trace/trace_events.h:707:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  707 |  { assign; }       \
      |    ^~~~~~
fs/nfs/./nfs4trace.h:1836:3: note: in expansion of macro 'TP_fast_assign'
 1836 |   TP_fast_assign(
      |   ^~~~~~~~~~~~~~
fs/nfs/./nfs4trace.h: In function 'trace_event_raw_event_nfs4_commit_event':
fs/nfs/./nfs4trace.h:1917:34: warning: unused variable 'lo' [-Wunused-variable]
 1917 |    const struct pnfs_layout_hdr *lo = lseg ?
      |                                  ^~
include/trace/trace_events.h:707:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  707 |  { assign; }       \
      |    ^~~~~~
fs/nfs/./nfs4trace.h:1911:3: note: in expansion of macro 'TP_fast_assign'
 1911 |   TP_fast_assign(
      |   ^~~~~~~~~~~~~~
In file included from include/trace/define_trace.h:103,
                 from fs/nfs/nfs4trace.h:2316,
                 from fs/nfs/nfs4trace.c:13:
fs/nfs/./nfs4trace.h: In function 'perf_trace_nfs4_read_event':
fs/nfs/./nfs4trace.h:1767:34: warning: unused variable 'lo' [-Wunused-variable]
 1767 |    const struct pnfs_layout_hdr *lo = lseg ?
      |                                  ^~
include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
   66 |  { assign; }       \
      |    ^~~~~~
fs/nfs/./nfs4trace.h:1759:3: note: in expansion of macro 'TP_fast_assign'
 1759 |   TP_fast_assign(
      |   ^~~~~~~~~~~~~~
fs/nfs/./nfs4trace.h: In function 'perf_trace_nfs4_write_event':
fs/nfs/./nfs4trace.h:1844:34: warning: unused variable 'lo' [-Wunused-variable]
 1844 |    const struct pnfs_layout_hdr *lo = lseg ?
      |                                  ^~
include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
   66 |  { assign; }       \
      |    ^~~~~~
fs/nfs/./nfs4trace.h:1836:3: note: in expansion of macro 'TP_fast_assign'
 1836 |   TP_fast_assign(
      |   ^~~~~~~~~~~~~~
fs/nfs/./nfs4trace.h: In function 'perf_trace_nfs4_commit_event':
fs/nfs/./nfs4trace.h:1917:34: warning: unused variable 'lo' [-Wunused-variable]
 1917 |    const struct pnfs_layout_hdr *lo = lseg ?
      |                                  ^~
include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
   66 |  { assign; }       \
      |    ^~~~~~
fs/nfs/./nfs4trace.h:1911:3: note: in expansion of macro 'TP_fast_assign'
 1911 |   TP_fast_assign(
      |   ^~~~~~~~~~~~~~

Introduced by commit

  34daa637f2b2 ("NFS: Add layout segment info to pnfs read/write/commit tracepoints")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the nfs tree

[Trond Myklebust]

On Mon, 4 Jun 2018 at 20:18, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Trond,
>
> After merging the nfs tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> fs/nfs/nfs4proc.c:910:13: warning: 'nfs4_layoutget_release' defined but not used [-Wunused-function]
>  static void nfs4_layoutget_release(void *calldata)
>              ^~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
>   30ae2412e90f ("pnfs: Fix manipulation of NFS_LAYOUT_FIRST_LAYOUTGET")
>
> in combination with
>
>   2409a976a299 ("pnfs: Add LAYOUTGET to OPEN of a new file")
>
> # CONFIG_NFS_V4_1 is not set

Thanks Stephen! I've appended a fix to the linux-next branch.

Cheers
 Trond

linux-next: build warning after merge of the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

Hi Trond,

After merging the nfs tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/nfs/nfs4proc.c:910:13: warning: 'nfs4_layoutget_release' defined but not used [-Wunused-function]
 static void nfs4_layoutget_release(void *calldata)
             ^~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  30ae2412e90f ("pnfs: Fix manipulation of NFS_LAYOUT_FIRST_LAYOUTGET")

in combination with

  2409a976a299 ("pnfs: Add LAYOUTGET to OPEN of a new file")

# CONFIG_NFS_V4_1 is not set

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the nfs tree

[Stephen Rothwell]

Hi Trond,

After merging the nfs tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/nfs/export.c: In function 'nfs_encode_fh':
fs/nfs/export.c:58:1: warning: label 'out' defined but not used [-Wunused-label]
 out:
 ^~~

Introduced by commit

  aaa150089465 ("nfs: remove dead code from nfs_encode_fh()")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi Trond,

After merging the nfs tree, today's linux-next build (powerpc
ppc44x_defconfig and probably others) produced this warning:

fs/nfs/pagelist.c: In function 'nfs_initiate_pgio':
fs/nfs/pagelist.c:555:16: warning: unused variable 'inode' [-Wunused-variable]
  struct inode *inode = hdr->inode;
                ^

Introduced by commit 30e4c73543b0 ("nfs: merge nfs_pgio_data into
_header").

"inode" is only used in a dprintk().

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build warning after merge of the nfs tree

[Myklebust, Trond]

On Tue, 2012-03-20 at 19:34 +1100, Stephen Rothwell wrote:
> Hi Trond,
> 
> After merging the nfs tree, today's linux-next build (sparc32 defconfig)
> produced this warning:
> 
> net/sunrpc/rpcb_clnt.c: In function 'rpcb_enc_mapping':
> net/sunrpc/rpcb_clnt.c:820:19: warning: unused variable 'task' [-Wunused-variable]
> net/sunrpc/rpcb_clnt.c: In function 'rpcb_dec_getport':
> net/sunrpc/rpcb_clnt.c:837:19: warning: unused variable 'task' [-Wunused-variable]
> net/sunrpc/rpcb_clnt.c: In function 'rpcb_dec_set':
> net/sunrpc/rpcb_clnt.c:860:19: warning: unused variable 'task' [-Wunused-variable]
> net/sunrpc/rpcb_clnt.c: In function 'rpcb_enc_getaddr':
> net/sunrpc/rpcb_clnt.c:892:19: warning: unused variable 'task' [-Wunused-variable]
> net/sunrpc/rpcb_clnt.c: In function 'rpcb_dec_getaddr':
> net/sunrpc/rpcb_clnt.c:914:19: warning: unused variable 'task' [-Wunused-variable]
> fs/lockd/svclock.c:49:20: warning: 'nlmdbg_cookie2a' declared 'static' but never defined [-Wunused-function]
> 
> 
> Probably caused by some debugging being turned off.

Yes, this is due to the new CONFIG_SUNRPC_DEBUG being turned off. The
issue has in fact been in the tree for quite a while, but before we
added the explicit Kbuild switch, you had to have SUNRPC enabled, while
disabling SYSCTL in order to see it.

Anyhow, I've added a fix. Thanks for the report!

Cheers
  Trond
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

linux-next: build warning after merge of the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

Hi Trond,

After merging the nfs tree, today's linux-next build (sparc32 defconfig)
produced this warning:

net/sunrpc/rpcb_clnt.c: In function 'rpcb_enc_mapping':
net/sunrpc/rpcb_clnt.c:820:19: warning: unused variable 'task' [-Wunused-variable]
net/sunrpc/rpcb_clnt.c: In function 'rpcb_dec_getport':
net/sunrpc/rpcb_clnt.c:837:19: warning: unused variable 'task' [-Wunused-variable]
net/sunrpc/rpcb_clnt.c: In function 'rpcb_dec_set':
net/sunrpc/rpcb_clnt.c:860:19: warning: unused variable 'task' [-Wunused-variable]
net/sunrpc/rpcb_clnt.c: In function 'rpcb_enc_getaddr':
net/sunrpc/rpcb_clnt.c:892:19: warning: unused variable 'task' [-Wunused-variable]
net/sunrpc/rpcb_clnt.c: In function 'rpcb_dec_getaddr':
net/sunrpc/rpcb_clnt.c:914:19: warning: unused variable 'task' [-Wunused-variable]
fs/lockd/svclock.c:49:20: warning: 'nlmdbg_cookie2a' declared 'static' but never defined [-Wunused-function]


Probably caused by some debugging being turned off.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi Trond,

After merging the nfs tree, today's linux-next build (powerpc
ppc64_defconfig) produced lots of this warning:

include/linux/nfs_fs.h: In function 'nfs_display_fhandle_hash':
include/linux/nfs_fs.h:416:1: warning: no return statement in function returning non-void [-Wreturn-type]

Introduced by commit d8e0539ebdff ("NFS: add filehandle crc for debug
display").  But made obvious by commit 855fa894a2b2 ("SUNRPC/NFS: Add
Kbuild dependencies for NFS_DEBUG/RPC_DEBUG").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the nfs tree

[Trond Myklebust]

On Wed, 2010-08-04 at 11:32 +1000, Stephen Rothwell wrote:
> Hi Trond,
> 
> After merging the nfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/nfs/file.c: In function 'nfs_file_flush':
> fs/nfs/file.c:211: warning: unused variable 'ctx'
> 
> Introduced by commit 7f09dcf61bc211b0a71a5caa15ceb9b7bbec2126 ("NFS: Fix
> up the fsync code").

Hi Stephen,

Sorry. I've fixed the above warning up in today's tree.

Cheers
  Trond

linux-next: build warning after merge of the nfs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Hi Trond,

After merging the nfs tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/nfs/file.c: In function 'nfs_file_flush':
fs/nfs/file.c:211: warning: unused variable 'ctx'

Introduced by commit 7f09dcf61bc211b0a71a5caa15ceb9b7bbec2126 ("NFS: Fix
up the fsync code").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]