From: Vinod Koul <vinod.koul@intel.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "Dmitry V. Krivenok" <krivenok.dmitry@gmail.com>,
linux-kernel@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Wolfram Sang <wsa@the-dreams.de>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>, Ray Jui <rjui@broadcom.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-next@vger.kernel.org
Subject: Re: [PATCH 1/5] dma: do not use 0x in front of %pad
Date: Tue, 8 Dec 2015 22:16:38 +0530 [thread overview]
Message-ID: <20151208164637.GT1854@localhost> (raw)
In-Reply-To: <20151208144839.GA24928@ulmo>
[-- Attachment #1: Type: text/plain, Size: 2029 bytes --]
On Tue, Dec 08, 2015 at 03:48:39PM +0100, Thierry Reding wrote:
> On Tue, Dec 01, 2015 at 10:01:52AM +0100, Nicolas Ferre wrote:
> > Le 30/11/2015 21:45, Dmitry V. Krivenok a écrit :
> > > Signed-off-by: Dmitry V. Krivenok <krivenok.dmitry@gmail.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> >
> > > ---
> > > drivers/dma/at_hdmac_regs.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> > > index 7f58f06..0474e4a 100644
> > > --- a/drivers/dma/at_hdmac_regs.h
> > > +++ b/drivers/dma/at_hdmac_regs.h
> > > @@ -385,7 +385,7 @@ static void vdbg_dump_regs(struct at_dma_chan *atchan) {}
> > > static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
> > > {
> > > dev_crit(chan2dev(&atchan->chan_common),
> > > - " desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n",
> > > + " desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
> > > &lli->saddr, &lli->daddr,
> > > lli->ctrla, lli->ctrlb, &lli->dscr);
>
> Hi Vinod,
>
> I think this ended up being misapplied, possibly because the patch
> doesn't seem to have been based on something upstream. I got build
> warnings during sanity builds of linux-next today and applied this
> patch to fix them. Feel free to squash it into the original patch.
I have dropped that one and pushed updated tree few moments back !
--
~Vinod
>
> Thierry
>
> --->8---
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> index 610907dbc11a..0474e4a0f02a 100644
> --- a/drivers/dma/at_hdmac_regs.h
> +++ b/drivers/dma/at_hdmac_regs.h
> @@ -386,8 +386,8 @@ static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
> {
> dev_crit(chan2dev(&atchan->chan_common),
> " desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
> - lli->saddr, lli->daddr,
> - lli->ctrla, lli->ctrlb, lli->dscr);
> + &lli->saddr, &lli->daddr,
> + lli->ctrla, lli->ctrlb, &lli->dscr);
> }
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-12-08 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1448916349-13564-1-git-send-email-krivenok.dmitry@gmail.com>
[not found] ` <1448916349-13564-2-git-send-email-krivenok.dmitry@gmail.com>
[not found] ` <565D6200.9070709@atmel.com>
2015-12-08 14:48 ` [PATCH 1/5] dma: do not use 0x in front of %pad Thierry Reding
2015-12-08 16:46 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208164637.GT1854@localhost \
--to=vinod.koul@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=krivenok.dmitry@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).