* Re: [PATCH 1/5] dma: do not use 0x in front of %pad
[not found] ` <565D6200.9070709@atmel.com>
@ 2015-12-08 14:48 ` Thierry Reding
2015-12-08 16:46 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2015-12-08 14:48 UTC (permalink / raw)
To: Vinod Koul
Cc: Dmitry V. Krivenok, linux-kernel, Nicolas Ferre, Wolfram Sang,
Ross Zwisler, Dan Williams, Rob Herring, Frank Rowand,
Grant Likely, Bjorn Helgaas, Ray Jui, Andy Shevchenko,
linux-next
[-- Attachment #1: Type: text/plain, Size: 1784 bytes --]
On Tue, Dec 01, 2015 at 10:01:52AM +0100, Nicolas Ferre wrote:
> Le 30/11/2015 21:45, Dmitry V. Krivenok a écrit :
> > Signed-off-by: Dmitry V. Krivenok <krivenok.dmitry@gmail.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> > ---
> > drivers/dma/at_hdmac_regs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> > index 7f58f06..0474e4a 100644
> > --- a/drivers/dma/at_hdmac_regs.h
> > +++ b/drivers/dma/at_hdmac_regs.h
> > @@ -385,7 +385,7 @@ static void vdbg_dump_regs(struct at_dma_chan *atchan) {}
> > static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
> > {
> > dev_crit(chan2dev(&atchan->chan_common),
> > - " desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n",
> > + " desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
> > &lli->saddr, &lli->daddr,
> > lli->ctrla, lli->ctrlb, &lli->dscr);
Hi Vinod,
I think this ended up being misapplied, possibly because the patch
doesn't seem to have been based on something upstream. I got build
warnings during sanity builds of linux-next today and applied this
patch to fix them. Feel free to squash it into the original patch.
Thierry
--->8---
diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
index 610907dbc11a..0474e4a0f02a 100644
--- a/drivers/dma/at_hdmac_regs.h
+++ b/drivers/dma/at_hdmac_regs.h
@@ -386,8 +386,8 @@ static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
{
dev_crit(chan2dev(&atchan->chan_common),
" desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
- lli->saddr, lli->daddr,
- lli->ctrla, lli->ctrlb, lli->dscr);
+ &lli->saddr, &lli->daddr,
+ lli->ctrla, lli->ctrlb, &lli->dscr);
}
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/5] dma: do not use 0x in front of %pad
2015-12-08 14:48 ` [PATCH 1/5] dma: do not use 0x in front of %pad Thierry Reding
@ 2015-12-08 16:46 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2015-12-08 16:46 UTC (permalink / raw)
To: Thierry Reding
Cc: Dmitry V. Krivenok, linux-kernel, Nicolas Ferre, Wolfram Sang,
Ross Zwisler, Dan Williams, Rob Herring, Frank Rowand,
Grant Likely, Bjorn Helgaas, Ray Jui, Andy Shevchenko,
linux-next
[-- Attachment #1: Type: text/plain, Size: 2029 bytes --]
On Tue, Dec 08, 2015 at 03:48:39PM +0100, Thierry Reding wrote:
> On Tue, Dec 01, 2015 at 10:01:52AM +0100, Nicolas Ferre wrote:
> > Le 30/11/2015 21:45, Dmitry V. Krivenok a écrit :
> > > Signed-off-by: Dmitry V. Krivenok <krivenok.dmitry@gmail.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> >
> > > ---
> > > drivers/dma/at_hdmac_regs.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> > > index 7f58f06..0474e4a 100644
> > > --- a/drivers/dma/at_hdmac_regs.h
> > > +++ b/drivers/dma/at_hdmac_regs.h
> > > @@ -385,7 +385,7 @@ static void vdbg_dump_regs(struct at_dma_chan *atchan) {}
> > > static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
> > > {
> > > dev_crit(chan2dev(&atchan->chan_common),
> > > - " desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n",
> > > + " desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
> > > &lli->saddr, &lli->daddr,
> > > lli->ctrla, lli->ctrlb, &lli->dscr);
>
> Hi Vinod,
>
> I think this ended up being misapplied, possibly because the patch
> doesn't seem to have been based on something upstream. I got build
> warnings during sanity builds of linux-next today and applied this
> patch to fix them. Feel free to squash it into the original patch.
I have dropped that one and pushed updated tree few moments back !
--
~Vinod
>
> Thierry
>
> --->8---
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> index 610907dbc11a..0474e4a0f02a 100644
> --- a/drivers/dma/at_hdmac_regs.h
> +++ b/drivers/dma/at_hdmac_regs.h
> @@ -386,8 +386,8 @@ static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli)
> {
> dev_crit(chan2dev(&atchan->chan_common),
> " desc: s%pad d%pad ctrl0x%x:0x%x l%pad\n",
> - lli->saddr, lli->daddr,
> - lli->ctrla, lli->ctrlb, lli->dscr);
> + &lli->saddr, &lli->daddr,
> + lli->ctrla, lli->ctrlb, &lli->dscr);
> }
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-08 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1448916349-13564-1-git-send-email-krivenok.dmitry@gmail.com>
[not found] ` <1448916349-13564-2-git-send-email-krivenok.dmitry@gmail.com>
[not found] ` <565D6200.9070709@atmel.com>
2015-12-08 14:48 ` [PATCH 1/5] dma: do not use 0x in front of %pad Thierry Reding
2015-12-08 16:46 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).