* linux-next: build warning after merge of the md tree
@ 2017-03-28 4:40 Stephen Rothwell
2017-03-28 8:17 ` Ming Lei
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2017-03-28 4:40 UTC (permalink / raw)
To: Shaohua Li; +Cc: linux-next, linux-kernel, Ming Lei
Hi Shaohua,
After merging the md tree, today's linux-next build (powerpc
pseries_le_defconfig) produced this warning:
drivers/md/raid1.c: In function 'raid1d':
drivers/md/raid1.c:2172:9: warning: 'page_len$' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (memcmp(page_address(ppages[j]),
^
drivers/md/raid1.c:2160:7: note: 'page_len$' was declared here
int page_len[RESYNC_PAGES];
^
Introduced by commit
60928a91b0b3 ("md: raid1: use bio helper in process_checks()")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build warning after merge of the md tree
2017-03-28 4:40 linux-next: build warning after merge of the md tree Stephen Rothwell
@ 2017-03-28 8:17 ` Ming Lei
2017-03-28 15:49 ` Shaohua Li
0 siblings, 1 reply; 4+ messages in thread
From: Ming Lei @ 2017-03-28 8:17 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Shaohua Li, linux-next, linux-kernel
Hi,
On Tue, Mar 28, 2017 at 03:40:22PM +1100, Stephen Rothwell wrote:
> Hi Shaohua,
>
> After merging the md tree, today's linux-next build (powerpc
> pseries_le_defconfig) produced this warning:
>
> drivers/md/raid1.c: In function 'raid1d':
> drivers/md/raid1.c:2172:9: warning: 'page_len$' may be used uninitialized in this function [-Wmaybe-uninitialized]
> if (memcmp(page_address(ppages[j]),
> ^
> drivers/md/raid1.c:2160:7: note: 'page_len$' was declared here
> int page_len[RESYNC_PAGES];
> ^
>
> Introduced by commit
>
> 60928a91b0b3 ("md: raid1: use bio helper in process_checks()")
It is a false positive, and looks we have to initialize it for killing
the warning since I don't find a annotation for addressing uninitialized
array.
So how about the following patch?
---
>From 73fd5ba571465d764fc0cf73fc4169d222dd676a Mon Sep 17 00:00:00 2001
From: Ming Lei <tom.leiming@gmail.com>
Date: Tue, 28 Mar 2017 16:09:13 +0800
Subject: [PATCH] md: raid1: kill warning on powerpc_pseries
This patch kills the warning reported on powerpc_pseries,
and actually we don't need the initialization.
After merging the md tree, today's linux-next build (powerpc
pseries_le_defconfig) produced this warning:
drivers/md/raid1.c: In function 'raid1d':
drivers/md/raid1.c:2172:9: warning: 'page_len$' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (memcmp(page_address(ppages[j]),
^
drivers/md/raid1.c:2160:7: note: 'page_len$' was declared here
int page_len[RESYNC_PAGES];
^
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
drivers/md/raid1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 3c13286190c1..7e6350334d8e 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -2172,7 +2172,7 @@ static void process_checks(struct r1bio *r1_bio)
struct page **ppages = get_resync_pages(pbio)->pages;
struct page **spages = get_resync_pages(sbio)->pages;
struct bio_vec *bi;
- int page_len[RESYNC_PAGES];
+ int page_len[RESYNC_PAGES] = { 0 };
if (sbio->bi_end_io != end_sync_read)
continue;
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: linux-next: build warning after merge of the md tree
2017-03-28 8:17 ` Ming Lei
@ 2017-03-28 15:49 ` Shaohua Li
0 siblings, 0 replies; 4+ messages in thread
From: Shaohua Li @ 2017-03-28 15:49 UTC (permalink / raw)
To: Ming Lei; +Cc: Stephen Rothwell, linux-next, linux-kernel
On Tue, Mar 28, 2017 at 04:17:55PM +0800, Ming Lei wrote:
> Hi,
>
> On Tue, Mar 28, 2017 at 03:40:22PM +1100, Stephen Rothwell wrote:
> > Hi Shaohua,
> >
> > After merging the md tree, today's linux-next build (powerpc
> > pseries_le_defconfig) produced this warning:
> >
> > drivers/md/raid1.c: In function 'raid1d':
> > drivers/md/raid1.c:2172:9: warning: 'page_len$' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > if (memcmp(page_address(ppages[j]),
> > ^
> > drivers/md/raid1.c:2160:7: note: 'page_len$' was declared here
> > int page_len[RESYNC_PAGES];
> > ^
> >
> > Introduced by commit
> >
> > 60928a91b0b3 ("md: raid1: use bio helper in process_checks()")
>
> It is a false positive, and looks we have to initialize it for killing
> the warning since I don't find a annotation for addressing uninitialized
> array.
>
> So how about the following patch?
thanks, added.
> ---
>
> From 73fd5ba571465d764fc0cf73fc4169d222dd676a Mon Sep 17 00:00:00 2001
> From: Ming Lei <tom.leiming@gmail.com>
> Date: Tue, 28 Mar 2017 16:09:13 +0800
> Subject: [PATCH] md: raid1: kill warning on powerpc_pseries
>
> This patch kills the warning reported on powerpc_pseries,
> and actually we don't need the initialization.
>
> After merging the md tree, today's linux-next build (powerpc
> pseries_le_defconfig) produced this warning:
>
> drivers/md/raid1.c: In function 'raid1d':
> drivers/md/raid1.c:2172:9: warning: 'page_len$' may be used uninitialized in this function [-Wmaybe-uninitialized]
> if (memcmp(page_address(ppages[j]),
> ^
> drivers/md/raid1.c:2160:7: note: 'page_len$' was declared here
> int page_len[RESYNC_PAGES];
> ^
>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
> drivers/md/raid1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 3c13286190c1..7e6350334d8e 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -2172,7 +2172,7 @@ static void process_checks(struct r1bio *r1_bio)
> struct page **ppages = get_resync_pages(pbio)->pages;
> struct page **spages = get_resync_pages(sbio)->pages;
> struct bio_vec *bi;
> - int page_len[RESYNC_PAGES];
> + int page_len[RESYNC_PAGES] = { 0 };
>
> if (sbio->bi_end_io != end_sync_read)
> continue;
> --
> 2.9.3
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* linux-next: build warning after merge of the md tree
@ 2017-08-09 3:14 Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2017-08-09 3:14 UTC (permalink / raw)
To: Shaohua Li; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Song Liu
Hi Shaohua,
After merging the md tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/md/raid5-cache.c: In function 'r5c_journal_mode_show':
drivers/md/raid5-cache.c:2535:2: warning: ignoring return value of 'mddev_lock', declared with attribute warn_unused_result [-Wunused-result]
mddev_lock(mddev);
^
Introduced by commit
7f7abe0ec5bb ("md/r5cache: call mddev_lock/unlock() in r5c_journal_mode_show")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-09 3:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 4:40 linux-next: build warning after merge of the md tree Stephen Rothwell
2017-03-28 8:17 ` Ming Lei
2017-03-28 15:49 ` Shaohua Li
2017-08-09 3:14 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).