* linux-next: build warning after merge of the cgroup tree
@ 2017-05-01 4:53 Stephen Rothwell
2017-05-01 19:41 ` [PATCH cgroup/for-4.12] cgroup: mark cgroup_get() with __maybe_unused Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2017-05-01 4:53 UTC (permalink / raw)
To: Tejun Heo; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi Tejun,
After merging the cgroup tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
kernel/cgroup/cgroup.c:439:13: warning: 'cgroup_get' defined but not used [-Wunused-function]
static void cgroup_get(struct cgroup *cgrp)
^
Introduced by commit
a590b90d472f ("cgroup: fix spurious warnings on cgroup_is_dead() from cgroup_sk_alloc()")
CONFIG_SOCK_CGROUP_DATA is not set for this build.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH cgroup/for-4.12] cgroup: mark cgroup_get() with __maybe_unused
2017-05-01 4:53 linux-next: build warning after merge of the cgroup tree Stephen Rothwell
@ 2017-05-01 19:41 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2017-05-01 19:41 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Li Zefan,
Johannes Weiner, cgroups
>From 310b4816a5d8082416b4ab83e5a7b3cb92883a4d Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Mon, 1 May 2017 15:24:14 -0400
a590b90d472f ("cgroup: fix spurious warnings on cgroup_is_dead() from
cgroup_sk_alloc()") converted most cgroup_get() usages to
cgroup_get_live() leaving cgroup_sk_alloc() the sole user of
cgroup_get(). When !CONFIG_SOCK_CGROUP_DATA, this ends up triggering
unused warning for cgroup_get().
Silence the warning by adding __maybe_unused to cgroup_get().
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Link: http://lkml.kernel.org/r/20170501145340.17e8ef86@canb.auug.org.au
Signed-off-by: Tejun Heo <tj@kernel.org>
---
Applied to cgroup/for-4.12.
Thanks!
kernel/cgroup/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 38d9386..f2bcc11 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -436,7 +436,7 @@ struct cgroup_subsys_state *cgroup_get_e_css(struct cgroup *cgrp,
return css;
}
-static void cgroup_get(struct cgroup *cgrp)
+static void __maybe_unused cgroup_get(struct cgroup *cgrp)
{
css_get(&cgrp->self);
}
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-01 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-01 4:53 linux-next: build warning after merge of the cgroup tree Stephen Rothwell
2017-05-01 19:41 ` [PATCH cgroup/for-4.12] cgroup: mark cgroup_get() with __maybe_unused Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).