* build failure after merge of the rcu tree
@ 2017-10-09 17:05 Mark Brown
2017-10-09 17:17 ` Mark Brown
2017-10-09 19:43 ` Paul E. McKenney
0 siblings, 2 replies; 4+ messages in thread
From: Mark Brown @ 2017-10-09 17:05 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
After merging the rcu tree an arm64 defconfig fails to build with:
/home/broonie/tmpfs/next/drivers/firmware/tegra/ivc.c: In function 'tegra_ivc_ad
vance_tx':
/home/broonie/tmpfs/next/drivers/firmware/tegra/ivc.c:154:39: error: lvalue required as left operand of assignment
READ_ONCE(ivc->tx.channel->tx.count) =
^
/home/broonie/tmpfs/next/drivers/firmware/tegra/ivc.c: In function 'tegra_ivc_advance_rx':
/home/broonie/tmpfs/next/drivers/firmware/tegra/ivc.c:165:39: error: lvalue required as left operand of assignment
READ_ONCE(ivc->rx.channel->rx.count) =
^
/home/broonie/tmpfs/next/scripts/Makefile.build:313: recipe for target 'drivers/firmware/tegra/ivc.o' failed
caused by 669f98e232aa6f77bd60 ("drivers/firmware/tegra: Convert
ACCESS_ONCE() to READ_ONCE()") in the rcu tree. I've reverted to the
RCU version from September 28th (which is already in Linus' tree).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: build failure after merge of the rcu tree
2017-10-09 17:05 build failure after merge of the rcu tree Mark Brown
@ 2017-10-09 17:17 ` Mark Brown
2017-10-09 19:42 ` Paul E. McKenney
2017-10-09 19:43 ` Paul E. McKenney
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2017-10-09 17:17 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
On Mon, Oct 09, 2017 at 06:05:40PM +0100, Mark Brown wrote:
> caused by 669f98e232aa6f77bd60 ("drivers/firmware/tegra: Convert
> ACCESS_ONCE() to READ_ONCE()") in the rcu tree. I've reverted to the
> RCU version from September 28th (which is already in Linus' tree).
BTW there were also a bunch of merge issues that I sent out mails for
but they seem to have gone AWOL somewhere, don't know if you got them :/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: build failure after merge of the rcu tree
2017-10-09 17:17 ` Mark Brown
@ 2017-10-09 19:42 ` Paul E. McKenney
0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2017-10-09 19:42 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-next
On Mon, Oct 09, 2017 at 06:17:24PM +0100, Mark Brown wrote:
> On Mon, Oct 09, 2017 at 06:05:40PM +0100, Mark Brown wrote:
>
> > caused by 669f98e232aa6f77bd60 ("drivers/firmware/tegra: Convert
> > ACCESS_ONCE() to READ_ONCE()") in the rcu tree. I've reverted to the
> > RCU version from September 28th (which is already in Linus' tree).
>
> BTW there were also a bunch of merge issues that I sent out mails for
> but they seem to have gone AWOL somewhere, don't know if you got them :/
Hello, Mark,
I did get three of them, thank you! The one involving rcu_irq_enter()
is because one of my commits hit mainline early, so I will need to rebase
to get things straightened out. Almost all of the ACCESS_ONCE() commits
are going away, courtesy of Mark Rutland's Coccinelle script. The one
involving the timer will be resolved by my updating my diagnostic commit.
All in all, I should have left some of these commits out of rcu/next,
apologies for the noise!
Thanx, Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: build failure after merge of the rcu tree
2017-10-09 17:05 build failure after merge of the rcu tree Mark Brown
2017-10-09 17:17 ` Mark Brown
@ 2017-10-09 19:43 ` Paul E. McKenney
1 sibling, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2017-10-09 19:43 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-next
On Mon, Oct 09, 2017 at 06:05:40PM +0100, Mark Brown wrote:
> After merging the rcu tree an arm64 defconfig fails to build with:
>
> /home/broonie/tmpfs/next/drivers/firmware/tegra/ivc.c: In function 'tegra_ivc_ad
> vance_tx':
> /home/broonie/tmpfs/next/drivers/firmware/tegra/ivc.c:154:39: error: lvalue required as left operand of assignment
> READ_ONCE(ivc->tx.channel->tx.count) =
> ^
> /home/broonie/tmpfs/next/drivers/firmware/tegra/ivc.c: In function 'tegra_ivc_advance_rx':
> /home/broonie/tmpfs/next/drivers/firmware/tegra/ivc.c:165:39: error: lvalue required as left operand of assignment
> READ_ONCE(ivc->rx.channel->rx.count) =
> ^
> /home/broonie/tmpfs/next/scripts/Makefile.build:313: recipe for target 'drivers/firmware/tegra/ivc.o' failed
>
> caused by 669f98e232aa6f77bd60 ("drivers/firmware/tegra: Convert
> ACCESS_ONCE() to READ_ONCE()") in the rcu tree. I've reverted to the
> RCU version from September 28th (which is already in Linus' tree).
And this one is me having failed to push that last fix out. But the
whole commit is going away in favor of Mark Rutland's Coccinelle script
anyway.
Thanx, Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-09 19:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-09 17:05 build failure after merge of the rcu tree Mark Brown
2017-10-09 17:17 ` Mark Brown
2017-10-09 19:42 ` Paul E. McKenney
2017-10-09 19:43 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).