linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the jc_docs tree with the printk tree
@ 2017-12-21 23:45 Stephen Rothwell
  2017-12-22 11:08 ` Petr Mladek
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2017-12-21 23:45 UTC (permalink / raw)
  To: Jonathan Corbet, Petr Mladek
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Sergey Senozhatsky, Tobin C. Harding

Hi Jonathan,

Today's linux-next merge of the jc_docs tree got a conflict in:

  Documentation/core-api/printk-formats.rst

between commit:

  d7c6075efa6c ("symbol lookup: introduce dereference_symbol_descriptor()")

from the printk tree and commit:

  b3ed23213eab ("doc: convert printk-formats.txt to rst")

from the jc_docs tree.

I fixed it up (I think, see below) and can carry the fix as
necessary. This is now fixed as far as linux-next is concerned, but any
non trivial conflicts should be mentioned to your upstream maintainer
when your tree is submitted for merging.  You may also want to consider
cooperating with the maintainer of the conflicting tree to minimise any
particularly complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc Documentation/core-api/printk-formats.rst
index dc3551ef1a4b,258b46435320..000000000000
--- a/Documentation/core-api/printk-formats.rst
+++ b/Documentation/core-api/printk-formats.rst
@@@ -61,33 -68,44 +68,33 @@@ Symbols/Function Pointer
  
  ::
  
 +	%pS	versatile_init+0x0/0x110
 +	%ps	versatile_init
  	%pF	versatile_init+0x0/0x110
  	%pf	versatile_init
 -	%pS	versatile_init+0x0/0x110
  	%pSR	versatile_init+0x9/0x110
  		(with __builtin_extract_return_addr() translation)
 -	%ps	versatile_init
  	%pB	prev_fn_of_versatile_init+0x88/0x88
  
 +The ``S`` and ``s`` specifiers are used for printing a pointer in symbolic
- format. They result in the symbol name with (``S``) or without (``s``)
++format. They result in the symbol name with (S) or without (s)
 +offsets. If KALLSYMS are disabled then the symbol address is printed instead.
  
- Note, that the ``F`` and ``f`` specifiers are identical to ``S`` (``s``)
 -The ``F`` and ``f`` specifiers are for printing function pointers,
 -for example, f->func, &gettimeofday. They have the same result as
 -``S`` and ``s`` specifiers. But they do an extra conversion on
 -ia64, ppc64 and parisc64 architectures where the function pointers
 -are actually function descriptors.
 -
 -The ``S`` and ``s`` specifiers can be used for printing symbols
 -from direct addresses, for example, __builtin_return_address(0),
 -(void *)regs->ip. They result in the symbol name with (S) or
 -without (s) offsets. If KALLSYMS are disabled then the symbol
 -address is printed instead.
++Note, that the ``F`` and ``f`` specifiers are identical to ``S`` (s)
 +and thus deprecated. We have ``F`` and ``f`` because on ia64, ppc64 and
 +parisc64 function pointers are indirect and, in fact, are function
 +descriptors, which require additional dereferencing before we can lookup
 +the symbol. As of now, ``S`` and ``s`` perform dereferencing on those
 +platforms (when needed), so ``F`` and ``f`` exist for compatibility
 +reasons only.
  
  The ``B`` specifier results in the symbol name with offsets and should be
  used when printing stack backtraces. The specifier takes into
  consideration the effect of compiler optimisations which may occur
- when tail-call``s are used and marked with the noreturn GCC attribute.
+ when tail-calls are used and marked with the noreturn GCC attribute.
  
 -Examples::
 -
 -	printk("Going to call: %pF\n", gettimeofday);
 -	printk("Going to call: %pF\n", p->func);
 -	printk("%s: called from %pS\n", __func__, (void *)_RET_IP_);
 -	printk("%s: called from %pS\n", __func__,
 -				(void *)__builtin_return_address(0));
 -	printk("Faulted at %pS\n", (void *)regs->ip);
 -	printk(" %s%pB\n", (reliable ? "" : "? "), (void *)*stack);
 -
  Kernel Pointers
- ===============
+ ---------------
  
  ::
  

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-next: manual merge of the jc_docs tree with the printk tree
  2017-12-21 23:45 linux-next: manual merge of the jc_docs tree with the printk tree Stephen Rothwell
@ 2017-12-22 11:08 ` Petr Mladek
  0 siblings, 0 replies; 2+ messages in thread
From: Petr Mladek @ 2017-12-22 11:08 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: Stephen Rothwell, Linux-Next Mailing List,
	Linux Kernel Mailing List, Sergey Senozhatsky, Tobin C. Harding

Hi Jonathan,

On Fri 2017-12-22 10:45:30, Stephen Rothwell wrote:
> Hi Jonathan,
> 
> Today's linux-next merge of the jc_docs tree got a conflict in:
> 
>   Documentation/core-api/printk-formats.rst
> 
> between commit:
> 
>   d7c6075efa6c ("symbol lookup: introduce dereference_symbol_descriptor()")
> 
> from the printk tree and commit:
> 
>   b3ed23213eab ("doc: convert printk-formats.txt to rst")
> 
> from the jc_docs tree.
> 
> I fixed it up (I think, see below) and can carry the fix as
> necessary. This is now fixed as far as linux-next is concerned, but any
> non trivial conflicts should be mentioned to your upstream maintainer
> when your tree is submitted for merging.  You may also want to consider
> cooperating with the maintainer of the conflicting tree to minimise any
> particularly complex conflicts.

I guess that you have experience with these problems so you probably
know how to handle this the best way.

Anyway, the printk.git stuff is targeting kernel-4.16. I have no
problem to take the document conversion via printk.git tree.
We could do it also the other way. But note that the conflicting
change in printk.git is part of a patchset (8 patches).

Best Regards,
Petr

PS: I will stay out of computers next week, so I probably
won't be able to do anything about this until January 2, 2018.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-22 11:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-21 23:45 linux-next: manual merge of the jc_docs tree with the printk tree Stephen Rothwell
2017-12-22 11:08 ` Petr Mladek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).