* linux-next: Signed-off-by missing for commit in the bluetooth tree
@ 2017-12-29 23:25 Stephen Rothwell
2017-12-29 23:32 ` Stephen Rothwell
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2017-12-29 23:25 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi all,
Commit
0a03f98b98c2 ("Bluetooth: Add a new 04ca:3015 QCA_ROME device")
is missing a Signed-off-by from its .
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the bluetooth tree
2017-12-29 23:25 linux-next: Signed-off-by missing for commit in the bluetooth tree Stephen Rothwell
@ 2017-12-29 23:32 ` Stephen Rothwell
2017-12-30 7:44 ` Johan Hedberg
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2017-12-29 23:32 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi all,
On Sat, 30 Dec 2017 10:25:52 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commit
>
> 0a03f98b98c2 ("Bluetooth: Add a new 04ca:3015 QCA_ROME device")
>
> is missing a Signed-off-by from its .
^
committer
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the bluetooth tree
2017-12-29 23:32 ` Stephen Rothwell
@ 2017-12-30 7:44 ` Johan Hedberg
2017-12-31 11:32 ` Andy Shevchenko
0 siblings, 1 reply; 14+ messages in thread
From: Johan Hedberg @ 2017-12-30 7:44 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Marcel Holtmann, Linux-Next Mailing List, Linux Kernel Mailing List
Hi,
On Sat, Dec 30, 2017, Stephen Rothwell wrote:
> On Sat, 30 Dec 2017 10:25:52 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Commit
> >
> > 0a03f98b98c2 ("Bluetooth: Add a new 04ca:3015 QCA_ROME device")
> >
> > is missing a Signed-off-by from its .
> ^
> committer
It was me who originally committed and pushed this to the bluetooth-next
tree, and the commit does have a signed-off-by from me. However, it
looks like Marcel did some reshuffling/rebasing of the tree and now the
commit shows him in the committer field.
Johan
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the bluetooth tree
2017-12-30 7:44 ` Johan Hedberg
@ 2017-12-31 11:32 ` Andy Shevchenko
0 siblings, 0 replies; 14+ messages in thread
From: Andy Shevchenko @ 2017-12-31 11:32 UTC (permalink / raw)
To: Johan Hedberg
Cc: Stephen Rothwell, Marcel Holtmann, Linux-Next Mailing List,
Linux Kernel Mailing List
On Sat, Dec 30, 2017 at 9:44 AM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> Hi,
>
> On Sat, Dec 30, 2017, Stephen Rothwell wrote:
>> On Sat, 30 Dec 2017 10:25:52 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> > Commit
>> >
>> > 0a03f98b98c2 ("Bluetooth: Add a new 04ca:3015 QCA_ROME device")
>> >
>> > is missing a Signed-off-by from its .
>> ^
>> committer
>
> It was me who originally committed and pushed this to the bluetooth-next
> tree, and the commit does have a signed-off-by from me. However, it
> looks like Marcel did some reshuffling/rebasing of the tree and now the
> commit shows him in the committer field.
In PDx86 subsystem we in the result of this check split our (Darren's
and mine) review queues to a separate *non-published* (OK, they are
visible, but not considered published) branches.
Rebase, as stated that time by Linus, as formally creating new commits.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the bluetooth tree
@ 2020-04-28 22:09 Stephen Rothwell
0 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2020-04-28 22:09 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Amit K Bag,
Tumkur Narayan, Chethan, Hegde, Raghuram
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
Hi all,
Commit
bf1f79470a62 ("Bluetooth: btusb: Add support for Intel Bluetooth Device Typhoon Peak (8087:0032)")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the bluetooth tree
@ 2021-01-26 8:54 Stephen Rothwell
2021-01-26 9:46 ` Bastien Nocera
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2021-01-26 8:54 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Bastien Nocera, Florian Dollinger, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
Hi all,
Commit
98d2c3e17310 ("Bluetooth: L2CAP: Try harder to accept device not knowing options")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the bluetooth tree
2021-01-26 8:54 Stephen Rothwell
@ 2021-01-26 9:46 ` Bastien Nocera
0 siblings, 0 replies; 14+ messages in thread
From: Bastien Nocera @ 2021-01-26 9:46 UTC (permalink / raw)
To: Stephen Rothwell, Marcel Holtmann, Johan Hedberg
Cc: Florian Dollinger, Linux Kernel Mailing List, Linux Next Mailing List
On Tue, 2021-01-26 at 19:54 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 98d2c3e17310 ("Bluetooth: L2CAP: Try harder to accept device not
> knowing options")
>
> is missing a Signed-off-by from its author.
Marcel, is it possible to amend this to add my Signed-off-by?
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Cheers
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the bluetooth tree
@ 2021-04-08 0:00 Stephen Rothwell
0 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2021-04-08 0:00 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Luiz Augusto von Dentz, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
Hi all,
Commit
f48a273a4244 ("Bluetooth: virtio_bt: Use virtio_cread16 instead of virtio_cread")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the bluetooth tree
@ 2022-07-24 21:57 Stephen Rothwell
2022-07-24 22:17 ` Stephen Rothwell
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2022-07-24 21:57 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Luiz Augusto von Dentz, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]
Hi all,
Commits
a5133fe87ed8 ("Bluetooth: use memset avoid memory leaks")
9111786492f1 ("Bluetooth: fix an error code in hci_register_dev()")
4f17c2b6694d ("Bluetooth: hci_bcm: Add BCM4349B1 variant")
88b65887aa1b ("dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding")
359ee4f834f5 ("Bluetooth: Unregister suspend with userchannel")
0acef50ba3b5 ("Bluetooth: Fix index added after unregister")
877afadad2dc ("Bluetooth: When HCI work queue is drained, only queue chained work")
ab2d2a982ff7 ("Bluetooth: hci_intel: Add check for platform_driver_register")
629f66aaca81 ("Bluetooth: clear the temporary linkkey in hci_conn_cleanup")
af35e28f0fea ("Bluetooth: hci_bcm: Add support for FW loading in autobaud mode")
0b4de2523f28 ("dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode")
bde63e9effd3 ("Bluetooth: hci_qca: Return wakeup for qca_wakeup")
c69ecb0ea4c9 ("Bluetooth: btusb: Add support of IMC Networks PID 0x3568")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the bluetooth tree
2022-07-24 21:57 Stephen Rothwell
@ 2022-07-24 22:17 ` Stephen Rothwell
0 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2022-07-24 22:17 UTC (permalink / raw)
To: David Miller
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
Linux Kernel Mailing List, Linux Next Mailing List, Networking
[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]
Hi all,
[Resent with corrected mail address]
On Mon, 25 Jul 2022 07:57:28 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commits
>
> a5133fe87ed8 ("Bluetooth: use memset avoid memory leaks")
> 9111786492f1 ("Bluetooth: fix an error code in hci_register_dev()")
> 4f17c2b6694d ("Bluetooth: hci_bcm: Add BCM4349B1 variant")
> 88b65887aa1b ("dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding")
> 359ee4f834f5 ("Bluetooth: Unregister suspend with userchannel")
> 0acef50ba3b5 ("Bluetooth: Fix index added after unregister")
> 877afadad2dc ("Bluetooth: When HCI work queue is drained, only queue chained work")
> ab2d2a982ff7 ("Bluetooth: hci_intel: Add check for platform_driver_register")
> 629f66aaca81 ("Bluetooth: clear the temporary linkkey in hci_conn_cleanup")
> af35e28f0fea ("Bluetooth: hci_bcm: Add support for FW loading in autobaud mode")
> 0b4de2523f28 ("dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode")
> bde63e9effd3 ("Bluetooth: hci_qca: Return wakeup for qca_wakeup")
> c69ecb0ea4c9 ("Bluetooth: btusb: Add support of IMC Networks PID 0x3568")
>
> are missing a Signed-off-by from their committer.
These are now in the net-next tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the bluetooth tree
@ 2022-09-05 21:54 Stephen Rothwell
0 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2022-09-05 21:54 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Luiz Augusto von Dentz, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
Hi all,
Commits
45d33c081bcf ("Bluetooth: Add experimental wrapper for MGMT based mesh")
6db7da4c50f0 ("Bluetooth: Implement support for Mesh")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the bluetooth tree
@ 2022-09-20 22:30 Stephen Rothwell
0 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2022-09-20 22:30 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Luiz Augusto von Dentz, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
Hi all,
Commit
239491111238 ("Bluetooth: MGMT: fix zalloc-simple.cocci warnings")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the bluetooth tree
@ 2023-07-05 23:10 Stephen Rothwell
0 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2023-07-05 23:10 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Luiz Augusto von Dentz, Valentin David,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
Hi all,
Commit
10912d85b17a ("Bluetooth: btusb: Add device 0489:e0f5 as MT7922 device")
is missing a Signed-off-by from its author.
Also, please separate the commit message tags from the rest of the
commit message with a blank line.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the bluetooth tree
@ 2024-04-30 21:54 Stephen Rothwell
0 siblings, 0 replies; 14+ messages in thread
From: Stephen Rothwell @ 2024-04-30 21:54 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: Luiz Augusto von Dentz, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
Hi all,
Commit
0172c2365299 ("Revert "Bluetooth: HCI: fix slab-use-after-free in cmd_sync_work"")
is missing a Signed-off-by from its author and committer.
Reverts are commits as well and so need Signed-off-bys and reasonable
commit messages i.e. it is useful to know why the commit was reverted.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2024-04-30 21:54 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-29 23:25 linux-next: Signed-off-by missing for commit in the bluetooth tree Stephen Rothwell
2017-12-29 23:32 ` Stephen Rothwell
2017-12-30 7:44 ` Johan Hedberg
2017-12-31 11:32 ` Andy Shevchenko
2020-04-28 22:09 Stephen Rothwell
2021-01-26 8:54 Stephen Rothwell
2021-01-26 9:46 ` Bastien Nocera
2021-04-08 0:00 Stephen Rothwell
2022-07-24 21:57 Stephen Rothwell
2022-07-24 22:17 ` Stephen Rothwell
2022-09-05 21:54 Stephen Rothwell
2022-09-20 22:30 Stephen Rothwell
2023-07-05 23:10 Stephen Rothwell
2024-04-30 21:54 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).