From: Stephen Rothwell <sfr@canb.auug.org.au>
To: dvhart@infradead.org
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Haruka Kawajiri <yukx00@gmail.com>
Subject: Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree
Date: Sat, 2 Jun 2018 01:26:46 +1000 [thread overview]
Message-ID: <20180602012646.2a0801e8@canb.auug.org.au> (raw)
In-Reply-To: <7EC66A28-4E57-4B3C-A5AC-4D7D9CAF727E@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]
Hi,
On Fri, 01 Jun 2018 07:38:42 -0700 dvhart@infradead.org wrote:
>
> Stephen, are the tests you use available publicly?
I use the script below when I am fetching trees. You don't want the
"gitk" invocation if you are doing this automatically, of course. The
script just takes a commit range.
--
Cheers,
Stephen Rothwell
-------------------------------------------------------------
#!/bin/bash
if [ "$#" -lt 1 ]; then
printf "Usage: %s <commit range>\n", "$0" 1>&2
exit 1
fi
commits=$(git rev-list --no-merges "$@")
if [ -z "$commits" ]; then
printf "No commits\n"
exit 0
fi
for c in $commits; do
ae=$(git log -1 --format='%ae' "$c")
aE=$(git log -1 --format='%aE' "$c")
an=$(git log -1 --format='%an' "$c")
aN=$(git log -1 --format='%aN' "$c")
ce=$(git log -1 --format='%ce' "$c")
cE=$(git log -1 --format='%cE' "$c")
cn=$(git log -1 --format='%cn' "$c")
cN=$(git log -1 --format='%cN' "$c")
sob=$(git log -1 --format='%b' "$c" | grep -i '^[[:space:]]*Signed-off-by:')
am=false
cm=false
grep -i -q "<$ae>" <<<"$sob" ||
grep -i -q "<$aE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$an[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$aN[[:space:]]*<" <<<"$sob" ||
am=true
grep -i -q "<$ce>" <<<"$sob" ||
grep -i -q "<$cE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cn[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cN[[:space:]]*<" <<<"$sob" ||
cm=true
if "$am" || "$cm"; then
printf "Commit %s\n" "$c"
"$am" && printf "\tauthor SOB missing\n"
"$cm" && printf "\tcommitter SOB missing\n"
printf "%s %s\n%s\n" "$ae" "$ce" "$sob"
fi
done
exec gitk "$@"
-------------------------------------------------------------
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-06-01 15:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 11:36 linux-next: Signed-off-by missing for commit in the drivers-x86 tree Stephen Rothwell
2018-06-01 11:40 ` Andy Shevchenko
2018-06-01 12:08 ` Stephen Rothwell
2018-06-01 14:33 ` dvhart
2018-06-01 14:55 ` Andy Shevchenko
2018-06-01 14:38 ` dvhart
2018-06-01 15:26 ` Stephen Rothwell [this message]
2018-06-01 16:43 ` Darren Hart
2018-06-01 14:45 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2023-06-07 23:15 Stephen Rothwell
2023-06-08 9:02 ` Hans de Goede
2023-02-02 21:33 Stephen Rothwell
2023-02-03 9:06 ` Hans de Goede
2021-04-14 13:51 Stephen Rothwell
2021-04-14 13:55 ` Hans de Goede
2021-04-08 12:13 Stephen Rothwell
2021-04-08 14:18 ` Hans de Goede
2019-05-06 13:22 Stephen Rothwell
2019-05-06 14:50 ` Andy Shevchenko
2019-02-23 14:19 Stephen Rothwell
2019-02-23 17:10 ` Darren Hart
2019-02-23 17:52 ` Darren Hart
2019-02-23 22:56 ` Stephen Rothwell
2018-08-18 14:35 Stephen Rothwell
2018-08-19 8:21 ` Hans de Goede
2018-08-19 8:48 ` Stephen Rothwell
2017-08-02 20:37 Stephen Rothwell
2017-08-02 23:57 ` Darren Hart
2017-08-03 0:28 ` Stephen Rothwell
2017-08-03 1:06 ` Linus Torvalds
2017-08-03 15:50 ` Darren Hart
2017-08-05 21:58 ` Darren Hart
2017-08-16 23:21 ` Darren Hart
2017-08-24 20:56 ` Darren Hart
2017-08-04 17:44 ` Junio C Hamano
2017-08-04 17:47 ` Darren Hart
2017-08-03 8:17 ` Andy Shevchenko
2017-08-03 9:27 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180602012646.2a0801e8@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=yukx00@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).