* linux-next: build warning after merge of the fsi tree
@ 2018-07-24 6:03 Stephen Rothwell
2018-07-24 6:39 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2018-07-24 6:03 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 2142 bytes --]
Hi Benjamin,
After merging the fsi tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
In file included from include/linux/printk.h:336:0,
from include/linux/kernel.h:14,
from include/linux/delay.h:22,
from drivers/fsi/fsi-master-ast-cf.c:8:
drivers/fsi/fsi-master-ast-cf.c: In function 'fsi_master_acf_read':
drivers/fsi/fsi-master-ast-cf.c:609:23: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'size_t {aka long unsigned int}' [-Wformat=]
dev_dbg(master->dev, "read id %d addr %x size %ud\n", id, addr, size);
^
include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
__dynamic_dev_dbg(&descriptor, dev, fmt, \
^~~
include/linux/device.h:1428:23: note: in expansion of macro 'dev_fmt'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~
drivers/fsi/fsi-master-ast-cf.c:609:2: note: in expansion of macro 'dev_dbg'
dev_dbg(master->dev, "read id %d addr %x size %ud\n", id, addr, size);
^~~~~~~
drivers/fsi/fsi-master-ast-cf.c: In function 'fsi_master_acf_write':
drivers/fsi/fsi-master-ast-cf.c:634:23: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'size_t {aka long unsigned int}' [-Wformat=]
dev_dbg(master->dev, "write id %d addr %x size %ud raw_data: %08x\n",
^
include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
__dynamic_dev_dbg(&descriptor, dev, fmt, \
^~~
include/linux/device.h:1428:23: note: in expansion of macro 'dev_fmt'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~
drivers/fsi/fsi-master-ast-cf.c:634:2: note: in expansion of macro 'dev_dbg'
dev_dbg(master->dev, "write id %d addr %x size %ud raw_data: %08x\n",
^~~~~~~
Introduced by commit
6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: build warning after merge of the fsi tree
2018-07-24 6:03 linux-next: build warning after merge of the fsi tree Stephen Rothwell
@ 2018-07-24 6:39 ` Benjamin Herrenschmidt
2018-07-24 8:05 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2018-07-24 6:39 UTC (permalink / raw)
To: Stephen Rothwell, gregkh
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
On Tue, 2018-07-24 at 16:03 +1000, Stephen Rothwell wrote:
> Hi Benjamin,
>
> After merging the fsi tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
Ah thanks. It's a pair of missing "z" qualifiers in those dev_dbg.
This normally won't show as this driver can only be enabled on 32-bit
ARM, but COMPILE_TEST will allow you to build it on x86_64 thus
triggering the warning.
I've pushed a fix in the fsi tree.
Greg, do you want a new signed tag with the fix or that can wait
for my next pull request ? I have a last bunch of chardev conversions
and object lifetime fixes being reviewed that I was thinking of sending
later this week.
Cheers,
Ben.
>
> In file included from include/linux/printk.h:336:0,
> from include/linux/kernel.h:14,
> from include/linux/delay.h:22,
> from drivers/fsi/fsi-master-ast-cf.c:8:
> drivers/fsi/fsi-master-ast-cf.c: In function 'fsi_master_acf_read':
> drivers/fsi/fsi-master-ast-cf.c:609:23: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'size_t {aka long unsigned int}' [-Wformat=]
> dev_dbg(master->dev, "read id %d addr %x size %ud\n", id, addr, size);
> ^
> include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
> __dynamic_dev_dbg(&descriptor, dev, fmt, \
> ^~~
> include/linux/device.h:1428:23: note: in expansion of macro 'dev_fmt'
> dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~
> drivers/fsi/fsi-master-ast-cf.c:609:2: note: in expansion of macro 'dev_dbg'
> dev_dbg(master->dev, "read id %d addr %x size %ud\n", id, addr, size);
> ^~~~~~~
> drivers/fsi/fsi-master-ast-cf.c: In function 'fsi_master_acf_write':
> drivers/fsi/fsi-master-ast-cf.c:634:23: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'size_t {aka long unsigned int}' [-Wformat=]
> dev_dbg(master->dev, "write id %d addr %x size %ud raw_data: %08x\n",
> ^
> include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
> __dynamic_dev_dbg(&descriptor, dev, fmt, \
> ^~~
> include/linux/device.h:1428:23: note: in expansion of macro 'dev_fmt'
> dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~
> drivers/fsi/fsi-master-ast-cf.c:634:2: note: in expansion of macro 'dev_dbg'
> dev_dbg(master->dev, "write id %d addr %x size %ud raw_data: %08x\n",
> ^~~~~~~
>
> Introduced by commit
>
> 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: build warning after merge of the fsi tree
2018-07-24 6:39 ` Benjamin Herrenschmidt
@ 2018-07-24 8:05 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2018-07-24 8:05 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Stephen Rothwell, Linux-Next Mailing List, Linux Kernel Mailing List
On Tue, Jul 24, 2018 at 04:39:19PM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2018-07-24 at 16:03 +1000, Stephen Rothwell wrote:
> > Hi Benjamin,
> >
> > After merging the fsi tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
>
> Ah thanks. It's a pair of missing "z" qualifiers in those dev_dbg.
>
> This normally won't show as this driver can only be enabled on 32-bit
> ARM, but COMPILE_TEST will allow you to build it on x86_64 thus
> triggering the warning.
>
> I've pushed a fix in the fsi tree.
>
> Greg, do you want a new signed tag with the fix or that can wait
> for my next pull request ? I have a last bunch of chardev conversions
> and object lifetime fixes being reviewed that I was thinking of sending
> later this week.
Later this week is fine.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-24 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-24 6:03 linux-next: build warning after merge of the fsi tree Stephen Rothwell
2018-07-24 6:39 ` Benjamin Herrenschmidt
2018-07-24 8:05 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).