Linux-Next Archive on
 help / color / Atom feed
From: Sebastian Andrzej Siewior <>
To: Stephen Rothwell <>
Cc: Greg KH <>,
	Linux-Next Mailing List <>,
	Linux Kernel Mailing List <>
Subject: [PATCH] usb: core: remove flags variable in __usb_hcd_giveback_urb()
Date: Tue, 11 Sep 2018 09:37:12 +0200
Message-ID: <> (raw)
In-Reply-To: <>

In commit ed194d1367698 ("usb: core: remove local_irq_save() around
->complete() handler") I removed the only user of the flags variable and
forgot to remove the variable, leading to warning because it is unused
Remove the unused variable.

Fixes: ed194d1367698 ("usb: core: remove local_irq_save() around
       ->complete() handler")
Reported-by: Stephen Rothwell <>
Signed-off-by: Sebastian Andrzej Siewior <>
 drivers/usb/core/hcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index f985d2303095c..487025d31d44c 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1738,7 +1738,6 @@ static void __usb_hcd_giveback_urb(struct urb *urb)
 	struct usb_hcd *hcd = bus_to_hcd(urb->dev->bus);
 	struct usb_anchor *anchor = urb->anchor;
 	int status = urb->unlinked;
-	unsigned long flags;
 	urb->hcpriv = NULL;
 	if (unlikely((urb->transfer_flags & URB_SHORT_NOT_OK) &&

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11  2:47 linux-next: build warning after merge of the usb tree Stephen Rothwell
2018-09-11  7:37 ` Sebastian Andrzej Siewior [this message]
2018-09-11  8:12 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on

Archives are clonable:
	git clone --mirror linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ \
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone