* linux-next: build warning after merge of the qcom tree
@ 2018-11-15 23:10 Stephen Rothwell
2018-11-28 21:25 ` Stephen Rothwell
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2018-11-15 23:10 UTC (permalink / raw)
To: Andy Gross
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Stephen Boyd
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
Hi all,
After merging the qcom tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/gpu/drm/msm/adreno/a6xx_gmu.c: In function 'a6xx_gmu_rpmh_arc_votes_init.constprop':
drivers/gpu/drm/msm/adreno/a6xx_gmu.c:943:12: warning: 'pri_count' is used uninitialized in this function [-Wuninitialized]
pri_count >>= 1;
^~~
drivers/gpu/drm/msm/adreno/a6xx_gmu.c:948:12: warning: 'sec_count' may be used uninitialized in this function [-Wmaybe-uninitialized]
sec_count >>= 1;
^~~
Introduced by commit
ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()")
# CONFIG_QCOM_COMMAND_DB is not set
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the qcom tree
2018-11-15 23:10 linux-next: build warning after merge of the qcom tree Stephen Rothwell
@ 2018-11-28 21:25 ` Stephen Rothwell
2018-11-29 16:30 ` Stephen Boyd
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2018-11-28 21:25 UTC (permalink / raw)
To: Andy Gross
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Stephen Boyd
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Hi all,
On Fri, 16 Nov 2018 10:10:59 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the qcom tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c: In function 'a6xx_gmu_rpmh_arc_votes_init.constprop':
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c:943:12: warning: 'pri_count' is used uninitialized in this function [-Wuninitialized]
> pri_count >>= 1;
> ^~~
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c:948:12: warning: 'sec_count' may be used uninitialized in this function [-Wmaybe-uninitialized]
> sec_count >>= 1;
> ^~~
>
> Introduced by commit
>
> ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()")
>
> # CONFIG_QCOM_COMMAND_DB is not set
I am still getting these warnings.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the qcom tree
2018-11-28 21:25 ` Stephen Rothwell
@ 2018-11-29 16:30 ` Stephen Boyd
2018-11-30 4:13 ` Stephen Rothwell
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Boyd @ 2018-11-29 16:30 UTC (permalink / raw)
To: Andy Gross, Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Quoting Stephen Rothwell (2018-11-28 13:25:40)
> Hi all,
>
> On Fri, 16 Nov 2018 10:10:59 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the qcom tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/gpu/drm/msm/adreno/a6xx_gmu.c: In function 'a6xx_gmu_rpmh_arc_votes_init.constprop':
> > drivers/gpu/drm/msm/adreno/a6xx_gmu.c:943:12: warning: 'pri_count' is used uninitialized in this function [-Wuninitialized]
> > pri_count >>= 1;
> > ^~~
> > drivers/gpu/drm/msm/adreno/a6xx_gmu.c:948:12: warning: 'sec_count' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > sec_count >>= 1;
> > ^~~
> >
> > Introduced by commit
> >
> > ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()")
> >
> > # CONFIG_QCOM_COMMAND_DB is not set
>
> I am still getting these warnings.
>
Andy's email isn't at codeaurora.org anymore. Not sure if that matters
but he may be missing this.
Either way, thanks for the report. Fix coming shortly.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the qcom tree
2018-11-29 16:30 ` Stephen Boyd
@ 2018-11-30 4:13 ` Stephen Rothwell
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2018-11-30 4:13 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Linux-Next Mailing List, Linux Kernel Mailing List,
Andy Gross
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
Hi Stephen,
On Thu, 29 Nov 2018 08:30:48 -0800 Stephen Boyd <swboyd@chromium.org> wrote:
>
> Andy's email isn't at codeaurora.org anymore. Not sure if that matters
> but he may be missing this.
I have updated my contacts list, thanks.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the qcom tree
2021-10-24 23:40 ` David Heidelberg
@ 2021-10-25 2:24 ` Bjorn Andersson
0 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2021-10-25 2:24 UTC (permalink / raw)
To: David Heidelberg
Cc: Stephen Rothwell, Andy Gross, Linux Kernel Mailing List,
Linux Next Mailing List
On Sun 24 Oct 18:40 CDT 2021, David Heidelberg wrote:
> Hello,
>
> I believe patch "ARM: dts: qcom: fix typo in IPQ8064 thermal-sensor node"
> should solve it [1] (sent 4 days ago, not merged yet thou).
>
> David
> [1] https://lists.sr.ht/~okias/devicetree/patches/25837
>
> Best regards
> David Heidelberg
>
Thank you, I had indeed missed that. It's now picked up.
Regards,
Bjorn
> On Mon, Oct 25 2021 at 10:28:02 +1100, Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > Hi all,
> >
> > After merging the qcom tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:52.19-70.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor0-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:72.19-90.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor1-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:92.19-110.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor2-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:112.19-130.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor3-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:132.19-150.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor4-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:152.19-170.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor5-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:172.19-190.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor6-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:192.19-210.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor7-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:212.19-230.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor8-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:232.19-250.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor9-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:252.20-270.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor10-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:52.19-70.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor0-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:72.19-90.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor1-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:92.19-110.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor2-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:112.19-130.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor3-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:132.19-150.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor4-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:152.19-170.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor5-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:172.19-190.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor6-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:192.19-210.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor7-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:212.19-230.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor8-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:232.19-250.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor9-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> > arch/arm/boot/dts/qcom-ipq8064.dtsi:252.20-270.5: Warning
> > (thermal_sensors_property): /thermal-zones/sensor10-thermal: Missing
> > property '#thermal-sensor-cells' in node
> > /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> > (referred from thermal-sensors[0])
> >
> > Presumably introduced by commit
> >
> > 88542b1d37dc ("ARM: dts: qcom: fix thermal zones naming")
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the qcom tree
2021-10-24 23:28 Stephen Rothwell
@ 2021-10-24 23:40 ` David Heidelberg
2021-10-25 2:24 ` Bjorn Andersson
0 siblings, 1 reply; 11+ messages in thread
From: David Heidelberg @ 2021-10-24 23:40 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Andy Gross, Bjorn Andersson, Linux Kernel Mailing List,
Linux Next Mailing List
Hello,
I believe patch "ARM: dts: qcom: fix typo in IPQ8064 thermal-sensor
node" should solve it [1] (sent 4 days ago, not merged yet thou).
David
[1] https://lists.sr.ht/~okias/devicetree/patches/25837
Best regards
David Heidelberg
On Mon, Oct 25 2021 at 10:28:02 +1100, Stephen Rothwell
<sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the qcom tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> arch/arm/boot/dts/qcom-ipq8064.dtsi:52.19-70.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor0-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:72.19-90.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor1-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:92.19-110.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor2-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:112.19-130.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor3-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:132.19-150.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor4-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:152.19-170.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor5-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:172.19-190.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor6-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:192.19-210.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor7-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:212.19-230.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor8-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:232.19-250.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor9-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:252.20-270.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor10-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:52.19-70.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor0-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:72.19-90.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor1-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:92.19-110.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor2-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:112.19-130.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor3-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:132.19-150.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor4-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:152.19-170.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor5-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:172.19-190.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor6-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:192.19-210.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor7-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:212.19-230.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor8-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:232.19-250.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor9-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
> arch/arm/boot/dts/qcom-ipq8064.dtsi:252.20-270.5: Warning
> (thermal_sensors_property): /thermal-zones/sensor10-thermal: Missing
> property '#thermal-sensor-cells' in node
> /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle
> (referred from thermal-sensors[0])
>
> Presumably introduced by commit
>
> 88542b1d37dc ("ARM: dts: qcom: fix thermal zones naming")
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the qcom tree
@ 2021-10-24 23:28 Stephen Rothwell
2021-10-24 23:40 ` David Heidelberg
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2021-10-24 23:28 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, David Heidelberg, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 6159 bytes --]
Hi all,
After merging the qcom tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
arch/arm/boot/dts/qcom-ipq8064.dtsi:52.19-70.5: Warning (thermal_sensors_property): /thermal-zones/sensor0-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:72.19-90.5: Warning (thermal_sensors_property): /thermal-zones/sensor1-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:92.19-110.5: Warning (thermal_sensors_property): /thermal-zones/sensor2-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:112.19-130.5: Warning (thermal_sensors_property): /thermal-zones/sensor3-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:132.19-150.5: Warning (thermal_sensors_property): /thermal-zones/sensor4-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:152.19-170.5: Warning (thermal_sensors_property): /thermal-zones/sensor5-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:172.19-190.5: Warning (thermal_sensors_property): /thermal-zones/sensor6-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:192.19-210.5: Warning (thermal_sensors_property): /thermal-zones/sensor7-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:212.19-230.5: Warning (thermal_sensors_property): /thermal-zones/sensor8-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:232.19-250.5: Warning (thermal_sensors_property): /thermal-zones/sensor9-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:252.20-270.5: Warning (thermal_sensors_property): /thermal-zones/sensor10-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:52.19-70.5: Warning (thermal_sensors_property): /thermal-zones/sensor0-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:72.19-90.5: Warning (thermal_sensors_property): /thermal-zones/sensor1-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:92.19-110.5: Warning (thermal_sensors_property): /thermal-zones/sensor2-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:112.19-130.5: Warning (thermal_sensors_property): /thermal-zones/sensor3-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:132.19-150.5: Warning (thermal_sensors_property): /thermal-zones/sensor4-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:152.19-170.5: Warning (thermal_sensors_property): /thermal-zones/sensor5-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:172.19-190.5: Warning (thermal_sensors_property): /thermal-zones/sensor6-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:192.19-210.5: Warning (thermal_sensors_property): /thermal-zones/sensor7-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:212.19-230.5: Warning (thermal_sensors_property): /thermal-zones/sensor8-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:232.19-250.5: Warning (thermal_sensors_property): /thermal-zones/sensor9-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
arch/arm/boot/dts/qcom-ipq8064.dtsi:252.20-270.5: Warning (thermal_sensors_property): /thermal-zones/sensor10-thermal: Missing property '#thermal-sensor-cells' in node /soc/clock-controller@900000/thermal-sensor@900000 or bad phandle (referred from thermal-sensors[0])
Presumably introduced by commit
88542b1d37dc ("ARM: dts: qcom: fix thermal zones naming")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the qcom tree
2020-04-15 4:51 ` Stephen Boyd
@ 2020-04-15 5:04 ` Bjorn Andersson
0 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2020-04-15 5:04 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List
On Tue 14 Apr 21:51 PDT 2020, Stephen Boyd wrote:
> Quoting Stephen Rothwell (2020-04-14 17:25:34)
> > Hi all,
> >
> > After merging the qcom tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/soc/qcom/cmd-db.c: In function 'cmd_db_debugfs_dump':
> > drivers/soc/qcom/cmd-db.c:281:30: warning: field width specifier '*' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
> > 281 | seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
> > | ~^~
> > | |
> > | int
> > 282 | sizeof(ent->id), ent->id);
> > | ~~~~~~~~~~~~~~~
> > | |
> > | long unsigned int
> >
> > Introduced by commit
> >
> > d6815c5c43d4 ("soc: qcom: cmd-db: Add debugfs dumping file")
>
> Thanks. I didn't notice this warning. Looks like we need to cast
> sizeof() to int? Bjorn do you want another patch or does this get
> squashed in?
>
It's in the middle of the patch stack, so I would prefer an additional
patch.
Regards,
Bjorn
> ---8<----
> diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
> index 6c308f92a13c..6b5c440c9dc3 100644
> --- a/drivers/soc/qcom/cmd-db.c
> +++ b/drivers/soc/qcom/cmd-db.c
> @@ -280,7 +280,7 @@ static int cmd_db_debugfs_dump(struct seq_file *seq, void *p)
> ent = rsc_to_entry_header(rsc);
> for (j = 0; j < le16_to_cpu(rsc->cnt); j++, ent++) {
> seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
> - sizeof(ent->id), ent->id);
> + (int)sizeof(ent->id), ent->id);
>
> len = le16_to_cpu(ent->len);
> if (len) {
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build warning after merge of the qcom tree
2020-04-15 0:25 Stephen Rothwell
@ 2020-04-15 4:51 ` Stephen Boyd
2020-04-15 5:04 ` Bjorn Andersson
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Boyd @ 2020-04-15 4:51 UTC (permalink / raw)
To: Andy Gross, Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Bjorn Andersson
Quoting Stephen Rothwell (2020-04-14 17:25:34)
> Hi all,
>
> After merging the qcom tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/soc/qcom/cmd-db.c: In function 'cmd_db_debugfs_dump':
> drivers/soc/qcom/cmd-db.c:281:30: warning: field width specifier '*' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
> 281 | seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
> | ~^~
> | |
> | int
> 282 | sizeof(ent->id), ent->id);
> | ~~~~~~~~~~~~~~~
> | |
> | long unsigned int
>
> Introduced by commit
>
> d6815c5c43d4 ("soc: qcom: cmd-db: Add debugfs dumping file")
Thanks. I didn't notice this warning. Looks like we need to cast
sizeof() to int? Bjorn do you want another patch or does this get
squashed in?
---8<----
diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
index 6c308f92a13c..6b5c440c9dc3 100644
--- a/drivers/soc/qcom/cmd-db.c
+++ b/drivers/soc/qcom/cmd-db.c
@@ -280,7 +280,7 @@ static int cmd_db_debugfs_dump(struct seq_file *seq, void *p)
ent = rsc_to_entry_header(rsc);
for (j = 0; j < le16_to_cpu(rsc->cnt); j++, ent++) {
seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
- sizeof(ent->id), ent->id);
+ (int)sizeof(ent->id), ent->id);
len = le16_to_cpu(ent->len);
if (len) {
^ permalink raw reply related [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the qcom tree
@ 2020-04-15 0:25 Stephen Rothwell
2020-04-15 4:51 ` Stephen Boyd
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2020-04-15 0:25 UTC (permalink / raw)
To: Andy Gross
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Stephen Boyd,
Bjorn Andersson
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
Hi all,
After merging the qcom tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/soc/qcom/cmd-db.c: In function 'cmd_db_debugfs_dump':
drivers/soc/qcom/cmd-db.c:281:30: warning: field width specifier '*' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
281 | seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
| ~^~
| |
| int
282 | sizeof(ent->id), ent->id);
| ~~~~~~~~~~~~~~~
| |
| long unsigned int
Introduced by commit
d6815c5c43d4 ("soc: qcom: cmd-db: Add debugfs dumping file")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build warning after merge of the qcom tree
@ 2019-08-07 0:08 Stephen Rothwell
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2019-08-07 0:08 UTC (permalink / raw)
To: Andy Gross
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Vaishali Thakkar, Bjorn Andersson, Vinod Koul,
Gustavo A. R. Silva, Kees Cook
[-- Attachment #1: Type: text/plain, Size: 3882 bytes --]
Hi all,
After merging the qcom tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/soc/qcom/socinfo.c: In function 'socinfo_debugfs_init':
drivers/soc/qcom/socinfo.c:323:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_x32("raw_device_number", 0400,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root,
~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.raw_device_num);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:326:2: note: here
case SOCINFO_VERSION(0, 11):
^~~~
drivers/soc/qcom/socinfo.c:331:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("foundry_id", 0400, qcom_socinfo->dbg_root,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.foundry_id);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:333:2: note: here
case SOCINFO_VERSION(0, 8):
^~~~
drivers/soc/qcom/socinfo.c:231:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_file(__stringify(name), 0400, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root, \
~~~~~~~~~~~~~~~~~~~~~~~~~~~
info, &qcom_ ##name## _ops)
~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:336:3: note: in expansion of macro 'DEBUGFS_ADD'
DEBUGFS_ADD(info, pmic_die_rev);
^~~~~~~~~~~
drivers/soc/qcom/socinfo.c:337:2: note: here
case SOCINFO_VERSION(0, 6):
^~~~
drivers/soc/qcom/socinfo.c:341:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("hardware_platform_subtype", 0400,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root,
~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.hw_plat_subtype);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:344:2: note: here
case SOCINFO_VERSION(0, 5):
^~~~
drivers/soc/qcom/socinfo.c:348:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("accessory_chip", 0400,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root,
~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.accessory_chip);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:351:2: note: here
case SOCINFO_VERSION(0, 4):
^~~~
drivers/soc/qcom/socinfo.c:354:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("platform_version", 0400,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root,
~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.plat_ver);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:357:2: note: here
case SOCINFO_VERSION(0, 3):
^~~~
drivers/soc/qcom/socinfo.c:360:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("hardware_platform", 0400,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
qcom_socinfo->dbg_root,
~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.hw_plat);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:363:2: note: here
case SOCINFO_VERSION(0, 2):
^~~~
drivers/soc/qcom/socinfo.c:366:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
debugfs_create_u32("raw_version", 0400, qcom_socinfo->dbg_root,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
&qcom_socinfo->info.raw_ver);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/socinfo.c:368:2: note: here
case SOCINFO_VERSION(0, 1):
^~~~
Introduced by commit
9c84c1e78634 ("soc: qcom: socinfo: Expose custom attributes")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-10-25 2:24 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 23:10 linux-next: build warning after merge of the qcom tree Stephen Rothwell
2018-11-28 21:25 ` Stephen Rothwell
2018-11-29 16:30 ` Stephen Boyd
2018-11-30 4:13 ` Stephen Rothwell
2019-08-07 0:08 Stephen Rothwell
2020-04-15 0:25 Stephen Rothwell
2020-04-15 4:51 ` Stephen Boyd
2020-04-15 5:04 ` Bjorn Andersson
2021-10-24 23:28 Stephen Rothwell
2021-10-24 23:40 ` David Heidelberg
2021-10-25 2:24 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).