From: Heiko Carstens <heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
To: Rafael Aquini <aquini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"Dmitry V. Levin" <ldv-u2l5PoMzF/Vg9hUCZPvPmw@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
strace-devel-3+4lAyCyj6AWlMsSdNXQLw@public.gmane.org,
William Kucharski
<william.kucharski-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: [-next] rename of VM_NR_PDFLUSH_THREADS breaks strace compilation
Date: Fri, 7 Dec 2018 08:58:07 +0100 [thread overview]
Message-ID: <20181207075807.GA9030@osiris> (raw)
Hi Rafael,
your patch 77cab92a2cb1 ("sysctl: clean up nr_pdflush_threads
leftover") in linux-next breaks strace compilation if used with kernel
headers from linux-next.
This:
--- a/include/uapi/linux/sysctl.h
+++ b/include/uapi/linux/sysctl.h
[...]
- VM_NR_PDFLUSH_THREADS=15, /* nr_pdflush_threads */
+ VM_UNUSED15=15, /* was: int: nr_pdflush_threads */
causes this when trying to build strace:
+ ./bootstrap
configure.ac:54: installing './compile'
configure.ac:47: installing './config.guess'
configure.ac:47: installing './config.sub'
configure.ac:45: installing './install-sh'
configure.ac:45: installing './missing'
Makefile.am: installing './depcomp'
Makefile.am:975: warning: variable 'ioctlsort_LDFLAGS' is defined but no program or
Makefile.am:975: library has 'ioctlsort' as canonical name (possible typo)
parallel-tests: installing './test-driver'
+ ./configure
++ nproc
+ make -j 10
In file included from defs.h:308,
from sysctl.c:31:
xlat/sysctl_vm.h:23:7: error: ‘VM_NR_PDFLUSH_THREADS’ undeclared here (not in a function)
XLAT(VM_NR_PDFLUSH_THREADS),
^~~~~~~~~~~~~~~~~~~~~
xlat.h:49:35: note: in definition of macro ‘XLAT’
# define XLAT(val) { (unsigned)(val), #val }
^~~
--
Strace-devel mailing list
Strace-devel@lists.strace.io
https://lists.strace.io/mailman/listinfo/strace-devel
next reply other threads:[~2018-12-07 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 7:58 Heiko Carstens [this message]
2018-12-07 10:53 ` [-next] rename of VM_NR_PDFLUSH_THREADS breaks strace compilation Rafael Aquini
2018-12-07 11:01 ` Heiko Carstens
2018-12-07 11:16 ` Rafael Aquini
2018-12-07 11:54 ` Greg Kroah-Hartman
[not found] ` <20181207115412.GA15336-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2018-12-07 12:17 ` Rafael Aquini
2018-12-07 12:51 ` Rafael Aquini
2018-12-07 14:51 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207075807.GA9030@osiris \
--to=heiko.carstens-ta70fqpds9bqt0dzr+alfa@public.gmane.org \
--cc=aquini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ldv-u2l5PoMzF/Vg9hUCZPvPmw@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=strace-devel-3+4lAyCyj6AWlMsSdNXQLw@public.gmane.org \
--cc=william.kucharski-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).