From: Heiko Carstens <heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
To: Rafael Aquini <aquini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"Dmitry V. Levin" <ldv-u2l5PoMzF/Vg9hUCZPvPmw@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
strace-devel-3+4lAyCyj6AWlMsSdNXQLw@public.gmane.org,
William Kucharski
<william.kucharski-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: Re: [-next] rename of VM_NR_PDFLUSH_THREADS breaks strace compilation
Date: Fri, 7 Dec 2018 12:01:46 +0100 [thread overview]
Message-ID: <20181207110146.GD9030@osiris> (raw)
In-Reply-To: <20181207105312.GA11365@xps>
On Fri, Dec 07, 2018 at 05:53:13AM -0500, Rafael Aquini wrote:
> On Fri, Dec 07, 2018 at 08:58:07AM +0100, Heiko Carstens wrote:
> > Hi Rafael,
> >
> > your patch 77cab92a2cb1 ("sysctl: clean up nr_pdflush_threads
> > leftover") in linux-next breaks strace compilation if used with kernel
> > headers from linux-next.
> > - VM_NR_PDFLUSH_THREADS=15, /* nr_pdflush_threads */
> > + VM_UNUSED15=15, /* was: int: nr_pdflush_threads */
> The nr_pdflush_threads (VM_NR_PDFLUSH_THREADS) tunable has been obsolete since 2.6.32
> and it was, excepting by the bit in the referred patch, completely removed on 4.15.
>
> I think you just need to patch strace source with the following hunk, in
> order to reflect the removal. Would you mind checking it?
>
> diff --git a/xlat/sysctl_vm.in b/xlat/sysctl_vm.in
> index 3c2b4739..30784c2a 100644
> --- a/xlat/sysctl_vm.in
> +++ b/xlat/sysctl_vm.in
> @@ -5,7 +5,6 @@ VM_DIRTY_BACKGROUND
> VM_DIRTY_RATIO
> VM_DIRTY_WB_CS
> VM_DIRTY_EXPIRE_CS
> -VM_NR_PDFLUSH_THREADS
> VM_OVERCOMMIT_RATIO
> VM_PAGEBUF
> VM_HUGETLB_PAGES
I'll leave that up to Dmitry to decide what to do here. At least it
won't be possible to compile old strace versions with new kernel
headers if the kernel change gets merged upstream.
--
Strace-devel mailing list
Strace-devel-3+4lAyCyj6AWlMsSdNXQLw@public.gmane.org
https://lists.strace.io/mailman/listinfo/strace-devel
next prev parent reply other threads:[~2018-12-07 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 7:58 [-next] rename of VM_NR_PDFLUSH_THREADS breaks strace compilation Heiko Carstens
2018-12-07 10:53 ` Rafael Aquini
2018-12-07 11:01 ` Heiko Carstens [this message]
2018-12-07 11:16 ` Rafael Aquini
2018-12-07 11:54 ` Greg Kroah-Hartman
[not found] ` <20181207115412.GA15336-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2018-12-07 12:17 ` Rafael Aquini
2018-12-07 12:51 ` Rafael Aquini
2018-12-07 14:51 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207110146.GD9030@osiris \
--to=heiko.carstens-ta70fqpds9bqt0dzr+alfa@public.gmane.org \
--cc=aquini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ldv-u2l5PoMzF/Vg9hUCZPvPmw@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=strace-devel-3+4lAyCyj6AWlMsSdNXQLw@public.gmane.org \
--cc=william.kucharski-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).