linux-next: Signed-off-by missing for commit in the sound-asoc tree

linux-next: Signed-off-by missing for commit in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

Hi all,

Commit

  972fd1f58267 ("ASoC: max9867: Remove useless assignment")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH v2] ASoC: max9867: Remove useless assignment

[Ladislav Michl]

ret is assigned later, no need to initialize it.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 CHANGES:
 -v2: add missing Signed-off-by
 (I'm sorry for that...)

 sound/soc/codecs/max9867.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c
index 1cda54b59854..1b155f40b106 100644
--- a/sound/soc/codecs/max9867.c
+++ b/sound/soc/codecs/max9867.c
@@ -476,7 +476,7 @@ static int max9867_i2c_probe(struct i2c_client *i2c,
 		const struct i2c_device_id *id)
 {
 	struct max9867_priv *max9867;
-	int ret = 0, reg;
+	int ret, reg;
 
 	max9867 = devm_kzalloc(&i2c->dev, sizeof(*max9867), GFP_KERNEL);
 	if (!max9867)
@@ -497,10 +497,8 @@ static int max9867_i2c_probe(struct i2c_client *i2c,
 	dev_info(&i2c->dev, "device revision: %x\n", reg);
 	ret = devm_snd_soc_register_component(&i2c->dev, &max9867_component,
 			max9867_dai, ARRAY_SIZE(max9867_dai));
-	if (ret < 0) {
+	if (ret < 0)
 		dev_err(&i2c->dev, "Failed to register component: %d\n", ret);
-		return ret;
-	}
 	return ret;
 }
 
-- 
2.20.0.rc2

Re: linux-next: Signed-off-by missing for commit in the sound-asoc tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

On Fri, Aug 09, 2019 at 07:43:25AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   c42d8cbee4c7 ("Merge branches from Takashi to ease Skylake development.")
> 
> is missing a Signed-off-by from its author and committer.
> 
> Despite what the commit message says, this is not a merge commit.

Rebuilt the merges now.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the sound-asoc tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

On Fri, Aug 09, 2019 at 07:43:25AM +1000, Stephen Rothwell wrote:

> Commit

>   c42d8cbee4c7 ("Merge branches from Takashi to ease Skylake development.")

> is missing a Signed-off-by from its author and committer.

> Despite what the commit message says, this is not a merge commit.

Ugh, that's a git bug - there was a conflict resolution and rather when
I resolved it it seems to have completely thrown away the fact that
there was a merge.  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

Hi all,

Commit

  c42d8cbee4c7 ("Merge branches from Takashi to ease Skylake development.")

is missing a Signed-off-by from its author and committer.

Despite what the commit message says, this is not a merge commit.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the sound-asoc tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

On Mon, Mar 19, 2018 at 07:12:44PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   b9f6c09ae07c ("ASoC: ssm2602: Replace reg_default_raw with reg_default")

Dropped.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

Hi all,

Commit

  b9f6c09ae07c ("ASoC: ssm2602: Replace reg_default_raw with reg_default")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]