* Re: next-20181211 build: 1 failures 32 warnings (next-20181211) [not found] <E1gWnrV-00086U-3m@optimist> @ 2018-12-11 22:06 ` Mark Brown 2018-12-11 22:15 ` Nathan Chancellor 0 siblings, 1 reply; 3+ messages in thread From: Mark Brown @ 2018-12-11 22:06 UTC (permalink / raw) To: Mauro Carvalho Chehab, Daniel Scheller Cc: linaro-kernel, kernel-build-reports, Russell King, linux-next, linux-arm-kernel, linux-media [-- Attachment #1.1: Type: text/plain, Size: 1115 bytes --] On Tue, Dec 11, 2018 at 07:38:33PM +0000, Build bot for Mark Brown wrote: Today's -next fails to build an arm allmodconfig due to: > arm-allmodconfig > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool' > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool' > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool' > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool' in ddbridge-ci.c and some other media files. This is because ddbridge.h includes asm/irq.h but that does not directly include headers which define the above types and it appears some header changes have removed an implicit inclusion of those. Moving the asm includes after the linux ones in ddbridge.h fixes this though this appears to be against the coding style for media. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: next-20181211 build: 1 failures 32 warnings (next-20181211) 2018-12-11 22:06 ` next-20181211 build: 1 failures 32 warnings (next-20181211) Mark Brown @ 2018-12-11 22:15 ` Nathan Chancellor 2018-12-12 12:18 ` Mark Brown 0 siblings, 1 reply; 3+ messages in thread From: Nathan Chancellor @ 2018-12-11 22:15 UTC (permalink / raw) To: Mark Brown Cc: linaro-kernel, kernel-build-reports, Russell King, linux-next, Mauro Carvalho Chehab, Daniel Scheller, linux-arm-kernel, linux-media On Tue, Dec 11, 2018 at 10:06:20PM +0000, Mark Brown wrote: > On Tue, Dec 11, 2018 at 07:38:33PM +0000, Build bot for Mark Brown wrote: > > Today's -next fails to build an arm allmodconfig due to: > > > arm-allmodconfig > > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' > > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool' > > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' > > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool' > > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' > > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool' > > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' > > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool' > > in ddbridge-ci.c and some other media files. This is because > ddbridge.h includes asm/irq.h but that does not directly include headers > which define the above types and it appears some header changes have > removed an implicit inclusion of those. Moving the asm includes after > the linux ones in ddbridge.h fixes this though this appears to be > against the coding style for media. Hi Mark, I sent a patch for this yesterday, I think moving the asm includes after the linux ones is the correct fix according to the rest of the kernel: https://lore.kernel.org/linux-media/20181210233514.3069-1-natechancellor@gmail.com/ Hopefully it can be picked up quickly. Thanks, Nathan ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: next-20181211 build: 1 failures 32 warnings (next-20181211) 2018-12-11 22:15 ` Nathan Chancellor @ 2018-12-12 12:18 ` Mark Brown 0 siblings, 0 replies; 3+ messages in thread From: Mark Brown @ 2018-12-12 12:18 UTC (permalink / raw) To: Nathan Chancellor Cc: linaro-kernel, kernel-build-reports, Russell King, linux-next, Mauro Carvalho Chehab, Daniel Scheller, linux-arm-kernel, linux-media [-- Attachment #1.1: Type: text/plain, Size: 958 bytes --] On Tue, Dec 11, 2018 at 03:15:35PM -0700, Nathan Chancellor wrote: > On Tue, Dec 11, 2018 at 10:06:20PM +0000, Mark Brown wrote: > > in ddbridge-ci.c and some other media files. This is because > > ddbridge.h includes asm/irq.h but that does not directly include headers > > which define the above types and it appears some header changes have > > removed an implicit inclusion of those. Moving the asm includes after > > the linux ones in ddbridge.h fixes this though this appears to be > > against the coding style for media. > I sent a patch for this yesterday, I think moving the asm includes after > the linux ones is the correct fix according to the rest of the kernel: > https://lore.kernel.org/linux-media/20181210233514.3069-1-natechancellor@gmail.com/ > Hopefully it can be picked up quickly. Ah, great - thanks. I agree this is probably the best fix, I just wasn't sure if the media people had some other idea given the coding style there. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-12 12:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1gWnrV-00086U-3m@optimist>
2018-12-11 22:06 ` next-20181211 build: 1 failures 32 warnings (next-20181211) Mark Brown
2018-12-11 22:15 ` Nathan Chancellor
2018-12-12 12:18 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).