* Re: [PATCH v3 7/9] arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO
[not found] ` <20181213064803.kd7p7fzsegu6nhnl@localhost>
@ 2018-12-15 21:44 ` Stefan Wahren
2018-12-17 15:33 ` Horia Geanta
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Wahren @ 2018-12-15 21:44 UTC (permalink / raw)
To: Olof Johansson, Horia Geanta
Cc: Stephen Rothwell, arm-soc, Marc Gonzalez, LKML, linux-next, Linux ARM
Hi,
> Olof Johansson <olof@lixom.net> hat am 13. Dezember 2018 um 07:48 geschrieben:
>
>
> On Fri, Nov 09, 2018 at 06:05:24AM +0000, Horia Geanta wrote:
> > On 11/9/2018 3:11 AM, Marc Gonzalez wrote:
> > > Commit e8342cc7954e ("enable CAAM crypto engine on QorIQ DPAA2 SoCs")
> > > enabled CRYPTO_DEV_FSL_DPAA2_CAAM, which depends on FSL_MC_DPIO,
> > > which is not set. Enable FSL_MC_BUS, and build FSL_MC_DPIO and
> > > CRYPTO_DEV_FSL_DPAA2_CAAM as modules.
> > >
> > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> > Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
>
> I had to redo this one, and when I did I noticed that there's also an ethernet
> driver. Should that be enabled as well?
>
this patch in next-20181214 breaks "make modules_install" for arm64/defconfig on my Ubuntu machine:
DEPMOD 4.20.0-rc6-next-20181214
depmod: ERROR: Found 6 modules in dependency cycles!
depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc
depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio
depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam
depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error
depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc
After reverting of this patch the issue disappeared.
Stefan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 7/9] arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO
2018-12-15 21:44 ` [PATCH v3 7/9] arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO Stefan Wahren
@ 2018-12-17 15:33 ` Horia Geanta
2018-12-18 20:10 ` Stefan Wahren
0 siblings, 1 reply; 6+ messages in thread
From: Horia Geanta @ 2018-12-17 15:33 UTC (permalink / raw)
To: Stefan Wahren, Olof Johansson
Cc: arm-soc, LKML, Linux ARM, Marc Gonzalez, linux-next, Stephen Rothwell
On 12/15/2018 11:44 PM, Stefan Wahren wrote:
> Hi,
>
>> Olof Johansson <olof@lixom.net> hat am 13. Dezember 2018 um 07:48 geschrieben:
>>
>>
>> On Fri, Nov 09, 2018 at 06:05:24AM +0000, Horia Geanta wrote:
>>> On 11/9/2018 3:11 AM, Marc Gonzalez wrote:
>>>> Commit e8342cc7954e ("enable CAAM crypto engine on QorIQ DPAA2 SoCs")
>>>> enabled CRYPTO_DEV_FSL_DPAA2_CAAM, which depends on FSL_MC_DPIO,
>>>> which is not set. Enable FSL_MC_BUS, and build FSL_MC_DPIO and
>>>> CRYPTO_DEV_FSL_DPAA2_CAAM as modules.
>>>>
>>>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
>>> Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
>>
>> I had to redo this one, and when I did I noticed that there's also an ethernet
>> driver. Should that be enabled as well?
>>
>
> this patch in next-20181214 breaks "make modules_install" for arm64/defconfig on my Ubuntu machine:
>
> DEPMOD 4.20.0-rc6-next-20181214
> depmod: ERROR: Found 6 modules in dependency cycles!
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio
> depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc
>
> After reverting of this patch the issue disappeared.
>
Seems there's a dependency cycle b/w dpaa2_caam and caam{alg,hash}_desc, as follows:
A->B
---
dpaa2_caam needs cnstr_* exported by caam{alg,hash}_desc
B->A
---
caam{alg,hash}_desc need caam_imx, caam_little_end:
caam{hash,alg}_desc.c
--> desc_constr.h (included for descriptors generation functions)
--> regs.h (included for endianness helpers)
--> extern bool caam_imx, caam_little_end
caam_imx, caam_little_end are exported by dpaa2_caam - caamalg_qi2.c (when
CONFIG_CRYPTO_DEV_FSL_CAAM=n)
Could we drop this patch, until CAAM driver gets a proper fix (which is not
straightforward)?
Thanks,
Horia
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 7/9] arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO
2018-12-17 15:33 ` Horia Geanta
@ 2018-12-18 20:10 ` Stefan Wahren
2018-12-19 10:18 ` [PATCH] Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO" Horia Geantă
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Wahren @ 2018-12-18 20:10 UTC (permalink / raw)
To: Horia Geanta
Cc: Stephen Rothwell, arm-soc, Marc Gonzalez, LKML, linux-next,
Olof Johansson, Linux ARM
Hi Horia,
> Horia Geanta <horia.geanta@nxp.com> hat am 17. Dezember 2018 um 16:33 geschrieben:
>
>
> On 12/15/2018 11:44 PM, Stefan Wahren wrote:
> > Hi,
> >
> >> Olof Johansson <olof@lixom.net> hat am 13. Dezember 2018 um 07:48 geschrieben:
> >>
> >>
> >> On Fri, Nov 09, 2018 at 06:05:24AM +0000, Horia Geanta wrote:
> >>> On 11/9/2018 3:11 AM, Marc Gonzalez wrote:
> >>>> Commit e8342cc7954e ("enable CAAM crypto engine on QorIQ DPAA2 SoCs")
> >>>> enabled CRYPTO_DEV_FSL_DPAA2_CAAM, which depends on FSL_MC_DPIO,
> >>>> which is not set. Enable FSL_MC_BUS, and build FSL_MC_DPIO and
> >>>> CRYPTO_DEV_FSL_DPAA2_CAAM as modules.
> >>>>
> >>>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> >>> Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
> >>
> >> I had to redo this one, and when I did I noticed that there's also an ethernet
> >> driver. Should that be enabled as well?
> >>
> >
> > this patch in next-20181214 breaks "make modules_install" for arm64/defconfig on my Ubuntu machine:
> >
> > DEPMOD 4.20.0-rc6-next-20181214
> > depmod: ERROR: Found 6 modules in dependency cycles!
> > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc
> > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio
> > depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam
> > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error
> > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc
> >
> > After reverting of this patch the issue disappeared.
> >
> Seems there's a dependency cycle b/w dpaa2_caam and caam{alg,hash}_desc, as follows:
>
> A->B
> ---
> dpaa2_caam needs cnstr_* exported by caam{alg,hash}_desc
>
> B->A
> ---
> caam{alg,hash}_desc need caam_imx, caam_little_end:
> caam{hash,alg}_desc.c
> --> desc_constr.h (included for descriptors generation functions)
> --> regs.h (included for endianness helpers)
> --> extern bool caam_imx, caam_little_end
> caam_imx, caam_little_end are exported by dpaa2_caam - caamalg_qi2.c (when
> CONFIG_CRYPTO_DEV_FSL_CAAM=n)
>
> Could we drop this patch, until CAAM driver gets a proper fix (which is not
> straightforward)?
this issue still persists in 4.20.0-rc7-next-20181218. Could you please send a patch to revert this change?
Thanks Stefan
>
> Thanks,
> Horia
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO"
2018-12-18 20:10 ` Stefan Wahren
@ 2018-12-19 10:18 ` Horia Geantă
2018-12-20 15:27 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Horia Geantă @ 2018-12-19 10:18 UTC (permalink / raw)
To: Olof Johansson, Marc Gonzalez
Cc: arm, linux-arm-kernel, Stefan Wahren, linux-next, linux-kernel, sfr
This reverts commit d9678adbe733a770428a98651beaa2817d503ed3.
Received below report from Stefan.
Revert the commit until CAAM driver dependency cycles are fixed.
this patch in next-20181214 breaks "make modules_install" for
arm64/defconfig on my Ubuntu machine:
DEPMOD 4.20.0-rc6-next-20181214
depmod: ERROR: Found 6 modules in dependency cycles!
depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc
depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio
depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam
depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error
depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc
Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
---
arch/arm64/configs/defconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 989f51bb1bd4..d0724d4e0546 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -200,7 +200,6 @@ CONFIG_DMA_CMA=y
CONFIG_CMA_SIZE_MBYTES=32
CONFIG_HISILICON_LPC=y
CONFIG_SIMPLE_PM_BUS=y
-CONFIG_FSL_MC_BUS=y
CONFIG_MTD=y
CONFIG_MTD_BLOCK=y
CONFIG_MTD_M25P80=y
@@ -644,7 +643,6 @@ CONFIG_RPMSG_QCOM_GLINK_RPM=y
CONFIG_RPMSG_QCOM_GLINK_SMEM=m
CONFIG_RPMSG_QCOM_SMD=y
CONFIG_RASPBERRYPI_POWER=y
-CONFIG_FSL_MC_DPIO=m
CONFIG_QCOM_COMMAND_DB=y
CONFIG_QCOM_GENI_SE=y
CONFIG_QCOM_GLINK_SSR=m
@@ -737,7 +735,6 @@ CONFIG_NLS_ISO8859_1=y
CONFIG_SECURITY=y
CONFIG_CRYPTO_ECHAINIV=y
CONFIG_CRYPTO_ANSI_CPRNG=y
-CONFIG_CRYPTO_DEV_FSL_DPAA2_CAAM=m
CONFIG_PRINTK_TIME=y
CONFIG_DEBUG_INFO=y
CONFIG_DEBUG_FS=y
--
2.16.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO"
2018-12-19 10:18 ` [PATCH] Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO" Horia Geantă
@ 2018-12-20 15:27 ` Arnd Bergmann
2018-12-20 20:43 ` Horia Geanta
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2018-12-20 15:27 UTC (permalink / raw)
To: Horia Geantă
Cc: Olof Johansson, Marc Gonzalez, arm-soc, Linux ARM, Stefan Wahren,
Linux-Next Mailing List, Linux Kernel Mailing List,
Stephen Rothwell
On Wed, Dec 19, 2018 at 11:18 AM Horia Geantă <horia.geanta@nxp.com> wrote:
>
> This reverts commit d9678adbe733a770428a98651beaa2817d503ed3.
>
> Received below report from Stefan.
> Revert the commit until CAAM driver dependency cycles are fixed.
>
> this patch in next-20181214 breaks "make modules_install" for
> arm64/defconfig on my Ubuntu machine:
>
> DEPMOD 4.20.0-rc6-next-20181214
> depmod: ERROR: Found 6 modules in dependency cycles!
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio
> depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error
> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc
>
> Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
I've applied the revert, but I think there is still a problem, since
anyone could manually enable those options and should not
see those cycles in the module dependencies.
Horia, can you have a look at what caused that and how to fix it?
It's probably a commit in the caam drivers. I have also created
a patch to address a problem with that driver but forgot
to send that out, it might fix this one as well, see my follow-up
patch "crypto: caam/qi2 - add a CRYPTO_DEV_FSL_CAAM
dependency".
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO"
2018-12-20 15:27 ` Arnd Bergmann
@ 2018-12-20 20:43 ` Horia Geanta
0 siblings, 0 replies; 6+ messages in thread
From: Horia Geanta @ 2018-12-20 20:43 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Olof Johansson, Marc Gonzalez, arm-soc, Linux ARM, Stefan Wahren,
Linux-Next Mailing List, Linux Kernel Mailing List,
Stephen Rothwell
On 12/20/2018 5:28 PM, Arnd Bergmann wrote:
> On Wed, Dec 19, 2018 at 11:18 AM Horia Geantă <horia.geanta@nxp.com> wrote:
>>
>> This reverts commit d9678adbe733a770428a98651beaa2817d503ed3.
>>
>> Received below report from Stefan.
>> Revert the commit until CAAM driver dependency cycles are fixed.
>>
>> this patch in next-20181214 breaks "make modules_install" for
>> arm64/defconfig on my Ubuntu machine:
>>
>> DEPMOD 4.20.0-rc6-next-20181214
>> depmod: ERROR: Found 6 modules in dependency cycles!
>> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc
>> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio
>> depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam
>> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error
>> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc
>>
>> Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
>> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
>
> I've applied the revert, but I think there is still a problem, since
> anyone could manually enable those options and should not
> see those cycles in the module dependencies.
>
Agree, root cause has to be fixed.
> Horia, can you have a look at what caused that and how to fix it?
> It's probably a commit in the caam drivers. I have also created
> a patch to address a problem with that driver but forgot
> to send that out, it might fix this one as well, see my follow-up
> patch "crypto: caam/qi2 - add a CRYPTO_DEV_FSL_CAAM
> dependency".
>
Yes, will continue discussion there.
Thanks,
Horia
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-20 20:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <49a5d199-4eeb-a7c2-b539-13356162547f@free.fr>
[not found] ` <beb32683-fbd0-fc17-8e71-4f4f51163223@free.fr>
[not found] ` <VI1PR0402MB3485824A9FB3BC878E7B83D498C60@VI1PR0402MB3485.eurprd04.prod.outlook.com>
[not found] ` <20181213064803.kd7p7fzsegu6nhnl@localhost>
2018-12-15 21:44 ` [PATCH v3 7/9] arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO Stefan Wahren
2018-12-17 15:33 ` Horia Geanta
2018-12-18 20:10 ` Stefan Wahren
2018-12-19 10:18 ` [PATCH] Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO" Horia Geantă
2018-12-20 15:27 ` Arnd Bergmann
2018-12-20 20:43 ` Horia Geanta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).