* [PATCH v2 01/11] ACPI / LPSS: Add guards against CONFIG_PCI
[not found] <20181222090720.19234-1-okaya@kernel.org>
@ 2018-12-22 9:07 ` Sinan Kaya
2018-12-23 21:45 ` Rafael J. Wysocki
2018-12-22 9:07 ` [PATCH v2 02/11] ata: make PCI dependency explicit for PATA_ACPI Sinan Kaya
` (9 subsequent siblings)
10 siblings, 1 reply; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Rafael J. Wysocki, Len Brown, open list
We can now compile ACPI without PCI support. If code depends on CONFIG_PCI,
it needs to explicitly guard that piece.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/acpi/acpi_lpss.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 5f94c35d165f..4148abcdf9ef 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -534,8 +534,11 @@ static struct device *acpi_lpss_find_device(const char *hid, const char *uid)
dev = bus_find_device(&platform_bus_type, NULL, &data, match_hid_uid);
if (dev)
return dev;
-
+#ifdef CONFIG_PCI
return bus_find_device(&pci_bus_type, NULL, &data, match_hid_uid);
+#else
+ return NULL;
+#endif
}
static bool acpi_lpss_dep(struct acpi_device *adev, acpi_handle handle)
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 02/11] ata: make PCI dependency explicit for PATA_ACPI
[not found] <20181222090720.19234-1-okaya@kernel.org>
2018-12-22 9:07 ` [PATCH v2 01/11] ACPI / LPSS: Add guards against CONFIG_PCI Sinan Kaya
@ 2018-12-22 9:07 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 03/11] vga-switcheroo: make PCI dependency explicit Sinan Kaya
` (8 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Jens Axboe,
open list:LIBATA SUBSYSTEM Serial and Parallel ATA drivers,
open list
PATA_ACPI is a PCI device driver but the PCI dependency has not been
explicitly called out.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 4ca7a6b4eaae..8218db17ebdb 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
config PATA_ACPI
tristate "ACPI firmware driver for PATA"
- depends on ATA_ACPI && ATA_BMDMA
+ depends on ATA_ACPI && ATA_BMDMA && PCI
help
This option enables an ACPI method driver which drives
motherboard PATA controller interfaces through the ACPI
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 03/11] vga-switcheroo: make PCI dependency explicit
[not found] <20181222090720.19234-1-okaya@kernel.org>
2018-12-22 9:07 ` [PATCH v2 01/11] ACPI / LPSS: Add guards against CONFIG_PCI Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 02/11] ata: make PCI dependency explicit for PATA_ACPI Sinan Kaya
@ 2018-12-22 9:07 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 04/11] platform/x86: " Sinan Kaya
` (7 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: Maxime Ripard, David Airlie, Sinan Kaya, open list,
open list:DRM DRIVERS, linux-acpi, Sean Paul
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
---
drivers/gpu/vga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
index b677e5d524e6..d5f1d8e1c6f8 100644
--- a/drivers/gpu/vga/Kconfig
+++ b/drivers/gpu/vga/Kconfig
@@ -21,6 +21,7 @@ config VGA_SWITCHEROO
bool "Laptop Hybrid Graphics - GPU switching support"
depends on X86
depends on ACPI
+ depends on PCI
select VGA_ARB
help
Many laptops released in 2008/9/10 have two GPUs with a multiplexer
--
2.19.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 04/11] platform/x86: make PCI dependency explicit
[not found] <20181222090720.19234-1-okaya@kernel.org>
` (2 preceding siblings ...)
2018-12-22 9:07 ` [PATCH v2 03/11] vga-switcheroo: make PCI dependency explicit Sinan Kaya
@ 2018-12-22 9:07 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 05/11] platform/x86: intel_pmc: Hide PCI specific pieces behind CONFIG_PCI Sinan Kaya
` (6 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
ipss driver is a PCI device driver but this has not been mentioned
anywhere in Kconfig.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index e3b62c2ee8d1..b36ea14b41ad 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1009,7 +1009,7 @@ config INTEL_MFLD_THERMAL
config INTEL_IPS
tristate "Intel Intelligent Power Sharing"
- depends on ACPI
+ depends on ACPI && PCI
---help---
Intel Calpella platforms support dynamic power sharing between the
CPU and GPU, maximizing performance in a given TDP. This driver,
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 05/11] platform/x86: intel_pmc: Hide PCI specific pieces behind CONFIG_PCI
[not found] <20181222090720.19234-1-okaya@kernel.org>
` (3 preceding siblings ...)
2018-12-22 9:07 ` [PATCH v2 04/11] platform/x86: " Sinan Kaya
@ 2018-12-22 9:07 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 06/11] apple-gmux: Make PCI dependency explicit Sinan Kaya
` (5 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zha Qipeng, Darren Hart, Andy Shevchenko,
open list:INTEL PMC/P-Unit IPC DRIVER, open list
In the configuration where CONFIG_PCI is unset, this driver is failing to
compile due to PCI framework dependencies. Hide these behind CONFIG_PCI
ifdef.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/intel_pmc_ipc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c
index 7964ba22ef8d..d85dfed3bf9c 100644
--- a/drivers/platform/x86/intel_pmc_ipc.c
+++ b/drivers/platform/x86/intel_pmc_ipc.c
@@ -504,6 +504,7 @@ static irqreturn_t ioc(int irq, void *dev_id)
return IRQ_HANDLED;
}
+#ifdef CONFIG_PCI
static int ipc_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
{
struct intel_pmc_ipc_dev *pmc = &ipcdev;
@@ -556,6 +557,7 @@ static struct pci_driver ipc_pci_driver = {
.id_table = ipc_pci_ids,
.probe = ipc_pci_probe,
};
+#endif
static ssize_t intel_pmc_ipc_simple_cmd_store(struct device *dev,
struct device_attribute *attr,
@@ -1007,18 +1009,22 @@ static int __init intel_pmc_ipc_init(void)
pr_err("Failed to register PMC ipc platform driver\n");
return ret;
}
+#ifdef CONFIG_PCI
ret = pci_register_driver(&ipc_pci_driver);
if (ret) {
pr_err("Failed to register PMC ipc pci driver\n");
platform_driver_unregister(&ipc_plat_driver);
return ret;
}
+#endif
return ret;
}
static void __exit intel_pmc_ipc_exit(void)
{
+#ifdef CONFIG_PCI
pci_unregister_driver(&ipc_pci_driver);
+#endif
platform_driver_unregister(&ipc_plat_driver);
}
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 06/11] apple-gmux: Make PCI dependency explicit
[not found] <20181222090720.19234-1-okaya@kernel.org>
` (4 preceding siblings ...)
2018-12-22 9:07 ` [PATCH v2 05/11] platform/x86: intel_pmc: Hide PCI specific pieces behind CONFIG_PCI Sinan Kaya
@ 2018-12-22 9:07 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset Sinan Kaya
` (4 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index b36ea14b41ad..86b75fa55dbc 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
config APPLE_GMUX
tristate "Apple Gmux Driver"
depends on ACPI
+ depends on PCI
depends on PNP
depends on BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset
[not found] <20181222090720.19234-1-okaya@kernel.org>
` (5 preceding siblings ...)
2018-12-22 9:07 ` [PATCH v2 06/11] apple-gmux: Make PCI dependency explicit Sinan Kaya
@ 2018-12-22 9:07 ` Sinan Kaya
2018-12-23 21:48 ` Rafael J. Wysocki
2018-12-22 9:07 ` [PATCH v2 08/11] ASoC: Intel: Make PCI dependency explicit Sinan Kaya
` (3 subsequent siblings)
10 siblings, 1 reply; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, Sumeet Pawnikar,
open list:THERMAL, open list
This driver is both a platform and PCI driver. Hide PCI specific pieces
when CONFIG_PCI is unset.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
.../intel/int340x_thermal/processor_thermal_device.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
index 284cf2c5a8fd..b84a475a1162 100644
--- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
+++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
@@ -374,6 +374,7 @@ static int int3401_remove(struct platform_device *pdev)
return 0;
}
+#ifdef CONFIG_PCI
static irqreturn_t proc_thermal_pci_msi_irq(int irq, void *devid)
{
struct proc_thermal_device *proc_priv;
@@ -482,6 +483,7 @@ static struct pci_driver proc_thermal_pci_driver = {
.remove = proc_thermal_pci_remove,
.id_table = proc_thermal_pci_ids,
};
+#endif
static const struct acpi_device_id int3401_device_ids[] = {
{"INT3401", 0},
@@ -505,16 +507,18 @@ static int __init proc_thermal_init(void)
ret = platform_driver_register(&int3401_driver);
if (ret)
return ret;
-
+#ifdef CONFIG_PCI
ret = pci_register_driver(&proc_thermal_pci_driver);
-
+#endif
return ret;
}
static void __exit proc_thermal_exit(void)
{
platform_driver_unregister(&int3401_driver);
+#ifdef CONFIG_PCI
pci_unregister_driver(&proc_thermal_pci_driver);
+#endif
}
module_init(proc_thermal_init);
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 08/11] ASoC: Intel: Make PCI dependency explicit
[not found] <20181222090720.19234-1-okaya@kernel.org>
` (6 preceding siblings ...)
2018-12-22 9:07 ` [PATCH v2 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset Sinan Kaya
@ 2018-12-22 9:07 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 09/11] mmc: add PCI dependency into IOSF_MBI Sinan Kaya
` (2 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Pierre-Louis Bossart, Liam Girdwood,
Jie Yang, Mark Brown, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
CONFIG_PCI set but this is not specified anywhere.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
sound/soc/intel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 2fd1b61e8331..b0764b2fe001 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
default ACPI
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select SND_SST_IPC_ACPI
select SND_SST_ATOM_HIFI2_PLATFORM
select SND_SOC_ACPI_INTEL_MATCH
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 09/11] mmc: add PCI dependency into IOSF_MBI
[not found] <20181222090720.19234-1-okaya@kernel.org>
` (7 preceding siblings ...)
2018-12-22 9:07 ` [PATCH v2 08/11] ASoC: Intel: Make PCI dependency explicit Sinan Kaya
@ 2018-12-22 9:07 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 11/11] drivers: thermal: Make PCI dependency explicit Sinan Kaya
10 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Ulf Hansson, Adrian Hunter, Shawn Lin,
Geert Uytterhoeven, Faiz Abbas, Chunyan Zhang, Jisheng Zhang,
Ludovic Barre, Masahiro Yamada, Arnd Bergmann, Alex Smith,
Chris Brandt, open list:MULTIMEDIA CARD MMC,
SECURE DIGITAL SD AND...,
open list
Select IOSF_MBI only when PCI is set.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index e26b8145efb3..4c5f037b246d 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -117,7 +117,7 @@ config MMC_RICOH_MMC
config MMC_SDHCI_ACPI
tristate "SDHCI support for ACPI enumerated SDHCI controllers"
depends on MMC_SDHCI && ACPI
- select IOSF_MBI if X86
+ select IOSF_MBI if (X86 && PCI)
help
This selects support for ACPI enumerated SDHCI controllers,
identified by ACPI Compatibility ID PNP0D40 or specific
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set
[not found] <20181222090720.19234-1-okaya@kernel.org>
` (8 preceding siblings ...)
2018-12-22 9:07 ` [PATCH v2 09/11] mmc: add PCI dependency into IOSF_MBI Sinan Kaya
@ 2018-12-22 9:07 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 11/11] drivers: thermal: Make PCI dependency explicit Sinan Kaya
10 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT,
open list:X86 ARCHITECTURE 32-BIT AND 64-BIT
Need CONFIG_PCI to be set in order to be able to use IOSF_MBI
functionality.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index cc4f0c6ee1ed..322a58ababb0 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -617,7 +617,7 @@ config X86_INTEL_QUARK
config X86_INTEL_LPSS
bool "Intel Low Power Subsystem Support"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select COMMON_CLK
select PINCTRL
select IOSF_MBI
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 11/11] drivers: thermal: Make PCI dependency explicit
[not found] <20181222090720.19234-1-okaya@kernel.org>
` (9 preceding siblings ...)
2018-12-22 9:07 ` [PATCH v2 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set Sinan Kaya
@ 2018-12-22 9:07 ` Sinan Kaya
10 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-22 9:07 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
IOSF_CORE depends on PCI. This was never mentioned.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index 0582bd12a239..0ca908d12750 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -4,7 +4,7 @@
config INT340X_THERMAL
tristate "ACPI INT340X thermal drivers"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select THERMAL_GOV_USER_SPACE
select ACPI_THERMAL_REL
select ACPI_FAN
--
2.19.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v2 01/11] ACPI / LPSS: Add guards against CONFIG_PCI
2018-12-22 9:07 ` [PATCH v2 01/11] ACPI / LPSS: Add guards against CONFIG_PCI Sinan Kaya
@ 2018-12-23 21:45 ` Rafael J. Wysocki
2018-12-23 22:21 ` Sinan Kaya
0 siblings, 1 reply; 15+ messages in thread
From: Rafael J. Wysocki @ 2018-12-23 21:45 UTC (permalink / raw)
To: okaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List,
Rafael J. Wysocki, Len Brown, Linux Kernel Mailing List
On Sat, Dec 22, 2018 at 6:49 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> We can now compile ACPI without PCI support. If code depends on CONFIG_PCI,
> it needs to explicitly guard that piece.
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/acpi/acpi_lpss.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 5f94c35d165f..4148abcdf9ef 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -534,8 +534,11 @@ static struct device *acpi_lpss_find_device(const char *hid, const char *uid)
> dev = bus_find_device(&platform_bus_type, NULL, &data, match_hid_uid);
> if (dev)
> return dev;
> -
> +#ifdef CONFIG_PCI
> return bus_find_device(&pci_bus_type, NULL, &data, match_hid_uid);
> +#else
> + return NULL;
> +#endif
> }
No.
Please make this driver depend on PCI instead.
>
> static bool acpi_lpss_dep(struct acpi_device *adev, acpi_handle handle)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset
2018-12-22 9:07 ` [PATCH v2 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset Sinan Kaya
@ 2018-12-23 21:48 ` Rafael J. Wysocki
2018-12-23 22:23 ` Sinan Kaya
0 siblings, 1 reply; 15+ messages in thread
From: Rafael J. Wysocki @ 2018-12-23 21:48 UTC (permalink / raw)
To: okaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Zhang, Rui,
Eduardo Valentin, Daniel Lezcano, Amit Kucheria,
sumeet.r.pawnikar, Linux PM, Linux Kernel Mailing List
On Sat, Dec 22, 2018 at 6:49 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> This driver is both a platform and PCI driver. Hide PCI specific pieces
> when CONFIG_PCI is unset.
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> .../intel/int340x_thermal/processor_thermal_device.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> index 284cf2c5a8fd..b84a475a1162 100644
> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
> @@ -374,6 +374,7 @@ static int int3401_remove(struct platform_device *pdev)
> return 0;
> }
>
> +#ifdef CONFIG_PCI
> static irqreturn_t proc_thermal_pci_msi_irq(int irq, void *devid)
> {
> struct proc_thermal_device *proc_priv;
> @@ -482,6 +483,7 @@ static struct pci_driver proc_thermal_pci_driver = {
> .remove = proc_thermal_pci_remove,
> .id_table = proc_thermal_pci_ids,
> };
> +#endif
>
> static const struct acpi_device_id int3401_device_ids[] = {
> {"INT3401", 0},
> @@ -505,16 +507,18 @@ static int __init proc_thermal_init(void)
> ret = platform_driver_register(&int3401_driver);
> if (ret)
> return ret;
> -
> +#ifdef CONFIG_PCI
> ret = pci_register_driver(&proc_thermal_pci_driver);
> -
> +#endif
> return ret;
> }
>
> static void __exit proc_thermal_exit(void)
> {
> platform_driver_unregister(&int3401_driver);
> +#ifdef CONFIG_PCI
> pci_unregister_driver(&proc_thermal_pci_driver);
> +#endif
> }
>
> module_init(proc_thermal_init);
Can you actually test this driver with your new #ifdef stuff and with
CONFIG_PCI unset?
Have you really test it in that configuration?
If not, you shouldn't even post this patch.
Please make the driver depend on PCI.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 01/11] ACPI / LPSS: Add guards against CONFIG_PCI
2018-12-23 21:45 ` Rafael J. Wysocki
@ 2018-12-23 22:21 ` Sinan Kaya
0 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-23 22:21 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux-Next Mailing List, ACPI Devel Maling List,
Rafael J. Wysocki, Len Brown, Linux Kernel Mailing List
On 12/23/2018 10:45 PM, Rafael J. Wysocki wrote:
> No.
>
> Please make this driver depend on PCI instead.
Sure.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset
2018-12-23 21:48 ` Rafael J. Wysocki
@ 2018-12-23 22:23 ` Sinan Kaya
0 siblings, 0 replies; 15+ messages in thread
From: Sinan Kaya @ 2018-12-23 22:23 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Zhang, Rui,
Eduardo Valentin, Daniel Lezcano, Amit Kucheria,
sumeet.r.pawnikar, Linux PM, Linux Kernel Mailing List
On 12/23/2018 10:48 PM, Rafael J. Wysocki wrote:
> Can you actually test this driver with your new #ifdef stuff and with
> CONFIG_PCI unset?
>
> Have you really test it in that configuration?
>
No, I haven't. Code was compile tested only.
> If not, you shouldn't even post this patch.
>
I was hoping the maintainer to chime in. By looking at the code, it was
registering a platform and PCI driver. I assumed that it was generic code
that can be used with and without PCI.
> Please make the driver depend on PCI.
I can do that.
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2018-12-23 22:23 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20181222090720.19234-1-okaya@kernel.org>
2018-12-22 9:07 ` [PATCH v2 01/11] ACPI / LPSS: Add guards against CONFIG_PCI Sinan Kaya
2018-12-23 21:45 ` Rafael J. Wysocki
2018-12-23 22:21 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 02/11] ata: make PCI dependency explicit for PATA_ACPI Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 03/11] vga-switcheroo: make PCI dependency explicit Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 04/11] platform/x86: " Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 05/11] platform/x86: intel_pmc: Hide PCI specific pieces behind CONFIG_PCI Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 06/11] apple-gmux: Make PCI dependency explicit Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset Sinan Kaya
2018-12-23 21:48 ` Rafael J. Wysocki
2018-12-23 22:23 ` Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 08/11] ASoC: Intel: Make PCI dependency explicit Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 09/11] mmc: add PCI dependency into IOSF_MBI Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set Sinan Kaya
2018-12-22 9:07 ` [PATCH v2 11/11] drivers: thermal: Make PCI dependency explicit Sinan Kaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).