* Re: next-20190215 build: 2 failures 19 warnings (next-20190215) [not found] <E1gukSa-0003kX-JD@optimist> @ 2019-02-18 11:32 ` Mark Brown 2019-02-18 12:09 ` Greg Kroah-Hartman 0 siblings, 1 reply; 4+ messages in thread From: Mark Brown @ 2019-02-18 11:32 UTC (permalink / raw) To: Thierry Reding, Greg Kroah-Hartman, Jassi Brar Cc: linux-tegra, linaro-kernel, linux-next, linux-arm-kernel, kernel-build-reports [-- Attachment #1.1: Type: text/plain, Size: 501 bytes --] On Fri, Feb 15, 2019 at 08:51:48PM +0000, Build bot for Mark Brown wrote: The build failure with mbox_fush() in the tegra-tcu driver that was initially reported two weeks ago is still present in -next (this report is from Friday but it's also present today): > arm64-allmodconfig > ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined! > > arm-allmodconfig > ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined! Is there any progress on getting a fix merged? [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: next-20190215 build: 2 failures 19 warnings (next-20190215) 2019-02-18 11:32 ` next-20190215 build: 2 failures 19 warnings (next-20190215) Mark Brown @ 2019-02-18 12:09 ` Greg Kroah-Hartman 2019-02-18 15:08 ` Thierry Reding 0 siblings, 1 reply; 4+ messages in thread From: Greg Kroah-Hartman @ 2019-02-18 12:09 UTC (permalink / raw) To: Mark Brown Cc: linaro-kernel, kernel-build-reports, Jassi Brar, linux-next, linux-tegra, Thierry Reding, linux-arm-kernel On Mon, Feb 18, 2019 at 11:32:17AM +0000, Mark Brown wrote: > On Fri, Feb 15, 2019 at 08:51:48PM +0000, Build bot for Mark Brown wrote: > > The build failure with mbox_fush() in the tegra-tcu driver that was > initially reported two weeks ago is still present in -next (this report > is from Friday but it's also present today): > > > arm64-allmodconfig > > ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined! > > > > arm-allmodconfig > > ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined! > > Is there any progress on getting a fix merged? I can take the fix in my tty tree if I get an ack from the mbox maintainer... ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: next-20190215 build: 2 failures 19 warnings (next-20190215) 2019-02-18 12:09 ` Greg Kroah-Hartman @ 2019-02-18 15:08 ` Thierry Reding 2019-02-18 17:10 ` Jassi Brar 0 siblings, 1 reply; 4+ messages in thread From: Thierry Reding @ 2019-02-18 15:08 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: linaro-kernel, kernel-build-reports, Jassi Brar, Mark Brown, linux-next, linux-tegra, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 2208 bytes --] On Mon, Feb 18, 2019 at 01:09:21PM +0100, Greg Kroah-Hartman wrote: > On Mon, Feb 18, 2019 at 11:32:17AM +0000, Mark Brown wrote: > > On Fri, Feb 15, 2019 at 08:51:48PM +0000, Build bot for Mark Brown wrote: > > > > The build failure with mbox_fush() in the tegra-tcu driver that was > > initially reported two weeks ago is still present in -next (this report > > is from Friday but it's also present today): > > > > > arm64-allmodconfig > > > ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined! > > > > > > arm-allmodconfig > > > ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined! > > > > Is there any progress on getting a fix merged? > > I can take the fix in my tty tree if I get an ack from the mbox > maintainer... Maybe we can do the below until Jassi picks up the proper fix. There is no hardware currently where we'd want to build the TCU driver as a loadable module, so that would be fine for now. It's a bit of churn because I'd want to revert that later on, but it's not too bad and would get linux-next back on track. Thierry --- >8 --- From 5086e2ac9359c8d24d88ce1beeb7651e00401e1e Mon Sep 17 00:00:00 2001 From: Thierry Reding <treding@nvidia.com> Date: Mon, 18 Feb 2019 16:04:49 +0100 Subject: [PATCH] serial: tegra-tcu: Do not allow building as a module The Tegra TCU driver relies on a function implemented in the mailbox subsystem but is not exported. To avoid link errors in builders, don't allow the driver to be built as a module. The proper fix is to export the mailbox API, but until that happens, use this quick fix. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 72966bc0ac76..e46a285fb8bb 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -336,7 +336,7 @@ config SERIAL_TEGRA and better performance. config SERIAL_TEGRA_TCU - tristate "NVIDIA Tegra Combined UART" + bool "NVIDIA Tegra Combined UART" depends on ARCH_TEGRA && TEGRA_HSP_MBOX select SERIAL_CORE help -- 2.20.1 [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: next-20190215 build: 2 failures 19 warnings (next-20190215) 2019-02-18 15:08 ` Thierry Reding @ 2019-02-18 17:10 ` Jassi Brar 0 siblings, 0 replies; 4+ messages in thread From: Jassi Brar @ 2019-02-18 17:10 UTC (permalink / raw) To: Thierry Reding Cc: linaro-kernel, kernel-build-reports, Greg Kroah-Hartman, Mark Brown, Linux-Next Mailing List, linux-tegra, linux-arm-kernel On Mon, 18 Feb 2019 at 09:08, Thierry Reding <treding@nvidia.com> wrote: > > On Mon, Feb 18, 2019 at 01:09:21PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Feb 18, 2019 at 11:32:17AM +0000, Mark Brown wrote: > > > On Fri, Feb 15, 2019 at 08:51:48PM +0000, Build bot for Mark Brown wrote: > > > > > > The build failure with mbox_fush() in the tegra-tcu driver that was > > > initially reported two weeks ago is still present in -next (this report > > > is from Friday but it's also present today): > > > > > > > arm64-allmodconfig > > > > ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined! > > > > > > > > arm-allmodconfig > > > > ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined! > > > > > > Is there any progress on getting a fix merged? > > > > I can take the fix in my tty tree if I get an ack from the mbox > > maintainer... > Not sure if I was on the CC. Honestly I only look into emails that pass my very lenient filter. I will add 'mbox' too to it. > Maybe we can do the below until Jassi picks up the proper fix. There is > no hardware currently where we'd want to build the TCU driver as a > loadable module, so that would be fine for now. > > It's a bit of churn because I'd want to revert that later on, but it's > not too bad and would get linux-next back on track. > Maybe it should be indeed bool or rather directly selected by your ARCH because iirc you wanted to send critical debugging messages over tcu ;) Anyway, I have sent a pull request with this fix in. Cheers! ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-18 17:10 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <E1gukSa-0003kX-JD@optimist> 2019-02-18 11:32 ` next-20190215 build: 2 failures 19 warnings (next-20190215) Mark Brown 2019-02-18 12:09 ` Greg Kroah-Hartman 2019-02-18 15:08 ` Thierry Reding 2019-02-18 17:10 ` Jassi Brar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).