linux-next: manual merge of the mac80211-next tree with the mac80211 tree

linux-next: manual merge of the mac80211-next tree with the mac80211 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

Hi all,

Today's linux-next merge of the mac80211-next tree got a conflict in:

  net/mac80211/tx.c

between commit:

  eb9b64e3a9f8 ("mac80211: fix memory accounting with A-MSDU aggregation")

from the mac80211 tree and commit:

  dcec1d9bc8a7 ("mac80211: calculate hash for fq without holding fq->lock in itxq enqueue")

from the mac80211-next tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc net/mac80211/tx.c
index 2e816dd67be7,3655aae96df1..000000000000
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@@ -3221,7 -3219,7 +3219,8 @@@ static bool ieee80211_amsdu_aggregate(s
  	u8 max_subframes = sta->sta.max_amsdu_subframes;
  	int max_frags = local->hw.max_tx_fragments;
  	int max_amsdu_len = sta->sta.max_amsdu_len;
 +	int orig_truesize;
+ 	u32 flow_idx;
  	__be16 len;
  	void *data;
  	bool ret = false;

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: manual merge of the mac80211-next tree with the mac80211 tree

[Johannes Berg]

Hi Stephen,

> Today's linux-next merge of the mac80211-next tree got a conflict in:
> 
>   net/mac80211/tx.c
> 
> between commit:
> 
>   eb9b64e3a9f8 ("mac80211: fix memory accounting with A-MSDU aggregation")
> 
> from the mac80211 tree and commit:
> 
>   dcec1d9bc8a7 ("mac80211: calculate hash for fq without holding fq->lock in itxq enqueue")
> 
> from the mac80211-next tree.

Thanks for the heads-up!

But yes, I'm aware. It seemed simple enough though that I decided to
keep it like that, I didn't really find a better solution.

johannes

Re: linux-next: manual merge of the mac80211-next tree with the mac80211 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hi Johannes,

On Tue, 09 Apr 2019 09:27:35 +0200 Johannes Berg <johannes@sipsolutions.net> wrote:
>
> But yes, I'm aware. It seemed simple enough though that I decided to
> keep it like that, I didn't really find a better solution.

Yeah, pretty trivial.  I assume both trees will meet in Dave's tree at some point.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: manual merge of the mac80211-next tree with the mac80211 tree

[Johannes Berg]

Hi Stephen,

> between commit:
> 
>   b71d856ab536 ("mac80211_hwsim: add workqueue to wait for deferred radio deletion on mod unload")
> 
> from the mac80211 tree and commit:
> 
>   c6509cc3b3e8 ("mac80211_hwsim: add hashtable with mac address keys for faster lookup")
> 
> from the mac80211-next tree.
> 
> I fixed it up (see below) and can carry the fix as necessary.

Yeah, thanks. I was pondering whether I should knowingly generate that
conflict, but I'll fix it up before merge anyway - might hold the -next
for later anyway.

Thanks!

johannes

linux-next: manual merge of the mac80211-next tree with the mac80211 tree

[Stephen Rothwell]

Hi Johannes,

Today's linux-next merge of the mac80211-next tree got a conflict in:

  drivers/net/wireless/mac80211_hwsim.c

between commit:

  b71d856ab536 ("mac80211_hwsim: add workqueue to wait for deferred radio deletion on mod unload")

from the mac80211 tree and commit:

  c6509cc3b3e8 ("mac80211_hwsim: add hashtable with mac address keys for faster lookup")

from the mac80211-next tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/net/wireless/mac80211_hwsim.c
index e54255597fac,6bf063adcbde..000000000000
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@@ -489,7 -490,7 +490,8 @@@ static const struct ieee80211_iface_com
  
  static spinlock_t hwsim_radio_lock;
  static LIST_HEAD(hwsim_radios);
+ static struct rhashtable hwsim_radios_rht;
 +static struct workqueue_struct *hwsim_wq;
  static int hwsim_radio_idx;
  
  static struct platform_driver mac80211_hwsim_driver = {
@@@ -3352,8 -3396,10 +3402,10 @@@ static void remove_user_radios(u32 port
  	list_for_each_entry_safe(entry, tmp, &hwsim_radios, list) {
  		if (entry->destroy_on_close && entry->portid == portid) {
  			list_del(&entry->list);
+ 			rhashtable_remove_fast(&hwsim_radios_rht, &entry->rht,
+ 					       hwsim_rht_params);
  			INIT_WORK(&entry->destroy_work, destroy_radio);
 -			schedule_work(&entry->destroy_work);
 +			queue_work(hwsim_wq, &entry->destroy_work);
  		}
  	}
  	spin_unlock_bh(&hwsim_radio_lock);
@@@ -3427,8 -3473,10 +3479,10 @@@ static void __net_exit hwsim_exit_net(s
  			continue;
  
  		list_del(&data->list);
+ 		rhashtable_remove_fast(&hwsim_radios_rht, &data->rht,
+ 				       hwsim_rht_params);
  		INIT_WORK(&data->destroy_work, destroy_radio);
 -		schedule_work(&data->destroy_work);
 +		queue_work(hwsim_wq, &data->destroy_work);
  	}
  	spin_unlock_bh(&hwsim_radio_lock);
  }
@@@ -3460,10 -3508,8 +3514,12 @@@ static int __init init_mac80211_hwsim(v
  
  	spin_lock_init(&hwsim_radio_lock);
  
 +	hwsim_wq = alloc_workqueue("hwsim_wq",WQ_MEM_RECLAIM,0);
 +	if (!hwsim_wq)
 +		return -ENOMEM;
 +
+ 	rhashtable_init(&hwsim_radios_rht, &hwsim_rht_params);
+ 
  	err = register_pernet_device(&hwsim_net_ops);
  	if (err)
  		return err;
@@@ -3602,8 -3648,7 +3658,9 @@@ static void __exit exit_mac80211_hwsim(
  	hwsim_exit_netlink();
  
  	mac80211_hwsim_free();
+ 	rhashtable_destroy(&hwsim_radios_rht);
 +	flush_workqueue(hwsim_wq);
 +
  	unregister_netdev(hwsim_mon);
  	platform_driver_unregister(&mac80211_hwsim_driver);
  	unregister_pernet_device(&hwsim_net_ops);

linux-next: manual merge of the mac80211-next tree with the mac80211 tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

Hi Johannes,

Today's linux-next merge of the mac80211-next tree got a conflict in
net/mac80211/cfg.c between commit c1df932c0574 ("mac80211: fix off-channel
mgmt-tx uninitialized variable usage") from the mac80211 tree and commit
a2aecd7d96ba ("mac80211: move off-channel/mgmt-tx code to offchannel.c") from
the mac80211-next tree.

I fixed it up resulting in an empty diff and can carry the fix as necessary (no
action is required).

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]