linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH linux-next] sysctl: fix build error
@ 2019-06-12 22:01 Matteo Croce
  2019-06-13  0:16 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: Matteo Croce @ 2019-06-12 22:01 UTC (permalink / raw)
  To: Andrew Morton, linux-next
  Cc: Song Liu, linux-kernel, Johannes Weiner, Aaron Tomlin

Commit cefdca0a86be ("userfaultfd/sysctl: add vm.unprivileged_userfaultfd")
reintroduces a reference to 'zero' and 'one'.
Use the SYSCTL_{ZERO,ONE} symbols instead.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
 kernel/sysctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index c77174336d16..4dce89d74a40 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1735,8 +1735,8 @@ static struct ctl_table vm_table[] = {
 		.maxlen		= sizeof(sysctl_unprivileged_userfaultfd),
 		.mode		= 0644,
 		.proc_handler	= proc_dointvec_minmax,
-		.extra1		= &zero,
-		.extra2		= &one,
+		.extra1		= SYSCTL_ZERO,
+		.extra2		= SYSCTL_ONE,
 	},
 #endif
 	{ }
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH linux-next] sysctl: fix build error
  2019-06-12 22:01 [PATCH linux-next] sysctl: fix build error Matteo Croce
@ 2019-06-13  0:16 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2019-06-13  0:16 UTC (permalink / raw)
  To: Matteo Croce
  Cc: linux-next, Song Liu, linux-kernel, Johannes Weiner, Aaron Tomlin

On Thu, 13 Jun 2019 00:01:20 +0200 Matteo Croce <mcroce@redhat.com> wrote:

> Commit cefdca0a86be ("userfaultfd/sysctl: add vm.unprivileged_userfaultfd")
> reintroduces a reference to 'zero' and 'one'.
> Use the SYSCTL_{ZERO,ONE} symbols instead.

proc-sysctl-add-shared-variables-for-range-check-fix.patch (which has
been in linux-next for over a week) already fixed that.

> Reported-by: kbuild test robot <lkp@intel.com>

Some robot glitch I guess?


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-13 17:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12 22:01 [PATCH linux-next] sysctl: fix build error Matteo Croce
2019-06-13  0:16 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).