linux-next: Fixes tags need some work in the staging.current tree

linux-next: Fixes tags need some work in the staging.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

Hi all,

In commit

  0c75376fa395 ("counter/ftm-quaddec: Add missing dependencies in Kconfig")

Fixes tag

  Fixes: a3b9a99 ("counter: add FlexTimer Module Quadrature decoder counter driver")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

In commit

  bce0d57db388 ("iio: imu: st_lsm6dsx: fix PM support for st_lsm6dsx i2c controller")

Fixes tag

  Fixes: c91c1c844ebd ("imu: st_lsm6dsx: add i2c embedded controller support")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the staging.current tree

[Greg KH]

On Tue, Jun 18, 2019 at 07:36:18AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   0c75376fa395 ("counter/ftm-quaddec: Add missing dependencies in Kconfig")
> 
> Fixes tag
> 
>   Fixes: a3b9a99 ("counter: add FlexTimer Module Quadrature decoder counter driver")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 
> In commit
> 
>   bce0d57db388 ("iio: imu: st_lsm6dsx: fix PM support for st_lsm6dsx i2c controller")
> 
> Fixes tag
> 
>   Fixes: c91c1c844ebd ("imu: st_lsm6dsx: add i2c embedded controller support")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Ugh.

I blame Jonathan for all of these as they came in through his tree :)

thanks,

greg k-h

Re: linux-next: Fixes tags need some work in the staging.current tree

[Jonathan Cameron]

On Tue, 18 Jun 2019 13:51:31 +0200
Greg KH <greg@kroah.com> wrote:

> On Tue, Jun 18, 2019 at 07:36:18AM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   0c75376fa395 ("counter/ftm-quaddec: Add missing dependencies in Kconfig")
> > 
> > Fixes tag
> > 
> >   Fixes: a3b9a99 ("counter: add FlexTimer Module Quadrature decoder counter driver")
> > 
> > has these problem(s):
> > 
> >   - SHA1 should be at least 12 digits long
> >     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> >     or later) just making sure it is not set (or set to "auto").
> > 
> > In commit
> > 
> >   bce0d57db388 ("iio: imu: st_lsm6dsx: fix PM support for st_lsm6dsx i2c controller")
> > 
> > Fixes tag
> > 
> >   Fixes: c91c1c844ebd ("imu: st_lsm6dsx: add i2c embedded controller support")
> > 
> > has these problem(s):
> > 
> >   - Subject does not match target commit subject
> >     Just use
> > 	git log -1 --format='Fixes: %h ("%s")'  
> 
> Ugh.
> 
> I blame Jonathan for all of these as they came in through his tree :)
> 
> thanks,
> 
> greg k-h

I'll keep a closer eye on this going forwards.

Thanks,

Jonathan