linux-next: Fixes tags need some work in the drm-fixes tree

linux-next: Fixes tags need some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

Hi all,

In commit

  912bbf7e9ca4 ("gpu: ipu-v3: image-convert: Fix image downsize coefficients")

Fixes tag

  Fixes: 70b9b6b3bcb21 ("gpu: ipu-v3: image-convert: calculate per-tile

has these problem(s):

  - Please don't split Fixes tags across more than one line

In commit

  bca4d70cf1b8 ("gpu: ipu-v3: image-convert: Fix input bytesperline for packed formats")

Fixes tag

  Fixes: d966e23d61a2c ("gpu: ipu-v3: image-convert: fix bytesperline

has these problem(s):

  - Please don't split Fixes tags across more than one line

In commit

  ff391ecd65a1 ("gpu: ipu-v3: image-convert: Fix input bytesperline width/height align")

Fixes tag

  Fixes: d966e23d61a2c ("gpu: ipu-v3: image-convert: fix bytesperline

has these problem(s):

  - Please don't split Fixes tags across more than one line

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the drm-fixes tree

[Philipp Zabel]

On Fri, 2019-06-21 at 21:41 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   912bbf7e9ca4 ("gpu: ipu-v3: image-convert: Fix image downsize coefficients")
> 
> Fixes tag
> 
>   Fixes: 70b9b6b3bcb21 ("gpu: ipu-v3: image-convert: calculate per-tile
> 
> has these problem(s):
> 
>   - Please don't split Fixes tags across more than one line
> 
> In commit
> 
>   bca4d70cf1b8 ("gpu: ipu-v3: image-convert: Fix input bytesperline for packed formats")
> 
> Fixes tag
> 
>   Fixes: d966e23d61a2c ("gpu: ipu-v3: image-convert: fix bytesperline
> 
> has these problem(s):
> 
>   - Please don't split Fixes tags across more than one line
> 
> In commit
> 
>   ff391ecd65a1 ("gpu: ipu-v3: image-convert: Fix input bytesperline width/height align")
> 
> Fixes tag
> 
>   Fixes: d966e23d61a2c ("gpu: ipu-v3: image-convert: fix bytesperline
> 
> has these problem(s):
> 
>   - Please don't split Fixes tags across more than one line
> 

I was under the impression that dim would have found those, but I only
just realized that "dim checkpatch" doesn't actually do any additional
checks beyond scripts/checkpatch.pl. Fixes tags are checked only as a
part of "dim push". I wonder if this could be changed [1].

[1] https://gitlab.freedesktop.org/drm/maintainer-tools/merge_requests/5

regards
Philipp

Re: linux-next: Fixes tags need some work in the drm-fixes tree

[Daniel Vetter]

On Fri, Jun 21, 2019 at 02:45:45PM +0200, Philipp Zabel wrote:
> On Fri, 2019-06-21 at 21:41 +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   912bbf7e9ca4 ("gpu: ipu-v3: image-convert: Fix image downsize coefficients")
> > 
> > Fixes tag
> > 
> >   Fixes: 70b9b6b3bcb21 ("gpu: ipu-v3: image-convert: calculate per-tile
> > 
> > has these problem(s):
> > 
> >   - Please don't split Fixes tags across more than one line
> > 
> > In commit
> > 
> >   bca4d70cf1b8 ("gpu: ipu-v3: image-convert: Fix input bytesperline for packed formats")
> > 
> > Fixes tag
> > 
> >   Fixes: d966e23d61a2c ("gpu: ipu-v3: image-convert: fix bytesperline
> > 
> > has these problem(s):
> > 
> >   - Please don't split Fixes tags across more than one line
> > 
> > In commit
> > 
> >   ff391ecd65a1 ("gpu: ipu-v3: image-convert: Fix input bytesperline width/height align")
> > 
> > Fixes tag
> > 
> >   Fixes: d966e23d61a2c ("gpu: ipu-v3: image-convert: fix bytesperline
> > 
> > has these problem(s):
> > 
> >   - Please don't split Fixes tags across more than one line
> > 
> 
> I was under the impression that dim would have found those, but I only
> just realized that "dim checkpatch" doesn't actually do any additional
> checks beyond scripts/checkpatch.pl. Fixes tags are checked only as a
> part of "dim push". I wonder if this could be changed [1].
> 
> [1] https://gitlab.freedesktop.org/drm/maintainer-tools/merge_requests/5

Officially we don't yet take pull requests (could try to change that, but
last time around it got nacked by Jani). Can you pls submit to dim-tools@
as patch?

Also, would be nice to run all the same checks we run at dim push time,
not just checking for Fixes tags.
-Daniel

> 
> regards
> Philipp
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

linux-next: Fixes tags need some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

Hi all,

In commit

  bb867d219fda ("gpu: ipu-v3: Fix CSI offsets for imx53")

Fixes tag

  Fixes: 2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

In commit

  2c0408dd0d89 ("gpu: ipu-v3: Fix i.MX51 CSI control registers offset")

Fixes tag

  Fixes: 2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tags need some work in the drm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

Hi all,

In commit

  4cbfa1e6c09e ("drm/vmwgfx: Fix setting of dma masks")

Fixes tag

  Fixes: 0d00c488f3de: ("drm/vmwgfx: Fix the driver for large dma addresses")

has these problem(s):

  - ':' unexpected after SHA1

In commit

  479d59026fe4 ("drm/vmwgfx: Also check for crtc status while checking for DU active")

Fixes tag

  Fixes: 9da6e26c0aae: ("drm/vmwgfx: Fix a layout race condition")

has these problem(s):

  - ':' unexpected after SHA1

In commit

  51fdbeb4ca1a ("drm/vmwgfx: Fix an uninitialized fence handle value")

Fixes tag

  Fixes: 2724b2d54cda: ("drm/vmwgfx: Use new validation interface for the modesetting code v2")

has these problem(s):

  - ':' unexpected after SHA1

In commit

  728354c005c3 ("drm/vmwgfx: Return error code from vmw_execbuf_copy_fence_user")

Fixes tag

  Fixes: ae2a104058e2: ("vmwgfx: Implement fence objects")

has these problem(s):

  - ':' unexpected after SHA1

In commit

  2b3cd6249b14 ("drm/vmwgfx: fix the check when to use dma_alloc_coherent")

Fixes tags

  Fixes: 55897af630 ("dma-direct: merge swiotlb_dma_ops into the dma_direct code")
  Fixes: 356da6d0cd ("dma-mapping: bypass indirect calls for dma-direct")

have these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]