* Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) [not found] <5d41767d.1c69fb81.d6304.4c8c@mx.google.com> @ 2019-07-31 11:24 ` Mark Brown 2019-07-31 11:35 ` Greg Kroah-Hartman 0 siblings, 1 reply; 18+ messages in thread From: Mark Brown @ 2019-07-31 11:24 UTC (permalink / raw) To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Greg Kroah-Hartman, Matthew Wilcox (Oracle) Cc: kernel-build-reports, linux-arm-kernel, netdev, devel, linux-next [-- Attachment #1: Type: text/plain, Size: 915 bytes --] On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: Today's -next fails to build an ARM allmodconfig due to: > allmodconfig (arm, gcc-8) — FAIL, 1 error, 40 warnings, 0 section mismatches > > Errors: > drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] as a result of the changes that introduced: WARNING: unmet direct dependencies detected for MDIO_OCTEON Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=m] && MDIO_BUS [=m] && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=m] Selected by [m]: - OCTEON_ETHERNET [=m] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=y] || COMPILE_TEST [=y]) which is triggered by the staging OCTEON_ETHERNET driver which misses a 64BIT dependency but added COMPILE_TEST in 171a9bae68c72f2 (staging/octeon: Allow test build on !MIPS). [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) 2019-07-31 11:24 ` next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) Mark Brown @ 2019-07-31 11:35 ` Greg Kroah-Hartman 2019-07-31 15:48 ` David Miller 0 siblings, 1 reply; 18+ messages in thread From: Greg Kroah-Hartman @ 2019-07-31 11:35 UTC (permalink / raw) To: Mark Brown Cc: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Matthew Wilcox (Oracle), devel, netdev, linux-next, linux-arm-kernel, kernel-build-reports On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: > On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: > > Today's -next fails to build an ARM allmodconfig due to: > > > allmodconfig (arm, gcc-8) — FAIL, 1 error, 40 warnings, 0 section mismatches > > > > Errors: > > drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] > > as a result of the changes that introduced: > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=m] && MDIO_BUS [=m] && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=m] > Selected by [m]: > - OCTEON_ETHERNET [=m] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=y] || COMPILE_TEST [=y]) > > which is triggered by the staging OCTEON_ETHERNET driver which misses a > 64BIT dependency but added COMPILE_TEST in 171a9bae68c72f2 > (staging/octeon: Allow test build on !MIPS). A patch was posted for this, but it needs to go through the netdev tree as that's where the offending patches are coming from. thanks, greg k-h ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) 2019-07-31 11:35 ` Greg Kroah-Hartman @ 2019-07-31 15:48 ` David Miller 2019-07-31 16:00 ` Greg KH 0 siblings, 1 reply; 18+ messages in thread From: David Miller @ 2019-07-31 15:48 UTC (permalink / raw) To: gregkh Cc: broonie, andrew, f.fainelli, hkallweit1, willy, devel, netdev, linux-next, linux-arm-kernel, kernel-build-reports From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Date: Wed, 31 Jul 2019 13:35:22 +0200 > On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: >> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: >> >> Today's -next fails to build an ARM allmodconfig due to: >> >> > allmodconfig (arm, gcc-8) ― FAIL, 1 error, 40 warnings, 0 section mismatches >> > >> > Errors: >> > drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] >> >> as a result of the changes that introduced: >> >> WARNING: unmet direct dependencies detected for MDIO_OCTEON >> Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=m] && MDIO_BUS [=m] && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=m] >> Selected by [m]: >> - OCTEON_ETHERNET [=m] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=y] || COMPILE_TEST [=y]) >> >> which is triggered by the staging OCTEON_ETHERNET driver which misses a >> 64BIT dependency but added COMPILE_TEST in 171a9bae68c72f2 >> (staging/octeon: Allow test build on !MIPS). > > A patch was posted for this, but it needs to go through the netdev tree > as that's where the offending patches are coming from. I didn't catch that, was netdev CC:'d? ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) 2019-07-31 15:48 ` David Miller @ 2019-07-31 16:00 ` Greg KH 2019-07-31 16:35 ` Nathan Chancellor 0 siblings, 1 reply; 18+ messages in thread From: Greg KH @ 2019-07-31 16:00 UTC (permalink / raw) To: David Miller Cc: devel, andrew, f.fainelli, kernel-build-reports, netdev, willy, broonie, linux-next, linux-arm-kernel, hkallweit1 On Wed, Jul 31, 2019 at 08:48:24AM -0700, David Miller wrote: > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Date: Wed, 31 Jul 2019 13:35:22 +0200 > > > On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: > >> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: > >> > >> Today's -next fails to build an ARM allmodconfig due to: > >> > >> > allmodconfig (arm, gcc-8) ― FAIL, 1 error, 40 warnings, 0 section mismatches > >> > > >> > Errors: > >> > drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] > >> > >> as a result of the changes that introduced: > >> > >> WARNING: unmet direct dependencies detected for MDIO_OCTEON > >> Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=m] && MDIO_BUS [=m] && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=m] > >> Selected by [m]: > >> - OCTEON_ETHERNET [=m] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=y] || COMPILE_TEST [=y]) > >> > >> which is triggered by the staging OCTEON_ETHERNET driver which misses a > >> 64BIT dependency but added COMPILE_TEST in 171a9bae68c72f2 > >> (staging/octeon: Allow test build on !MIPS). > > > > A patch was posted for this, but it needs to go through the netdev tree > > as that's where the offending patches are coming from. > > I didn't catch that, was netdev CC:'d? Nope, just you :( I'll resend it now and cc: netdev. thanks, greg k-h ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) 2019-07-31 16:00 ` Greg KH @ 2019-07-31 16:35 ` Nathan Chancellor 2019-07-31 16:41 ` David Miller 0 siblings, 1 reply; 18+ messages in thread From: Nathan Chancellor @ 2019-07-31 16:35 UTC (permalink / raw) To: Greg KH Cc: David Miller, devel, andrew, f.fainelli, kernel-build-reports, netdev, willy, broonie, linux-next, linux-arm-kernel, hkallweit1 On Wed, Jul 31, 2019 at 06:00:43PM +0200, Greg KH wrote: > On Wed, Jul 31, 2019 at 08:48:24AM -0700, David Miller wrote: > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Date: Wed, 31 Jul 2019 13:35:22 +0200 > > > > > On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: > > >> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: > > >> > > >> Today's -next fails to build an ARM allmodconfig due to: > > >> > > >> > allmodconfig (arm, gcc-8) ― FAIL, 1 error, 40 warnings, 0 section mismatches > > >> > > > >> > Errors: > > >> > drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] > > >> > > >> as a result of the changes that introduced: > > >> > > >> WARNING: unmet direct dependencies detected for MDIO_OCTEON > > >> Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=m] && MDIO_BUS [=m] && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=m] > > >> Selected by [m]: > > >> - OCTEON_ETHERNET [=m] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=y] || COMPILE_TEST [=y]) > > >> > > >> which is triggered by the staging OCTEON_ETHERNET driver which misses a > > >> 64BIT dependency but added COMPILE_TEST in 171a9bae68c72f2 > > >> (staging/octeon: Allow test build on !MIPS). > > > > > > A patch was posted for this, but it needs to go through the netdev tree > > > as that's where the offending patches are coming from. > > > > I didn't catch that, was netdev CC:'d? > > Nope, just you :( > > I'll resend it now and cc: netdev. > > thanks, > > greg k-h If it is this patch: https://lore.kernel.org/netdev/20190731160219.GA2114@kroah.com/ It doesn't resolve that issue. I applied it and tested on next-20190731. $ make -j$(nproc) -s ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- O=out distclean allyesconfig drivers/net/phy/ WARNING: unmet direct dependencies detected for MDIO_OCTEON Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] Selected by [y]: - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC || COMPILE_TEST [=y]) && NETDEVICES [=y] ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': ../drivers/net/phy/mdio-octeon.c:48:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 48 | (u64)devm_ioremap(&pdev->dev, mdio_phys, regsize); | ^ In file included from ../drivers/net/phy/mdio-octeon.c:14: ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of function 'writeq'; did you mean 'writeb'? [-Werror=implicit-function-declaration] 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) | ^~~~~~ ../drivers/net/phy/mdio-octeon.c:56:2: note: in expansion of macro 'oct_mdio_writeq' 56 | oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); | ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.h:111:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) | ^ ../drivers/net/phy/mdio-octeon.c:56:2: note: in expansion of macro 'oct_mdio_writeq' 56 | oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); | ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.h:111:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) | ^ ../drivers/net/phy/mdio-octeon.c:77:2: note: in expansion of macro 'oct_mdio_writeq' 77 | oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); | ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_remove': ../drivers/net/phy/mdio-cavium.h:111:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) | ^ ../drivers/net/phy/mdio-octeon.c:91:2: note: in expansion of macro 'oct_mdio_writeq' 91 | oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[3]: *** [../scripts/Makefile.build:274: drivers/net/phy/mdio-octeon.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [../Makefile:1780: drivers/net/phy/] Error 2 make[1]: *** [/home/nathan/cbl/linux-next/Makefile:330: __build_one_by_one] Error 2 make: *** [Makefile:179: sub-make] Error 2 This is the diff that I came up with to solve the errors plus the casting warnings but it doesn't feel proper to me. If you all feel otherwise, I can draft up a formal commit message. diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 20f14c5fbb7e..ed2edf4b5b0e 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -159,7 +159,7 @@ config MDIO_MSCC_MIIM config MDIO_OCTEON tristate "Octeon and some ThunderX SOCs MDIO buses" - depends on 64BIT + depends on 64BIT || COMPILE_TEST depends on HAS_IOMEM && OF_MDIO select MDIO_CAVIUM help diff --git a/drivers/net/phy/mdio-cavium.h b/drivers/net/phy/mdio-cavium.h index ed5f9bb5448d..4b71b733edb4 100644 --- a/drivers/net/phy/mdio-cavium.h +++ b/drivers/net/phy/mdio-cavium.h @@ -108,8 +108,10 @@ static inline u64 oct_mdio_readq(u64 addr) return cvmx_read_csr(addr); } #else -#define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) -#define oct_mdio_readq(addr) readq((void *)addr) +#include <linux/io-64-nonatomic-lo-hi.h> + +#define oct_mdio_writeq(val, addr) writeq(val, (void *)(uintptr_t)addr) +#define oct_mdio_readq(addr) readq((void *)(uintptr_t)addr) #endif int cavium_mdiobus_read(struct mii_bus *bus, int phy_id, int regnum); diff --git a/drivers/net/phy/mdio-octeon.c b/drivers/net/phy/mdio-octeon.c index 8327382aa568..ab0d8ab588e4 100644 --- a/drivers/net/phy/mdio-octeon.c +++ b/drivers/net/phy/mdio-octeon.c @@ -45,7 +45,7 @@ static int octeon_mdiobus_probe(struct platform_device *pdev) } bus->register_base = - (u64)devm_ioremap(&pdev->dev, mdio_phys, regsize); + (u64)(uintptr_t)devm_ioremap(&pdev->dev, mdio_phys, regsize); if (!bus->register_base) { dev_err(&pdev->dev, "dev_ioremap failed\n"); return -ENOMEM; ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) 2019-07-31 16:35 ` Nathan Chancellor @ 2019-07-31 16:41 ` David Miller 2019-07-31 18:50 ` [PATCH] net: mdio-octeon: Fix build error and Kconfig warning Nathan Chancellor 0 siblings, 1 reply; 18+ messages in thread From: David Miller @ 2019-07-31 16:41 UTC (permalink / raw) To: natechancellor Cc: gregkh, devel, andrew, f.fainelli, kernel-build-reports, netdev, willy, broonie, linux-next, linux-arm-kernel, hkallweit1 From: Nathan Chancellor <natechancellor@gmail.com> Date: Wed, 31 Jul 2019 09:35:09 -0700 > In file included from ../drivers/net/phy/mdio-octeon.c:14: > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of function 'writeq'; did you mean 'writeb'? [-Werror=implicit-function-declaration] > 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) One of the hi-lo, lo-hi writeq/readq headers has to be included. ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] net: mdio-octeon: Fix build error and Kconfig warning 2019-07-31 16:41 ` David Miller @ 2019-07-31 18:50 ` Nathan Chancellor 2019-07-31 21:55 ` Randy Dunlap ` (2 more replies) 0 siblings, 3 replies; 18+ messages in thread From: Nathan Chancellor @ 2019-07-31 18:50 UTC (permalink / raw) To: davem Cc: andrew, broonie, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, natechancellor, netdev, willy, kbuild test robot, Randy Dunlap arm allyesconfig warns: WARNING: unmet direct dependencies detected for MDIO_OCTEON Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] Selected by [y]: - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES [=y] || COMPILE_TEST [=y]) and errors: In file included from ../drivers/net/phy/mdio-octeon.c:14: ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of function 'writeq'; did you mean 'writeb'? [-Werror=implicit-function-declaration] 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) | ^~~~~~ ../drivers/net/phy/mdio-octeon.c:56:2: note: in expansion of macro 'oct_mdio_writeq' 56 | oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors This allows MDIO_OCTEON to be built with COMPILE_TEST as well and includes the proper header for readq/writeq. This does not address the several -Wint-to-pointer-cast and -Wpointer-to-int-cast warnings that appeared as a result of commit 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") in these files. Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Mark Brown <broonie@kernel.org> Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/net/phy/Kconfig | 2 +- drivers/net/phy/mdio-cavium.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 20f14c5fbb7e..ed2edf4b5b0e 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -159,7 +159,7 @@ config MDIO_MSCC_MIIM config MDIO_OCTEON tristate "Octeon and some ThunderX SOCs MDIO buses" - depends on 64BIT + depends on 64BIT || COMPILE_TEST depends on HAS_IOMEM && OF_MDIO select MDIO_CAVIUM help diff --git a/drivers/net/phy/mdio-cavium.h b/drivers/net/phy/mdio-cavium.h index ed5f9bb5448d..b7f89ad27465 100644 --- a/drivers/net/phy/mdio-cavium.h +++ b/drivers/net/phy/mdio-cavium.h @@ -108,6 +108,8 @@ static inline u64 oct_mdio_readq(u64 addr) return cvmx_read_csr(addr); } #else +#include <linux/io-64-nonatomic-lo-hi.h> + #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) #define oct_mdio_readq(addr) readq((void *)addr) #endif -- 2.22.0 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning 2019-07-31 18:50 ` [PATCH] net: mdio-octeon: Fix build error and Kconfig warning Nathan Chancellor @ 2019-07-31 21:55 ` Randy Dunlap 2019-07-31 23:52 ` Randy Dunlap 2019-08-03 1:11 ` David Miller 2019-08-03 6:01 ` [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors Nathan Chancellor 2 siblings, 1 reply; 18+ messages in thread From: Randy Dunlap @ 2019-07-31 21:55 UTC (permalink / raw) To: Nathan Chancellor, davem Cc: andrew, broonie, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, netdev, willy, kbuild test robot [-- Attachment #1: Type: text/plain, Size: 3444 bytes --] On 7/31/19 11:50 AM, Nathan Chancellor wrote: > arm allyesconfig warns: > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] > Selected by [y]: > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && > NETDEVICES [=y] || COMPILE_TEST [=y]) > > and errors: > > In file included from ../drivers/net/phy/mdio-octeon.c:14: > ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > function 'writeq'; did you mean 'writeb'? > [-Werror=implicit-function-declaration] > 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) > | ^~~~~~ > ../drivers/net/phy/mdio-octeon.c:56:2: note: in expansion of macro > 'oct_mdio_writeq' > 56 | oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); > | ^~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > This allows MDIO_OCTEON to be built with COMPILE_TEST as well and > includes the proper header for readq/writeq. This does not address > the several -Wint-to-pointer-cast and -Wpointer-to-int-cast warnings > that appeared as a result of commit 171a9bae68c7 ("staging/octeon: > Allow test build on !MIPS") in these files. > > Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: Mark Brown <broonie@kernel.org> > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> With today's linux-next (20190731), I am still seeing a Kconfig warning and build errors (building for i386): and applying Greg's "depends on NETDEVICES" patch and this patch: WARNING: unmet direct dependencies detected for MDIO_OCTEON Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=m] && MDIO_BUS [=m] && (64BIT [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y] && OF_MDIO [=n] Selected by [m]: - OCTEON_ETHERNET [=m] && STAGING [=y] && (CAVIUM_OCTEON_SOC || COMPILE_TEST [=y]) && NETDEVICES [=y] ERROR: "cavium_mdiobus_write" [drivers/net/phy/mdio-octeon.ko] undefined! ERROR: "cavium_mdiobus_read" [drivers/net/phy/mdio-octeon.ko] undefined! kernel .config file is attached. Am I missing another patch? thanks. > --- > drivers/net/phy/Kconfig | 2 +- > drivers/net/phy/mdio-cavium.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index 20f14c5fbb7e..ed2edf4b5b0e 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -159,7 +159,7 @@ config MDIO_MSCC_MIIM > > config MDIO_OCTEON > tristate "Octeon and some ThunderX SOCs MDIO buses" > - depends on 64BIT > + depends on 64BIT || COMPILE_TEST > depends on HAS_IOMEM && OF_MDIO > select MDIO_CAVIUM > help > diff --git a/drivers/net/phy/mdio-cavium.h b/drivers/net/phy/mdio-cavium.h > index ed5f9bb5448d..b7f89ad27465 100644 > --- a/drivers/net/phy/mdio-cavium.h > +++ b/drivers/net/phy/mdio-cavium.h > @@ -108,6 +108,8 @@ static inline u64 oct_mdio_readq(u64 addr) > return cvmx_read_csr(addr); > } > #else > +#include <linux/io-64-nonatomic-lo-hi.h> > + > #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) > #define oct_mdio_readq(addr) readq((void *)addr) > #endif > -- ~Randy [-- Attachment #2: cavium.i386.config --] [-- Type: application/x-config, Size: 107345 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning 2019-07-31 21:55 ` Randy Dunlap @ 2019-07-31 23:52 ` Randy Dunlap 2019-09-19 9:06 ` Geert Uytterhoeven 0 siblings, 1 reply; 18+ messages in thread From: Randy Dunlap @ 2019-07-31 23:52 UTC (permalink / raw) To: Nathan Chancellor, davem Cc: andrew, broonie, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, netdev, willy, kbuild test robot On 7/31/19 2:55 PM, Randy Dunlap wrote: > On 7/31/19 11:50 AM, Nathan Chancellor wrote: >> arm allyesconfig warns: >> >> WARNING: unmet direct dependencies detected for MDIO_OCTEON >> Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] >> && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] >> Selected by [y]: >> - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && >> NETDEVICES [=y] || COMPILE_TEST [=y]) >> >> and errors: >> >> In file included from ../drivers/net/phy/mdio-octeon.c:14: >> ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': >> ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of >> function 'writeq'; did you mean 'writeb'? >> [-Werror=implicit-function-declaration] >> 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) >> | ^~~~~~ >> ../drivers/net/phy/mdio-octeon.c:56:2: note: in expansion of macro >> 'oct_mdio_writeq' >> 56 | oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); >> | ^~~~~~~~~~~~~~~ >> cc1: some warnings being treated as errors >> >> This allows MDIO_OCTEON to be built with COMPILE_TEST as well and >> includes the proper header for readq/writeq. This does not address >> the several -Wint-to-pointer-cast and -Wpointer-to-int-cast warnings >> that appeared as a result of commit 171a9bae68c7 ("staging/octeon: >> Allow test build on !MIPS") in these files. >> >> Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") >> Reported-by: kbuild test robot <lkp@intel.com> >> Reported-by: Mark Brown <broonie@kernel.org> >> Reported-by: Randy Dunlap <rdunlap@infradead.org> >> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > > With today's linux-next (20190731), I am still seeing a Kconfig warning and > build errors (building for i386): > > and applying Greg's "depends on NETDEVICES" patch and this patch: > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=m] && MDIO_BUS [=m] && (64BIT [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y] && OF_MDIO [=n] > Selected by [m]: > - OCTEON_ETHERNET [=m] && STAGING [=y] && (CAVIUM_OCTEON_SOC || COMPILE_TEST [=y]) && NETDEVICES [=y] > > ERROR: "cavium_mdiobus_write" [drivers/net/phy/mdio-octeon.ko] undefined! > ERROR: "cavium_mdiobus_read" [drivers/net/phy/mdio-octeon.ko] undefined! > > > kernel .config file is attached. > > Am I missing another patch? > > thanks. If I add this to drivers/staging/octeon/Kconfig: select MDIO_OCTEON + select MDIO_CAVIUM help then the build succeeds. This isn't being done by make *config because MDIO_OCTEON depends on OF_MDIO, which is not set in my .config file, so the "select MDIO_CAVIUM" in MDIO_OCTEON is not done. However, there are lots of type/cast warnings in both mdio-octeon and mdio-cavium: ../drivers/net/phy/mdio-octeon.c: In function ‘octeon_mdiobus_probe’: ../drivers/net/phy/mdio-octeon.c:48:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] (u64)devm_ioremap(&pdev->dev, mdio_phys, regsize); ^ In file included from ../drivers/net/phy/mdio-octeon.c:14:0: ../drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ ../drivers/net/phy/mdio-octeon.c:56:2: note: in expansion of macro ‘oct_mdio_writeq’ oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ ../drivers/net/phy/mdio-octeon.c:77:2: note: in expansion of macro ‘oct_mdio_writeq’ oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-octeon.c: In function ‘octeon_mdiobus_remove’: ../drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ ../drivers/net/phy/mdio-octeon.c:91:2: note: in expansion of macro ‘oct_mdio_writeq’ oct_mdio_writeq(smi_en.u64, bus->register_base + SMI_EN); ^~~~~~~~~~~~~~~ and CC [M] drivers/net/phy/mdio-cavium.o In file included from ../drivers/net/phy/mdio-cavium.c:11:0: ../drivers/net/phy/mdio-cavium.c: In function ‘cavium_mdiobus_set_mode’: ../drivers/net/phy/mdio-cavium.h:114:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_readq(addr) readq((void *)addr) ^ ../drivers/net/phy/mdio-cavium.c:21:16: note: in expansion of macro ‘oct_mdio_readq’ smi_clk.u64 = oct_mdio_readq(p->register_base + SMI_CLK); ^~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ ../drivers/net/phy/mdio-cavium.c:24:2: note: in expansion of macro ‘oct_mdio_writeq’ oct_mdio_writeq(smi_clk.u64, p->register_base + SMI_CLK); ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.c: In function ‘cavium_mdiobus_c45_addr’: ../drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ ../drivers/net/phy/mdio-cavium.c:39:2: note: in expansion of macro ‘oct_mdio_writeq’ oct_mdio_writeq(smi_wr.u64, p->register_base + SMI_WR_DAT); ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ ../drivers/net/phy/mdio-cavium.c:47:2: note: in expansion of macro ‘oct_mdio_writeq’ oct_mdio_writeq(smi_cmd.u64, p->register_base + SMI_CMD); ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.h:114:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_readq(addr) readq((void *)addr) ^ ../drivers/net/phy/mdio-cavium.c:54:16: note: in expansion of macro ‘oct_mdio_readq’ smi_wr.u64 = oct_mdio_readq(p->register_base + SMI_WR_DAT); ^~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.c: In function ‘cavium_mdiobus_read’: ../drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ ../drivers/net/phy/mdio-cavium.c:86:2: note: in expansion of macro ‘oct_mdio_writeq’ oct_mdio_writeq(smi_cmd.u64, p->register_base + SMI_CMD); ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.h:114:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_readq(addr) readq((void *)addr) ^ ../drivers/net/phy/mdio-cavium.c:93:16: note: in expansion of macro ‘oct_mdio_readq’ smi_rd.u64 = oct_mdio_readq(p->register_base + SMI_RD_DAT); ^~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.c: In function ‘cavium_mdiobus_write’: ../drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ ../drivers/net/phy/mdio-cavium.c:125:2: note: in expansion of macro ‘oct_mdio_writeq’ oct_mdio_writeq(smi_wr.u64, p->register_base + SMI_WR_DAT); ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) ^ ../drivers/net/phy/mdio-cavium.c:131:2: note: in expansion of macro ‘oct_mdio_writeq’ oct_mdio_writeq(smi_cmd.u64, p->register_base + SMI_CMD); ^~~~~~~~~~~~~~~ ../drivers/net/phy/mdio-cavium.h:114:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define oct_mdio_readq(addr) readq((void *)addr) ^ ../drivers/net/phy/mdio-cavium.c:138:16: note: in expansion of macro ‘oct_mdio_readq’ smi_wr.u64 = oct_mdio_readq(p->register_base + SMI_WR_DAT); ^~~~~~~~~~~~~~ >> --- >> drivers/net/phy/Kconfig | 2 +- >> drivers/net/phy/mdio-cavium.h | 2 ++ >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig >> index 20f14c5fbb7e..ed2edf4b5b0e 100644 >> --- a/drivers/net/phy/Kconfig >> +++ b/drivers/net/phy/Kconfig >> @@ -159,7 +159,7 @@ config MDIO_MSCC_MIIM >> >> config MDIO_OCTEON >> tristate "Octeon and some ThunderX SOCs MDIO buses" >> - depends on 64BIT >> + depends on 64BIT || COMPILE_TEST >> depends on HAS_IOMEM && OF_MDIO >> select MDIO_CAVIUM >> help >> diff --git a/drivers/net/phy/mdio-cavium.h b/drivers/net/phy/mdio-cavium.h >> index ed5f9bb5448d..b7f89ad27465 100644 >> --- a/drivers/net/phy/mdio-cavium.h >> +++ b/drivers/net/phy/mdio-cavium.h >> @@ -108,6 +108,8 @@ static inline u64 oct_mdio_readq(u64 addr) >> return cvmx_read_csr(addr); >> } >> #else >> +#include <linux/io-64-nonatomic-lo-hi.h> >> + >> #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) >> #define oct_mdio_readq(addr) readq((void *)addr) >> #endif >> > > -- ~Randy ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning 2019-07-31 23:52 ` Randy Dunlap @ 2019-09-19 9:06 ` Geert Uytterhoeven 0 siblings, 0 replies; 18+ messages in thread From: Geert Uytterhoeven @ 2019-09-19 9:06 UTC (permalink / raw) To: Randy Dunlap Cc: Nathan Chancellor, David S. Miller, driverdevel, Andrew Lunn, Florian Fainelli, kbuild test robot, kernel-build-reports, Greg KH, Matthew Wilcox, Mark Brown, Linux-Next, netdev, Linux ARM, Heiner Kallweit On Thu, Aug 1, 2019 at 1:52 AM Randy Dunlap <rdunlap@infradead.org> wrote: > However, there are lots of type/cast warnings in both mdio-octeon and mdio-cavium: > > ../drivers/net/phy/mdio-octeon.c: In function ‘octeon_mdiobus_probe’: > ../drivers/net/phy/mdio-octeon.c:48:3: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > (u64)devm_ioremap(&pdev->dev, mdio_phys, regsize); > ^ cavium_mdiobus.register_base should be "void __iomem *" instead of "u64", and the cast should be dropped. > In file included from ../drivers/net/phy/mdio-octeon.c:14:0: > ../drivers/net/phy/mdio-cavium.h:113:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) > ^ ... which allows to drop this cast as well. Casts are evil, and usually a sign that you're doing something wrong. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning 2019-07-31 18:50 ` [PATCH] net: mdio-octeon: Fix build error and Kconfig warning Nathan Chancellor 2019-07-31 21:55 ` Randy Dunlap @ 2019-08-03 1:11 ` David Miller 2019-08-03 1:30 ` Nathan Chancellor 2019-08-03 6:01 ` [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors Nathan Chancellor 2 siblings, 1 reply; 18+ messages in thread From: David Miller @ 2019-08-03 1:11 UTC (permalink / raw) To: natechancellor Cc: andrew, broonie, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, netdev, willy, lkp, rdunlap From: Nathan Chancellor <natechancellor@gmail.com> Date: Wed, 31 Jul 2019 11:50:24 -0700 > arm allyesconfig warns: > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] > Selected by [y]: > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && > NETDEVICES [=y] || COMPILE_TEST [=y]) > > and errors: > > In file included from ../drivers/net/phy/mdio-octeon.c:14: > ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > function 'writeq'; did you mean 'writeb'? The proper way to fix this is to include either linux/io-64-nonatomic-hi-lo.h or linux/io-64-nonatomic-lo-hi.h whichever is appropriate. ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning 2019-08-03 1:11 ` David Miller @ 2019-08-03 1:30 ` Nathan Chancellor 2019-08-03 1:39 ` Matthew Wilcox 0 siblings, 1 reply; 18+ messages in thread From: Nathan Chancellor @ 2019-08-03 1:30 UTC (permalink / raw) To: David Miller Cc: andrew, broonie, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, netdev, willy, lkp, rdunlap On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote: > From: Nathan Chancellor <natechancellor@gmail.com> > Date: Wed, 31 Jul 2019 11:50:24 -0700 > > > arm allyesconfig warns: > > > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] > > Selected by [y]: > > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && > > NETDEVICES [=y] || COMPILE_TEST [=y]) > > > > and errors: > > > > In file included from ../drivers/net/phy/mdio-octeon.c:14: > > ../drivers/net/phy/mdio-octeon.c: In function 'octeon_mdiobus_probe': > > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > > function 'writeq'; did you mean 'writeb'? > > The proper way to fix this is to include either > > linux/io-64-nonatomic-hi-lo.h > > or > > linux/io-64-nonatomic-lo-hi.h > > whichever is appropriate. Hmmmm, is that not what I did? Although I did not know about io-64-nonatomic-hi-lo.h. What is the difference and which one is needed here? There is apparently another failure when OF_MDIO is not set, I guess I can try to look into that as well and respin into a series if necessary. Cheers, Nathan ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning 2019-08-03 1:30 ` Nathan Chancellor @ 2019-08-03 1:39 ` Matthew Wilcox 2019-08-03 6:05 ` Nathan Chancellor 0 siblings, 1 reply; 18+ messages in thread From: Matthew Wilcox @ 2019-08-03 1:39 UTC (permalink / raw) To: Nathan Chancellor Cc: David Miller, andrew, broonie, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, netdev, lkp, rdunlap On Fri, Aug 02, 2019 at 06:30:31PM -0700, Nathan Chancellor wrote: > On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote: > > The proper way to fix this is to include either > > > > linux/io-64-nonatomic-hi-lo.h > > > > or > > > > linux/io-64-nonatomic-lo-hi.h > > > > whichever is appropriate. > > Hmmmm, is that not what I did? > > Although I did not know about io-64-nonatomic-hi-lo.h. What is the > difference and which one is needed here? Whether you write the high or low 32 bits first. For this, it doesn't matter, since the compiled driver will never be run on real hardware. > There is apparently another failure when OF_MDIO is not set, I guess I > can try to look into that as well and respin into a series if > necessary. Thanks for taking care of that! ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning 2019-08-03 1:39 ` Matthew Wilcox @ 2019-08-03 6:05 ` Nathan Chancellor 0 siblings, 0 replies; 18+ messages in thread From: Nathan Chancellor @ 2019-08-03 6:05 UTC (permalink / raw) To: Matthew Wilcox Cc: David Miller, andrew, broonie, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, netdev, lkp, rdunlap On Fri, Aug 02, 2019 at 06:39:52PM -0700, Matthew Wilcox wrote: > On Fri, Aug 02, 2019 at 06:30:31PM -0700, Nathan Chancellor wrote: > > On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote: > > > The proper way to fix this is to include either > > > > > > linux/io-64-nonatomic-hi-lo.h > > > > > > or > > > > > > linux/io-64-nonatomic-lo-hi.h > > > > > > whichever is appropriate. > > > > Hmmmm, is that not what I did? > > > > Although I did not know about io-64-nonatomic-hi-lo.h. What is the > > difference and which one is needed here? > > Whether you write the high or low 32 bits first. For this, it doesn't > matter, since the compiled driver will never be run on real hardware. That's what I figured. I have only seen lo-hi used personally, which is what I went with here. Thanks for the confirmation! > > > There is apparently another failure when OF_MDIO is not set, I guess I > > can try to look into that as well and respin into a series if > > necessary. > > Thanks for taking care of that! ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors 2019-07-31 18:50 ` [PATCH] net: mdio-octeon: Fix build error and Kconfig warning Nathan Chancellor 2019-07-31 21:55 ` Randy Dunlap 2019-08-03 1:11 ` David Miller @ 2019-08-03 6:01 ` Nathan Chancellor 2019-08-03 18:34 ` Randy Dunlap 2019-08-06 21:11 ` David Miller 2 siblings, 2 replies; 18+ messages in thread From: Nathan Chancellor @ 2019-08-03 6:01 UTC (permalink / raw) To: natechancellor Cc: andrew, broonie, davem, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, lkp, netdev, rdunlap, willy After commit 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS"), the following combination of configs cause a few Kconfig warnings and build errors (distilled from arm allyesconfig and Randy's randconfig builds): CONFIG_NETDEVICES=y CONFIG_STAGING=y CONFIG_COMPILE_TEST=y and CONFIG_OCTEON_ETHERNET as either a module or built-in. WARNING: unmet direct dependencies detected for MDIO_OCTEON Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] && 64BIT [=n] && HAS_IOMEM [=y] && OF_MDIO [=n] Selected by [y]: - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC || COMPILE_TEST [=y]) && NETDEVICES [=y] In file included from ../drivers/net/phy/mdio-octeon.c:14: ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration] 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) | ^~~~~~ CONFIG_64BIT is not strictly necessary if the proper readq/writeq definitions are included from io-64-nonatomic-lo-hi.h. CONFIG_OF_MDIO is not needed when CONFIG_COMPILE_TEST is enabled because of commit f9dc9ac51610 ("of/mdio: Add dummy functions in of_mdio.h."). Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Mark Brown <broonie@kernel.org> Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- v1 -> v2: * Address Randy's reported failure here: https://lore.kernel.org/netdev/b3444283-7a77-ece8-7ac6-41756aa7dc60@infradead.org/ by not requiring CONFIG_OF_MDIO when CONFIG_COMPILE_TEST is set. * Improve commit message drivers/net/phy/Kconfig | 4 ++-- drivers/net/phy/mdio-cavium.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 20f14c5fbb7e..0e3d9e3d3533 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -159,8 +159,8 @@ config MDIO_MSCC_MIIM config MDIO_OCTEON tristate "Octeon and some ThunderX SOCs MDIO buses" - depends on 64BIT - depends on HAS_IOMEM && OF_MDIO + depends on (64BIT && OF_MDIO) || COMPILE_TEST + depends on HAS_IOMEM select MDIO_CAVIUM help This module provides a driver for the Octeon and ThunderX MDIO diff --git a/drivers/net/phy/mdio-cavium.h b/drivers/net/phy/mdio-cavium.h index ed5f9bb5448d..b7f89ad27465 100644 --- a/drivers/net/phy/mdio-cavium.h +++ b/drivers/net/phy/mdio-cavium.h @@ -108,6 +108,8 @@ static inline u64 oct_mdio_readq(u64 addr) return cvmx_read_csr(addr); } #else +#include <linux/io-64-nonatomic-lo-hi.h> + #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) #define oct_mdio_readq(addr) readq((void *)addr) #endif -- 2.23.0.rc1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors 2019-08-03 6:01 ` [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors Nathan Chancellor @ 2019-08-03 18:34 ` Randy Dunlap 2019-08-06 21:11 ` David Miller 1 sibling, 0 replies; 18+ messages in thread From: Randy Dunlap @ 2019-08-03 18:34 UTC (permalink / raw) To: Nathan Chancellor Cc: andrew, broonie, davem, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, lkp, netdev, willy On 8/2/19 11:01 PM, Nathan Chancellor wrote: > After commit 171a9bae68c7 ("staging/octeon: Allow test build on > !MIPS"), the following combination of configs cause a few Kconfig > warnings and build errors (distilled from arm allyesconfig and Randy's > randconfig builds): > > CONFIG_NETDEVICES=y > CONFIG_STAGING=y > CONFIG_COMPILE_TEST=y > > and CONFIG_OCTEON_ETHERNET as either a module or built-in. > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > && 64BIT [=n] && HAS_IOMEM [=y] && OF_MDIO [=n] > Selected by [y]: > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC || > COMPILE_TEST [=y]) && NETDEVICES [=y] > > In file included from ../drivers/net/phy/mdio-octeon.c:14: > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > function ‘writeq’; did you mean ‘writel’? > [-Werror=implicit-function-declaration] > 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) > | ^~~~~~ > > CONFIG_64BIT is not strictly necessary if the proper readq/writeq > definitions are included from io-64-nonatomic-lo-hi.h. > > CONFIG_OF_MDIO is not needed when CONFIG_COMPILE_TEST is enabled because > of commit f9dc9ac51610 ("of/mdio: Add dummy functions in of_mdio.h."). > > Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: Mark Brown <broonie@kernel.org> > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Works for me. Fixes the reported build errors. Thanks. Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested > --- > > v1 -> v2: > > * Address Randy's reported failure here: https://lore.kernel.org/netdev/b3444283-7a77-ece8-7ac6-41756aa7dc60@infradead.org/ > by not requiring CONFIG_OF_MDIO when CONFIG_COMPILE_TEST is set. > > * Improve commit message > > drivers/net/phy/Kconfig | 4 ++-- > drivers/net/phy/mdio-cavium.h | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index 20f14c5fbb7e..0e3d9e3d3533 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -159,8 +159,8 @@ config MDIO_MSCC_MIIM > > config MDIO_OCTEON > tristate "Octeon and some ThunderX SOCs MDIO buses" > - depends on 64BIT > - depends on HAS_IOMEM && OF_MDIO > + depends on (64BIT && OF_MDIO) || COMPILE_TEST > + depends on HAS_IOMEM > select MDIO_CAVIUM > help > This module provides a driver for the Octeon and ThunderX MDIO > diff --git a/drivers/net/phy/mdio-cavium.h b/drivers/net/phy/mdio-cavium.h > index ed5f9bb5448d..b7f89ad27465 100644 > --- a/drivers/net/phy/mdio-cavium.h > +++ b/drivers/net/phy/mdio-cavium.h > @@ -108,6 +108,8 @@ static inline u64 oct_mdio_readq(u64 addr) > return cvmx_read_csr(addr); > } > #else > +#include <linux/io-64-nonatomic-lo-hi.h> > + > #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) > #define oct_mdio_readq(addr) readq((void *)addr) > #endif > -- ~Randy ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors 2019-08-03 6:01 ` [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors Nathan Chancellor 2019-08-03 18:34 ` Randy Dunlap @ 2019-08-06 21:11 ` David Miller 2019-08-07 5:10 ` Nathan Chancellor 1 sibling, 1 reply; 18+ messages in thread From: David Miller @ 2019-08-06 21:11 UTC (permalink / raw) To: natechancellor Cc: andrew, broonie, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, lkp, netdev, rdunlap, willy From: Nathan Chancellor <natechancellor@gmail.com> Date: Fri, 2 Aug 2019 23:01:56 -0700 > After commit 171a9bae68c7 ("staging/octeon: Allow test build on > !MIPS"), the following combination of configs cause a few Kconfig > warnings and build errors (distilled from arm allyesconfig and Randy's > randconfig builds): > > CONFIG_NETDEVICES=y > CONFIG_STAGING=y > CONFIG_COMPILE_TEST=y > > and CONFIG_OCTEON_ETHERNET as either a module or built-in. > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > && 64BIT [=n] && HAS_IOMEM [=y] && OF_MDIO [=n] > Selected by [y]: > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC || > COMPILE_TEST [=y]) && NETDEVICES [=y] > > In file included from ../drivers/net/phy/mdio-octeon.c:14: > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > function ‘writeq’; did you mean ‘writel’? > [-Werror=implicit-function-declaration] > 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) > | ^~~~~~ > > CONFIG_64BIT is not strictly necessary if the proper readq/writeq > definitions are included from io-64-nonatomic-lo-hi.h. > > CONFIG_OF_MDIO is not needed when CONFIG_COMPILE_TEST is enabled because > of commit f9dc9ac51610 ("of/mdio: Add dummy functions in of_mdio.h."). > > Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: Mark Brown <broonie@kernel.org> > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Applied to net-next. Please make it clear what tree your changes are targetting in the future, thank you. ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors 2019-08-06 21:11 ` David Miller @ 2019-08-07 5:10 ` Nathan Chancellor 0 siblings, 0 replies; 18+ messages in thread From: Nathan Chancellor @ 2019-08-07 5:10 UTC (permalink / raw) To: David Miller Cc: andrew, broonie, devel, f.fainelli, gregkh, hkallweit1, kernel-build-reports, linux-arm-kernel, linux-next, lkp, netdev, rdunlap, willy On Tue, Aug 06, 2019 at 02:11:33PM -0700, David Miller wrote: > From: Nathan Chancellor <natechancellor@gmail.com> > Date: Fri, 2 Aug 2019 23:01:56 -0700 > > > After commit 171a9bae68c7 ("staging/octeon: Allow test build on > > !MIPS"), the following combination of configs cause a few Kconfig > > warnings and build errors (distilled from arm allyesconfig and Randy's > > randconfig builds): > > > > CONFIG_NETDEVICES=y > > CONFIG_STAGING=y > > CONFIG_COMPILE_TEST=y > > > > and CONFIG_OCTEON_ETHERNET as either a module or built-in. > > > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > > && 64BIT [=n] && HAS_IOMEM [=y] && OF_MDIO [=n] > > Selected by [y]: > > - OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC || > > COMPILE_TEST [=y]) && NETDEVICES [=y] > > > > In file included from ../drivers/net/phy/mdio-octeon.c:14: > > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > > function ‘writeq’; did you mean ‘writel’? > > [-Werror=implicit-function-declaration] > > 111 | #define oct_mdio_writeq(val, addr) writeq(val, (void *)addr) > > | ^~~~~~ > > > > CONFIG_64BIT is not strictly necessary if the proper readq/writeq > > definitions are included from io-64-nonatomic-lo-hi.h. > > > > CONFIG_OF_MDIO is not needed when CONFIG_COMPILE_TEST is enabled because > > of commit f9dc9ac51610 ("of/mdio: Add dummy functions in of_mdio.h."). > > > > Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") > > Reported-by: kbuild test robot <lkp@intel.com> > > Reported-by: Mark Brown <broonie@kernel.org> > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > Applied to net-next. > > Please make it clear what tree your changes are targetting in the future, > thank you. Sorry for the confusion, I'll do my best to add a patch suffix in the future. Thank you for picking this up! Nathan ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2019-09-19 9:06 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <5d41767d.1c69fb81.d6304.4c8c@mx.google.com>
2019-07-31 11:24 ` next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) Mark Brown
2019-07-31 11:35 ` Greg Kroah-Hartman
2019-07-31 15:48 ` David Miller
2019-07-31 16:00 ` Greg KH
2019-07-31 16:35 ` Nathan Chancellor
2019-07-31 16:41 ` David Miller
2019-07-31 18:50 ` [PATCH] net: mdio-octeon: Fix build error and Kconfig warning Nathan Chancellor
2019-07-31 21:55 ` Randy Dunlap
2019-07-31 23:52 ` Randy Dunlap
2019-09-19 9:06 ` Geert Uytterhoeven
2019-08-03 1:11 ` David Miller
2019-08-03 1:30 ` Nathan Chancellor
2019-08-03 1:39 ` Matthew Wilcox
2019-08-03 6:05 ` Nathan Chancellor
2019-08-03 6:01 ` [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors Nathan Chancellor
2019-08-03 18:34 ` Randy Dunlap
2019-08-06 21:11 ` David Miller
2019-08-07 5:10 ` Nathan Chancellor
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).