From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Miles Chen <miles.chen@mediatek.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the akpm-current tree
Date: Thu, 1 Aug 2019 15:51:30 +1000
Message-ID: <20190801155130.29a07b1b@canb.auug.org.au> (raw)
In-Reply-To: <1564554484.28000.3.camel@mtkswgap22>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
Hi Miles,
On Wed, 31 Jul 2019 14:28:04 +0800 Miles Chen <miles.chen@mediatek.com> wrote:
>
> On Wed, 2019-07-31 at 16:11 +1000, Stephen Rothwell wrote:
> >
> > After merging the akpm-current tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > mm/memcontrol.c: In function 'invalidate_reclaim_iterators':
> > mm/memcontrol.c:1160:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
> > } while (memcg = parent_mem_cgroup(memcg));
> > ^~~~~
> >
>
> Hi Stephen,
>
> Thanks for the telling me this. Sorry for the build warning.
> Should I send patch v5 to the mailing list to fix this?
You might as well (cc'ing Andrew, of course).
I would suggest finishing that loop like this:
memcg = parent_mem_cgroup(memcg);
} while (memcg);
rather than adding a set of parentheses.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply index
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 6:11 Stephen Rothwell
2019-07-31 6:28 ` Miles Chen
2019-08-01 5:51 ` Stephen Rothwell [this message]
2019-08-01 6:15 ` Michal Hocko
2019-08-01 6:30 ` Miles Chen
2019-08-01 6:38 ` Michal Hocko
2019-08-01 6:39 ` Stephen Rothwell
2019-08-01 6:42 ` Miles Chen
-- strict thread matches above, loose matches on Subject: below --
2019-11-06 7:05 Stephen Rothwell
2019-11-06 7:52 ` Shaokun Zhang
2019-11-06 6:54 Stephen Rothwell
2019-08-07 8:00 Stephen Rothwell
2019-08-07 11:29 ` Rikard Falkeborn
2019-08-07 23:31 ` Stephen Rothwell
2019-07-31 6:16 Stephen Rothwell
2019-07-31 12:01 ` Jia-Ju Bai
2019-07-29 3:48 Stephen Rothwell
2019-07-29 3:44 Stephen Rothwell
2019-05-30 4:55 Stephen Rothwell
2019-05-30 9:02 ` Matteo Croce
2019-03-29 2:39 Stephen Rothwell
2019-04-16 6:52 ` Stephen Rothwell
2019-04-16 22:45 ` Andrew Morton
2019-01-31 5:01 Stephen Rothwell
2018-06-08 4:45 Stephen Rothwell
2018-05-04 4:17 Stephen Rothwell
2018-05-04 15:39 ` Randy Dunlap
2018-05-07 14:10 ` Minchan Kim
2018-05-07 16:47 ` Randy Dunlap
2018-05-08 10:48 ` Minchan Kim
2018-04-06 4:53 Stephen Rothwell
2018-01-02 7:04 Stephen Rothwell
2017-12-15 2:48 Stephen Rothwell
2017-11-23 2:01 Stephen Rothwell
2017-11-13 5:54 Stephen Rothwell
2017-11-13 5:42 Stephen Rothwell
2017-11-13 8:09 ` Michal Hocko
2017-11-13 8:23 ` Michal Hocko
2017-11-13 11:43 ` Arnd Bergmann
2017-11-13 11:54 ` Michal Hocko
2017-11-13 12:24 ` Arnd Bergmann
2017-11-13 12:29 ` Michal Hocko
2017-11-16 22:44 ` Stephen Rothwell
2017-11-17 3:53 ` Stephen Rothwell
2017-11-17 9:36 ` Zhangshaokun
2017-11-17 9:56 ` Arnd Bergmann
2017-08-01 5:22 Stephen Rothwell
2017-05-26 2:43 Stephen Rothwell
2017-05-26 10:16 ` Jeff Layton
2017-05-26 11:28 ` Dave Kleikamp
2017-05-19 4:44 Stephen Rothwell
2017-05-15 1:56 Stephen Rothwell
2017-05-15 4:02 ` Xunlei Pang
2017-05-15 5:07 ` Stephen Rothwell
2017-02-02 6:49 Stephen Rothwell
2016-11-09 4:10 Stephen Rothwell
2016-11-09 7:18 ` Huang Shijie
2016-11-09 21:21 ` Andrew Morton
2016-11-10 2:56 ` Stephen Rothwell
2016-06-23 6:53 Stephen Rothwell
2016-06-23 14:00 ` Mel Gorman
2016-05-27 3:07 Stephen Rothwell
2016-05-27 19:53 ` Andrew Morton
2016-04-29 6:45 Stephen Rothwell
2016-04-29 6:55 ` Stephen Rothwell
2016-04-29 13:32 ` Josh Poimboeuf
2016-04-29 14:03 ` Josh Poimboeuf
2016-04-30 5:52 ` Stephen Rothwell
2015-07-16 5:26 Stephen Rothwell
2015-07-16 23:00 ` Andrew Morton
2015-06-04 12:29 Stephen Rothwell
2015-06-04 13:56 ` Andrea Arcangeli
2015-02-04 7:48 Stephen Rothwell
2015-02-04 7:53 ` Jan Kiszka
2015-01-19 7:45 Stephen Rothwell
2015-01-19 15:50 ` Chris Mason
2014-10-30 5:19 Stephen Rothwell
2014-10-30 9:00 ` Aneesh Kumar K.V
2014-09-26 10:42 Stephen Rothwell
2014-09-29 21:30 ` Andrew Morton
2014-09-08 8:57 Stephen Rothwell
2014-06-20 5:27 Stephen Rothwell
2014-06-20 5:29 ` Yinghai Lu
2014-06-16 1:57 Stephen Rothwell
Reply instructions:
You may reply publically to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801155130.29a07b1b@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=miles.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Next Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
linux-next@vger.kernel.org
public-inbox-index linux-next
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git