Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/1] checkpatch: revert broken NOTIFIER_HEAD check
@ 2019-08-11 22:54 john.hubbard
  2019-08-11 22:54 ` [PATCH 1/1] " john.hubbard
  0 siblings, 1 reply; 3+ messages in thread
From: john.hubbard @ 2019-08-11 22:54 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, LKML, John Hubbard

From: John Hubbard <jhubbard@nvidia.com>

Hi,

This happens on today's linux-next.

If the commit message of the original patch were just a bit clearer,
I might have been able to attempt a fix, instead of a revert, but so far,
both the Perl and the English are beyond me. And we can't leave
checkpatch broken.

I'll be glad to test out actual fixes, if you like. But here's a crude
revert to kick off the discussion anyway. :)

John Hubbard (1):
  checkpatch: revert broken NOTIFIER_HEAD check

 scripts/checkpatch.pl | 1 -
 1 file changed, 1 deletion(-)

-- 
2.22.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] checkpatch: revert broken NOTIFIER_HEAD check
  2019-08-11 22:54 [PATCH 0/1] checkpatch: revert broken NOTIFIER_HEAD check john.hubbard
@ 2019-08-11 22:54 ` " john.hubbard
  2019-08-12  1:30   ` Stephen Rothwell
  0 siblings, 1 reply; 3+ messages in thread
From: john.hubbard @ 2019-08-11 22:54 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, LKML, John Hubbard, Andy Whitcroft,
	Joe Perches, Gilad Ben-Yossef, Ofir Drang, Andrew Morton

From: John Hubbard <jhubbard@nvidia.com>

commit 1a47005dd5aa ("checkpatch: add *_NOTIFIER_HEAD as var
definition") causes the following warning when run on some
patches:

Unescaped left brace in regex is passed through in regex;
marked by < --HERE in m/(?:
...
   [238 lines of appalling perl output, mercifully not included]
...
)/ at ./scripts/checkpatch.pl line 3889.

This is broken, so revert it until a better solution is found.

Fixes: 1a47005dd5aa ("checkpatch: add *_NOTIFIER_HEAD as var
definition")

Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Ofir Drang <ofir.drang@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 scripts/checkpatch.pl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 1cdacb4fd207..9fc206ab3c0c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3891,7 +3891,6 @@ sub process {
 				^.DEFINE_$Ident\(\Q$name\E\)|
 				^.DECLARE_$Ident\(\Q$name\E\)|
 				^.LIST_HEAD\(\Q$name\E\)|
-				^.{$Ident}_NOTIFIER_HEAD\(\Q$name\E\)|
 				^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
 				\b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
 			    )/x) {
-- 
2.22.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] checkpatch: revert broken NOTIFIER_HEAD check
  2019-08-11 22:54 ` [PATCH 1/1] " john.hubbard
@ 2019-08-12  1:30   ` Stephen Rothwell
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2019-08-12  1:30 UTC (permalink / raw)
  To: john.hubbard
  Cc: Linux Next Mailing List, LKML, John Hubbard, Andy Whitcroft,
	Joe Perches, Gilad Ben-Yossef, Ofir Drang, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

Hi John,

On Sun, 11 Aug 2019 15:54:43 -0700 john.hubbard@gmail.com wrote:
>
> From: John Hubbard <jhubbard@nvidia.com>
> 
> commit 1a47005dd5aa ("checkpatch: add *_NOTIFIER_HEAD as var
> definition") causes the following warning when run on some
> patches:
> 
> Unescaped left brace in regex is passed through in regex;
> marked by < --HERE in m/(?:
> ...
>    [238 lines of appalling perl output, mercifully not included]
> ...
> )/ at ./scripts/checkpatch.pl line 3889.
> 
> This is broken, so revert it until a better solution is found.
> 
> Fixes: 1a47005dd5aa ("checkpatch: add *_NOTIFIER_HEAD as var
> definition")

Thanks for the report.

I have removed that patch from linux-next today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-11 22:54 [PATCH 0/1] checkpatch: revert broken NOTIFIER_HEAD check john.hubbard
2019-08-11 22:54 ` [PATCH 1/1] " john.hubbard
2019-08-12  1:30   ` Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org linux-next@archiver.kernel.org
	public-inbox-index linux-next


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/ public-inbox