linux-next: build warning after merge of the drm-misc tree

linux-next: build warning after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

warning: same module names found:
  drivers/video/fbdev/omap2/omapfb/displays/panel-nec-nl8048hl11.ko
  drivers/gpu/drm/panel/panel-nec-nl8048hl11.ko
warning: same module names found:
  drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.ko
  drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.ko
warning: same module names found:
  drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.ko
  drivers/gpu/drm/panel/panel-sony-acx565akm.ko
warning: same module names found:
  drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.ko
  drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
warning: same module names found:
  drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.ko
  drivers/gpu/drm/panel/panel-tpo-td043mtea1.ko

Introduced by commits

  df439abe6501 ("drm/panel: Add driver for the NEC NL8048HL11 panel")
  c9cf4c2a3bd3 ("drm/panel: Add driver for the Sharp LS037V7DW01 panel")
  1c8fc3f0c5d2 ("drm/panel: Add driver for the Sony ACX565AKM panel")
  415b8dd08711 ("drm/panel: Add driver for the Toppoly TD028TTEC1 panel")
  dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 panel")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm-misc tree

[Sam Ravnborg]

Hi Stephen.

On Fri, Aug 16, 2019 at 01:31:32PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm-misc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> warning: same module names found:
>   drivers/video/fbdev/omap2/omapfb/displays/panel-nec-nl8048hl11.ko
>   drivers/gpu/drm/panel/panel-nec-nl8048hl11.ko
> warning: same module names found:
>   drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.ko
>   drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.ko
> warning: same module names found:
>   drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.ko
>   drivers/gpu/drm/panel/panel-sony-acx565akm.ko
> warning: same module names found:
>   drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.ko
>   drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> warning: same module names found:
>   drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.ko
>   drivers/gpu/drm/panel/panel-tpo-td043mtea1.ko
> 
> Introduced by commits
> 
>   df439abe6501 ("drm/panel: Add driver for the NEC NL8048HL11 panel")
>   c9cf4c2a3bd3 ("drm/panel: Add driver for the Sharp LS037V7DW01 panel")
>   1c8fc3f0c5d2 ("drm/panel: Add driver for the Sony ACX565AKM panel")
>   415b8dd08711 ("drm/panel: Add driver for the Toppoly TD028TTEC1 panel")
>   dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 panel")

Ups, had not seen this one coming.
We are in the process of removing the drivers in drivers/video/fbdev/omap2/omapfb/
and decided to introduce the new drivers early to get them out of a
longer patch series.

	Sam

Re: linux-next: build warning after merge of the drm-misc tree

[Daniel Vetter]

On Fri, Aug 16, 2019 at 6:48 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Stephen.
>
> On Fri, Aug 16, 2019 at 01:31:32PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the drm-misc tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > warning: same module names found:
> >   drivers/video/fbdev/omap2/omapfb/displays/panel-nec-nl8048hl11.ko
> >   drivers/gpu/drm/panel/panel-nec-nl8048hl11.ko
> > warning: same module names found:
> >   drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.ko
> >   drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.ko
> > warning: same module names found:
> >   drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.ko
> >   drivers/gpu/drm/panel/panel-sony-acx565akm.ko
> > warning: same module names found:
> >   drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.ko
> >   drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> > warning: same module names found:
> >   drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.ko
> >   drivers/gpu/drm/panel/panel-tpo-td043mtea1.ko
> >
> > Introduced by commits
> >
> >   df439abe6501 ("drm/panel: Add driver for the NEC NL8048HL11 panel")
> >   c9cf4c2a3bd3 ("drm/panel: Add driver for the Sharp LS037V7DW01 panel")
> >   1c8fc3f0c5d2 ("drm/panel: Add driver for the Sony ACX565AKM panel")
> >   415b8dd08711 ("drm/panel: Add driver for the Toppoly TD028TTEC1 panel")
> >   dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 panel")
>
> Ups, had not seen this one coming.
> We are in the process of removing the drivers in drivers/video/fbdev/omap2/omapfb/
> and decided to introduce the new drivers early to get them out of a
> longer patch series.

Should we have a config dependency to not allow the old fbdev omap
when the drm omap driver is enabled? I think that would take care of
all this.

Or too annoying for development?

Also note that fbdev is in drm-misc now, so we should be able to fix
this all without cross-tree conflicts.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: linux-next: build warning after merge of the drm-misc tree

[Laurent Pinchart]

Hello,

On Fri, Aug 16, 2019 at 08:23:54AM +0200, Daniel Vetter wrote:
> On Fri, Aug 16, 2019 at 6:48 AM Sam Ravnborg <sam@ravnborg.org> wrote:
> > > Hi all,
> > >
> > > After merging the drm-misc tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > >
> > > warning: same module names found:
> > >   drivers/video/fbdev/omap2/omapfb/displays/panel-nec-nl8048hl11.ko
> > >   drivers/gpu/drm/panel/panel-nec-nl8048hl11.ko
> > > warning: same module names found:
> > >   drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.ko
> > >   drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.ko
> > > warning: same module names found:
> > >   drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.ko
> > >   drivers/gpu/drm/panel/panel-sony-acx565akm.ko
> > > warning: same module names found:
> > >   drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.ko
> > >   drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> > > warning: same module names found:
> > >   drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.ko
> > >   drivers/gpu/drm/panel/panel-tpo-td043mtea1.ko
> > >
> > > Introduced by commits
> > >
> > >   df439abe6501 ("drm/panel: Add driver for the NEC NL8048HL11 panel")
> > >   c9cf4c2a3bd3 ("drm/panel: Add driver for the Sharp LS037V7DW01 panel")
> > >   1c8fc3f0c5d2 ("drm/panel: Add driver for the Sony ACX565AKM panel")
> > >   415b8dd08711 ("drm/panel: Add driver for the Toppoly TD028TTEC1 panel")
> > >   dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 panel")
> >
> > Ups, had not seen this one coming.
> > We are in the process of removing the drivers in drivers/video/fbdev/omap2/omapfb/
> > and decided to introduce the new drivers early to get them out of a
> > longer patch series.

Oops :-(

The new drivers were initially part of a patch series that removed the
duplicated drivers. The new drivers then got fast-tracked, and I didn't
notice this issue.

> Should we have a config dependency to not allow the old fbdev omap
> when the drm omap driver is enabled? I think that would take care of
> all this.
> 
> Or too annoying for development?
> 
> Also note that fbdev is in drm-misc now, so we should be able to fix
> this all without cross-tree conflicts.

Note that drivers/video/fbdev/omap2/omapfb/ will stay, it's
drivers/gpu/drm/omapdrm/displays/ that is being removed. FB_OMAP2
already depends on DRM_OMAP = n, I propose doing something similar at
the level of the individual display drivers.

-- 
Regards,

Laurent Pinchart

Re: linux-next: build warning after merge of the drm-misc tree

[Laurent Pinchart]

On Fri, Aug 16, 2019 at 12:47:15PM +0300, Laurent Pinchart wrote:
> On Fri, Aug 16, 2019 at 08:23:54AM +0200, Daniel Vetter wrote:
> > On Fri, Aug 16, 2019 at 6:48 AM Sam Ravnborg <sam@ravnborg.org> wrote:
> > > > Hi all,
> > > >
> > > > After merging the drm-misc tree, today's linux-next build (x86_64
> > > > allmodconfig) produced this warning:
> > > >
> > > > warning: same module names found:
> > > >   drivers/video/fbdev/omap2/omapfb/displays/panel-nec-nl8048hl11.ko
> > > >   drivers/gpu/drm/panel/panel-nec-nl8048hl11.ko
> > > > warning: same module names found:
> > > >   drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.ko
> > > >   drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.ko
> > > > warning: same module names found:
> > > >   drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.ko
> > > >   drivers/gpu/drm/panel/panel-sony-acx565akm.ko
> > > > warning: same module names found:
> > > >   drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.ko
> > > >   drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
> > > > warning: same module names found:
> > > >   drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.ko
> > > >   drivers/gpu/drm/panel/panel-tpo-td043mtea1.ko
> > > >
> > > > Introduced by commits
> > > >
> > > >   df439abe6501 ("drm/panel: Add driver for the NEC NL8048HL11 panel")
> > > >   c9cf4c2a3bd3 ("drm/panel: Add driver for the Sharp LS037V7DW01 panel")
> > > >   1c8fc3f0c5d2 ("drm/panel: Add driver for the Sony ACX565AKM panel")
> > > >   415b8dd08711 ("drm/panel: Add driver for the Toppoly TD028TTEC1 panel")
> > > >   dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 panel")
> > >
> > > Ups, had not seen this one coming.
> > > We are in the process of removing the drivers in drivers/video/fbdev/omap2/omapfb/
> > > and decided to introduce the new drivers early to get them out of a
> > > longer patch series.
> 
> Oops :-(
> 
> The new drivers were initially part of a patch series that removed the
> duplicated drivers. The new drivers then got fast-tracked, and I didn't
> notice this issue.
> 
> > Should we have a config dependency to not allow the old fbdev omap
> > when the drm omap driver is enabled? I think that would take care of
> > all this.
> > 
> > Or too annoying for development?
> > 
> > Also note that fbdev is in drm-misc now, so we should be able to fix
> > this all without cross-tree conflicts.
> 
> Note that drivers/video/fbdev/omap2/omapfb/ will stay, it's
> drivers/gpu/drm/omapdrm/displays/ that is being removed. FB_OMAP2
> already depends on DRM_OMAP = n, I propose doing something similar at
> the level of the individual display drivers.

I've just posted "[PATCH 0/2] Fix module name clash with omapdrm and DRM
panel modules" that should solve this issue.

-- 
Regards,

Laurent Pinchart

linux-next: build warning after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_atomic_get_mst_topology_state':
drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variable 'dev' [-Wunused-variable]
 4187 |  struct drm_device *dev = mgr->dev;
      |                     ^~~

Introduced by commit

  83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm-misc tree

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Hi Stephen,

On Fri, Feb 08, 2019 at 12:32:04PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm-misc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_probe':
> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:1053:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   return ret;
>          ^~~
> 
> Introduced by commit
> 
>   bb3b6fcb6849 ("sun6i: dsi: Convert to generic phy handling")

I just pushed a fix for this, thanks!
Maxime


-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

linux-next: build warning after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_probe':
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:1053:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
  return ret;
         ^~~

Introduced by commit

  bb3b6fcb6849 ("sun6i: dsi: Convert to generic phy handling")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm-misc tree

[Stephen Rothwell]

Hi all,

After merging the drm-misc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/msm/msm_gem.c: In function 'describe_fence':
drivers/gpu/drm/msm/msm_gem.c:761:36: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'u64' {aka 'long long unsigned int'} [-Wformat=]
   seq_printf(m, "\t%9s: %s %s seq %u\n", type,
                                   ~^
                                   %llu
drivers/gpu/drm/msm/msm_gem.c:764:5:
     fence->seqno);
     ~~~~~~~~~~~~

Introduced by commit

  b312d8ca3a7c ("dma-buf: make fence sequence numbers 64 bit v2")

-- 
Cheers,
Stephen Rothwell
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/sun4i/sun8i_tcon_top.c: In function 'sun8i_tcon_top_register_gate':
drivers/gpu/drm/sun4i/sun8i_tcon_top.c:102:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
   return index;
          ^~~~~

Introduced by commit

  af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm-misc tree

[Neil Armstrong]

On 04/05/2017 02:41 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm-misc tree, today's linux-next build
> (arm_multi_v7_defconfig) produced this warning:
> 
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:608:13: warning: 'hdmi_bus_fmt_is_yuv420' defined but not used [-Wunused-function]
>  static bool hdmi_bus_fmt_is_yuv420(unsigned int bus_format)
>              ^
> 
> Introduced by commit
> 
>   def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
> 

Hi,

I'm preparing a fix for that, sorry for the noise.

Thanks,
Neil
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

linux-next: build warning after merge of the drm-misc tree

[Stephen Rothwell]

Hi all,

After merging the drm-misc tree, today's linux-next build
(arm_multi_v7_defconfig) produced this warning:

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:608:13: warning: 'hdmi_bus_fmt_is_yuv420' defined but not used [-Wunused-function]
 static bool hdmi_bus_fmt_is_yuv420(unsigned int bus_format)
             ^

Introduced by commit

  def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")

-- 
Cheers,
Stephen Rothwell
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the drm-misc tree

[Stephen Rothwell]

Hi all,

After merging the drm-misc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from drivers/gpu/drm/drm_pci.c:29:0:
include/drm/drm_pci.h:76:64: warning: 'struct platform_device' declared inside parameter list
 extern int drm_platform_init(struct drm_driver *driver, struct platform_device *platform_device);
                                                                ^
include/drm/drm_pci.h:76:64: warning: its scope is only this definition or declaration, which is probably not what you want

Introduced by commit

  23ef59ef6dcc ("drm: Extract drm_pci.h")

A forgotten include file (or maybe just a forward declaration of the struct).

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the drm-misc tree

[Stephen Rothwell]

Hi all,

After merging the drm-misc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/pci.h:30:0,
                 from drivers/gpu/vga/vgaarb.c:40:
drivers/gpu/vga/vgaarb.c: In function 'vga_arb_device_init':
include/linux/device.h:1214:36: warning: 'dev' may be used uninitialized in this function [-Wmaybe-uninitialized]
 #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
                                    ^
drivers/gpu/vga/vgaarb.c:1410:17: note: 'dev' was declared here
  struct device *dev;
                 ^

Introduced by commit

  a75d68f62106 ("vgaarb: Use dev_printk() when possible")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the drm-misc tree

[Stephen Rothwell]

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/dma-buf/sync_file.c: In function 'sync_file_create':
drivers/dma-buf/sync_file.c:85:53: warning: format '%d' expects argument of type 'int', but argument 6 has type 'u64 {aka long long unsigned int}' [-Wformat=]
  snprintf(sync_file->name, sizeof(sync_file->name), "%s-%s%d-%d",
                                                     ^

Introduced by commit

  76bf0db55439 ("dma-buf/fence: make fence context 64 bit v2")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the drm-misc tree

[Stephen Rothwell]

Hi all,

After merging the drm-misc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/drm_crtc.c: In function 'drm_fb_release':
drivers/gpu/drm/drm_crtc.c:3494:21: warning: unused variable 'dev' [-Wunused-variable]
  struct drm_device *dev = priv->minor->dev;
                     ^

Introduced by commit

  3d2e74c94432 ("drm/core: Preserve the fb id on close.")

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au