From: coverity-bot <keescook@chromium.org>
To: Joachim Eastwood <manabian@gmail.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: nxp_spifi_read_reg(): Integer handling issues
Date: Mon, 28 Oct 2019 16:02:32 -0700 [thread overview]
Message-ID: <201910281602.801D870@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
f617b9587c16 ("mtd: spi-nor: add driver for NXP SPI Flash Interface (SPIFI)")
Coverity reported the following:
*** CID 1487374: Integer handling issues (SIGN_EXTENSION)
/drivers/mtd/spi-nor/nxp-spifi.c: 138 in nxp_spifi_read_reg()
132
133 ret = nxp_spifi_set_memory_mode_off(spifi);
134 if (ret)
135 return ret;
136
137 cmd = SPIFI_CMD_DATALEN(len) |
vvv CID 1487374: Integer handling issues (SIGN_EXTENSION)
vvv Suspicious implicit sign extension: "opcode" with type "u8" (8 bits, unsigned) is promoted in "opcode << 24" to type "int" (32 bits, signed), then sign-extended to type "unsigned long" (64 bits, unsigned). If "opcode << 24" is greater than 0x7FFFFFFF, the upper bits of the result will all be 1.
138 SPIFI_CMD_OPCODE(opcode) |
139 SPIFI_CMD_FIELDFORM_ALL_SERIAL |
140 SPIFI_CMD_FRAMEFORM_OPCODE_ONLY;
141 writel(cmd, spifi->io_base + SPIFI_CMD);
142
143 while (len--)
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487374 ("Integer handling issues")
Fixes: f617b9587c16 ("mtd: spi-nor: add driver for NXP SPI Flash Interface (SPIFI)")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-10-28 23:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281602.801D870@keescook \
--to=keescook@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=manabian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).