* Coverity: nxp_spifi_read_reg(): Integer handling issues
@ 2019-10-28 23:02 coverity-bot
0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2019-10-28 23:02 UTC (permalink / raw)
To: Joachim Eastwood
Cc: Brian Norris, Ezequiel Garcia, Gustavo A. R. Silva, linux-next
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
f617b9587c16 ("mtd: spi-nor: add driver for NXP SPI Flash Interface (SPIFI)")
Coverity reported the following:
*** CID 1487374: Integer handling issues (SIGN_EXTENSION)
/drivers/mtd/spi-nor/nxp-spifi.c: 138 in nxp_spifi_read_reg()
132
133 ret = nxp_spifi_set_memory_mode_off(spifi);
134 if (ret)
135 return ret;
136
137 cmd = SPIFI_CMD_DATALEN(len) |
vvv CID 1487374: Integer handling issues (SIGN_EXTENSION)
vvv Suspicious implicit sign extension: "opcode" with type "u8" (8 bits, unsigned) is promoted in "opcode << 24" to type "int" (32 bits, signed), then sign-extended to type "unsigned long" (64 bits, unsigned). If "opcode << 24" is greater than 0x7FFFFFFF, the upper bits of the result will all be 1.
138 SPIFI_CMD_OPCODE(opcode) |
139 SPIFI_CMD_FIELDFORM_ALL_SERIAL |
140 SPIFI_CMD_FRAMEFORM_OPCODE_ONLY;
141 writel(cmd, spifi->io_base + SPIFI_CMD);
142
143 while (len--)
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487374 ("Integer handling issues")
Fixes: f617b9587c16 ("mtd: spi-nor: add driver for NXP SPI Flash Interface (SPIFI)")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-28 23:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 23:02 Coverity: nxp_spifi_read_reg(): Integer handling issues coverity-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).