From: coverity-bot <keescook@chromium.org>
To: Yufen Yu <yuyufen@huawei.com>
Cc: Song Liu <songliubraving@fb.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: super_1_load(): Memory - illegal accesses
Date: Mon, 28 Oct 2019 16:02:53 -0700 [thread overview]
Message-ID: <201910281602.99CA1D4@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
6a5cb53aaa4e ("md: no longer compare spare disk superblock events in super_load")
Coverity reported the following:
*** CID 1487373: Memory - illegal accesses (NEGATIVE_RETURNS)
/drivers/md/md.c: 1684 in super_1_load()
1678 }
1679
1680 if ((le32_to_cpu(sb->feature_map) & MD_FEATURE_RAID0_LAYOUT) &&
1681 sb->level != 0)
1682 return -EINVAL;
1683
vvv CID 1487373: Memory - illegal accesses (NEGATIVE_RETURNS)
vvv Using variable "rdev->desc_nr" as an index to array "sb->dev_roles".
1684 role = le16_to_cpu(sb->dev_roles[rdev->desc_nr]);
1685
1686 if (!refdev) {
1687 /*
1688 * Insist of good event counter while assembling, except for
1689 * spares (which don't need an event count)
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487373 ("Memory - illegal accesses")
Fixes: 6a5cb53aaa4e ("md: no longer compare spare disk superblock events in super_load")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2019-10-28 23:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 23:02 coverity-bot [this message]
2019-10-29 2:03 ` Coverity: super_1_load(): Memory - illegal accesses Yufen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281602.99CA1D4@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).