From: Yufen Yu <yuyufen@huawei.com>
To: coverity-bot <keescook@chromium.org>
Cc: Song Liu <songliubraving@fb.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
<linux-next@vger.kernel.org>
Subject: Re: Coverity: super_1_load(): Memory - illegal accesses
Date: Tue, 29 Oct 2019 10:03:05 +0800 [thread overview]
Message-ID: <49376db7-82c0-7c88-fe11-4e91b7ed8ca4@huawei.com> (raw)
In-Reply-To: <201910281602.99CA1D4@keescook>
On 2019/10/29 7:02, coverity-bot wrote:
> Hello!
>
> This is an experimental automated report about issues detected by Coverity
> from a scan of next-20191025 as part of the linux-next weekly scan project:
> https://scan.coverity.com/projects/linux-next-weekly-scan
>
> You're getting this email because you were associated with the identified
> lines of code (noted below) that were touched by recent commits:
>
> 6a5cb53aaa4e ("md: no longer compare spare disk superblock events in super_load")
>
> Coverity reported the following:
>
> *** CID 1487373: Memory - illegal accesses (NEGATIVE_RETURNS)
> /drivers/md/md.c: 1684 in super_1_load()
> 1678 }
> 1679
> 1680 if ((le32_to_cpu(sb->feature_map) & MD_FEATURE_RAID0_LAYOUT) &&
> 1681 sb->level != 0)
> 1682 return -EINVAL;
> 1683
> vvv CID 1487373: Memory - illegal accesses (NEGATIVE_RETURNS)
> vvv Using variable "rdev->desc_nr" as an index to array "sb->dev_roles".
> 1684 role = le16_to_cpu(sb->dev_roles[rdev->desc_nr]);
> 1685
> 1686 if (!refdev) {
> 1687 /*
> 1688 * Insist of good event counter while assembling, except for
> 1689 * spares (which don't need an event count)
>
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include:
>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1487373 ("Memory - illegal accesses")
> Fixes: 6a5cb53aaa4e ("md: no longer compare spare disk superblock events in super_load")
>
>
> Thanks for your attention!
>
Thanks a lot for report!
I am sorry for forgetting to verify 'rdev->desc_nr' after moving it up.
I will send a patch to fix this.
Thanks,
Yufen
prev parent reply other threads:[~2019-10-29 2:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 23:02 Coverity: super_1_load(): Memory - illegal accesses coverity-bot
2019-10-29 2:03 ` Yufen Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49376db7-82c0-7c88-fe11-4e91b7ed8ca4@huawei.com \
--to=yuyufen@huawei.com \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-next@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).